Merge branch 'develop' into renovate/develop-package-ci-ubuntu-22.04-4.x

Author: michalChrobot

.github/workflows/pr-description-validation.yml

@@ -21,14 +21,29 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6
 
       - name: Check PR description
         uses: actions/github-script@v8
         with:
           script: |
             const pr = context.payload.pull_request;
             const body = pr.body || '';
+            
+            // List of users to skip description validation
+            // This should be automations where we don't care that much about the description format
+            const skipUsersPrefixes = [
+              'unity-renovate',
+              'svc-'
+            ];
+            
+            // If PR author is in the skip list, exit early
+            const author = pr.user.login;
+            console.log(`PR author: ${author}`);
+            if (skipUsersPrefixes.some(prefix => author.startsWith(prefix))) {
+              console.log(`Skipping PR description check for user: ${author}`);
+              return;
+            }
 
             // List of mandatory PR sections
             const requiredSections = [

.github/workflows/pr-supervisor.yaml

@@ -25,7 +25,7 @@ jobs:
     timeout-minutes: 720
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
 
       - name: Wait and Verify Yamato Job Status
         env:

.yamato/_run-all.yml

@@ -30,15 +30,15 @@ run_all_package_tests:
 {% endfor -%}
 
 
-# Runs all package tests on default editor
+# Runs all package tests on default editor (latest supported editor)
 run_all_package_tests_{{ validation_editors.default }}:
   name: Run All Package Tests [{{ validation_editors.default }} only]
   dependencies:
 {% for platform in test_platforms.desktop -%}
     - .yamato/package-tests.yml#package_test_-_ngo_{{ validation_editors.default }}_{{ platform.name }}
 {% endfor -%}
 
-# Runs all package tests on mimimum supported editor
+# Runs all package tests on minimal supported editor
 run_all_package_tests_{{ validation_editors.minimal }}:
   name: Run All Package Tests [{{ validation_editors.minimal }}]
   dependencies:
@@ -74,7 +74,7 @@ run_all_project_tests_{{ validation_editors.default }}:
 {% endif -%}
 {% endfor -%}
 
-# Runs all projects tests on mimimal supported editor
+# Runs all projects tests on minimal supported editor
 run_all_project_tests_{{ validation_editors.minimal }}:
   name: Run All Project Tests [{{ validation_editors.minimal }}]
   dependencies:
@@ -111,7 +111,7 @@ run_all_webgl_builds:
 {% endfor -%}
 
 
-# Runs all WebGL builds on default editor
+# Runs all WebGL builds on default editor (latest supported editor)
 run_all_webgl_builds_{{ validation_editors.default }}:
   name: Run All WebGl Build [{{ validation_editors.default }} only]
   dependencies:
@@ -121,7 +121,7 @@ run_all_webgl_builds_{{ validation_editors.default }}:
 {% endfor -%}
 {% endfor -%}
 
-# Runs all WebGL builds on 2022.3 editor 
+# Runs all WebGL builds on minimal supported editor
 run_all_webgl_builds_{{ validation_editors.minimal }}:
   name: Run All WebGl Build [{{ validation_editors.minimal }}]
   dependencies:
@@ -147,6 +147,7 @@ run_all_project_tests_desktop_standalone:
 {% endfor -%}
 
 
+# Runs all Desktop tests on default editor (latest supported editor)
 run_all_project_tests_desktop_standalone_{{ validation_editors.default }}:
   name: Run All Standalone Tests - Desktop [{{ validation_editors.default }} only]
   dependencies:
@@ -158,7 +159,7 @@ run_all_project_tests_desktop_standalone_{{ validation_editors.default }}:
 {% endfor -%}
 {% endfor -%}
 
-# Runs all Desktop tests on mimimum supported editor
+# Runs all Desktop tests on minimal supported editor
 run_all_project_tests_desktop_standalone_{{ validation_editors.minimal }}:
   name: Run All Standalone Tests - Desktop [{{ validation_editors.minimal }}]
   dependencies:
@@ -193,7 +194,7 @@ run_all_project_tests_mobile_standalone_{{ validation_editors.default }}:
 {% endfor -%}
 {% endfor -%}
 
-# Runs all Mobile tests on mimimum supported editor
+# Runs all Mobile tests on minimal supported editor
 run_all_project_tests_mobile_standalone_{{ validation_editors.minimal }}:
   name: Run All Standalone Tests - Mobile [{{ validation_editors.minimal }}]
   dependencies:
@@ -227,7 +228,7 @@ run_all_project_tests_console_standalone_{{ validation_editors.default }}:
 {% endfor -%}
 {% endfor -%}
 
-# Runs all Console tests on mimimum supported editor
+# Runs all Console tests on minimal supported editor
 run_all_project_tests_console_standalone_{{ validation_editors.minimal }}:
   name: Run All Standalone Tests - Console [{{ validation_editors.minimal }}]
   dependencies:

.yamato/_triggers.yml

@@ -24,7 +24,7 @@
   # Nightly:
     # This test validates same subset as pull_request_trigger with addition of mobile/console tests and webgl builds
     # Runs daily on develop (local configuration)
-    # Includes all test types but only on default editor (latest supported editor).
+    # Includes all test types but only on {{ validation_editors.default }} (latest supported editor).
     # Adds platform-specific and APV validation
 
   # Weekly:
@@ -72,15 +72,15 @@ pr_code_changes_checks:
     # Run API validation to early-detect all new APIs that would force us to release new minor version of the package. Note that for this to work the package version in package.json must correspond to "actual package state" which means that it should be higher than last released version
     - .yamato/vetting-test.yml#vetting_test
 
-    # Run package EditMode and Playmode package tests on default editor (latest supported editor) and an older supported editor
+    # Run package EditMode and Playmode package tests on {{ validation_editors.default }} (latest supported editor) and an {{ validation_editors.minimal }} supported editor
     - .yamato/package-tests.yml#package_test_-_ngo_{{ validation_editors.default }}_mac
     - .yamato/package-tests.yml#package_test_-_ngo_{{ validation_editors.minimal }}_win
 
-    # Run testproject EditMode and Playmode project tests on default editor (latest supported editor) and an older supported editor
+    # Run testproject EditMode and Playmode project tests on {{ validation_editors.default }} (latest supported editor) and an {{ validation_editors.minimal }} supported editor
     - .yamato/project-tests.yml#test_testproject_win_{{ validation_editors.default }}
     - .yamato/project-tests.yml#test_testproject_mac_{{ validation_editors.minimal }}
 
-    # Run tools integration tests EditMode and Playmode tests on default editor (latest supported editor) and an older supported editor
+    # Run tools integration tests EditMode and Playmode tests on {{ validation_editors.default }} (latest supported editor) and an {{ validation_editors.minimal }} supported editor
     - .yamato/project-tests.yml#test_testproject-tools-integration_ubuntu_{{ validation_editors.minimal }}
     - .yamato/project-tests.yml#test_testproject-tools-integration_win_{{ validation_editors.default }}
 
@@ -109,13 +109,11 @@ pr_code_changes_checks:
     cancel_old_ci: true
 
 
-
-
-# Run all tests on default editor (latest supported editor) on nightly basis.
+# Run all tests on {{ validation_editors.default }} (latest supported editor) on nightly basis.
 # Same subset as pull_request_trigger with addition of mobile/desktop/console tests and webgl builds
-# Those tests are all running on default editor (latest supported editor) since it's daily and running all of them would add a lot of overhead
+# Those tests are all running on {{ validation_editors.default }} (latest supported editor) since it's daily and running all of them would add a lot of overhead
 develop_nightly:
-  name: "\U0001F319 [Nightly] Run All Tests [default and 2022]"
+  name: "\U0001F319 [Nightly] Run All Tests [{{ validation_editors.default }} and {{ validation_editors.minimal }}]"
   triggers:
     recurring:
       - branch: develop
@@ -129,25 +127,25 @@ develop_nightly:
     - .yamato/project-standards.yml#standards_ubuntu_testproject_{{ validation_editors.minimal }}
     # Run APV jobs to make sure the change won't break any dependants
     - .yamato/wrench/preview-a-p-v.yml#all_preview_apv_jobs
-    # Run package EditMode and Playmode tests on desktop platforms on default editor (latest supported editor) and {{ validation_editors.minimal }}
+    # Run package EditMode and Playmode tests on desktop platforms on {{ validation_editors.default }} (latest supported editor) and {{ validation_editors.minimal }}
     - .yamato/_run-all.yml#run_all_package_tests_{{ validation_editors.default }}
     - .yamato/_run-all.yml#run_all_package_tests_{{ validation_editors.minimal }}
-    # Run project EditMode and PLaymode tests on desktop platforms on default editor (latest supported editor) and {{ validation_editors.minimal }}
+    # Run project EditMode and PLaymode tests on desktop platforms on {{ validation_editors.default }} (latest supported editor) and {{ validation_editors.minimal }}
     - .yamato/_run-all.yml#run_all_project_tests_{{ validation_editors.default }}
     - .yamato/_run-all.yml#run_all_project_tests_{{ validation_editors.minimal }}
-    # Run Runtime tests on desktop players on default editor (latest supported editor) and {{ validation_editors.minimal }}
+    # Run Runtime tests on desktop players on {{ validation_editors.default }} (latest supported editor) and {{ validation_editors.minimal }}
     - .yamato/_run-all.yml#run_all_project_tests_desktop_standalone_{{ validation_editors.default }}
     - .yamato/_run-all.yml#run_all_project_tests_desktop_standalone_{{ validation_editors.minimal }}
-    # Run Runtime tests on mobile players on default editor (latest supported editor) and {{ validation_editors.minimal }}
+    # Run Runtime tests on mobile players on {{ validation_editors.default }} (latest supported editor) and {{ validation_editors.minimal }}
     - .yamato/_run-all.yml#run_all_project_tests_mobile_standalone_{{ validation_editors.default }}
     - .yamato/_run-all.yml#run_all_project_tests_mobile_standalone_{{ validation_editors.minimal }}
-    # Run Runtime tests on console players on default editor (latest supported editor) and {{ validation_editors.minimal }}
+    # Run Runtime tests on console players on {{ validation_editors.default }} (latest supported editor) and {{ validation_editors.minimal }}
     - .yamato/_run-all.yml#run_all_project_tests_console_standalone_{{ validation_editors.default }}
     - .yamato/_run-all.yml#run_all_project_tests_console_standalone_{{ validation_editors.minimal }}
-    # Build player for webgl platform on default editor (latest supported editor) and {{ validation_editors.minimal }}
+    # Build player for webgl platform on {{ validation_editors.default }} (latest supported editor) and {{ validation_editors.minimal }}
     - .yamato/_run-all.yml#run_all_webgl_builds_{{ validation_editors.default }}
     - .yamato/_run-all.yml#run_all_webgl_builds_{{ validation_editors.minimal }}
-    # Run updated dependencies test on default editor (latest supported editor) and {{ validation_editors.minimal }}
+    # Build player for webgl platform on {{ validation_editors.default }} (latest supported editor) and {{ validation_editors.minimal }}
     - .yamato/project-updated-dependencies-test.yml#updated-dependencies_testproject_NGO_ubuntu_{{ validation_editors.default }}
     - .yamato/project-updated-dependencies-test.yml#updated-dependencies_testproject_NGO_win_{{ validation_editors.minimal }}
     # Run API validation to early-detect all new APIs that would force us to release new minor version of the package. Note that for this to work the package version in package.json must correspond to "actual package state" which means that it should be higher than last released version
@@ -157,7 +155,7 @@ develop_nightly:
 # Run all tests on weekly bases
 # Same subset as develop_nightly but runs per all supported editors as well as executes code coverage test and runs project standards per project
 # It's not running wrench jobs since those will run either way in nightly test run
-# This in contrast to nightly checks will run tests on all editors (not only default). Running those on weekly basis and default editor (latest supported editor) tests nightly should be a good balance between making sure that tests are passing and overhead of running lots of tests
+# This in contrast to nightly checks will run tests on all editors (not only {{ validation_editors.default }}). Running those on weekly basis and {{ validation_editors.default }} (latest supported editor) tests nightly should be a good balance between making sure that tests are passing and overhead of running lots of tests
 develop_weekly_trunk:
   name: "\U0001F319 [Weekly] Run All Tests"
   triggers:
@@ -180,7 +178,7 @@ develop_weekly_trunk:
     - .yamato/_run-all.yml#run_all_project_tests_mobile_standalone
     # Run Runtime tests on console players
     - .yamato/_run-all.yml#run_all_project_tests_console_standalone
-    # Build player for webgl platform on default editor (latest supported editor)
+    # Build player for webgl platform on {{ validation_editors.default }} (latest supported editor)
     - .yamato/_run-all.yml#run_all_webgl_builds
     # Run code coverage test
     - .yamato/code-coverage.yml#code_coverage_ubuntu_{{ validation_editors.default }}

.yamato/code-coverage.yml

@@ -12,7 +12,7 @@
 # CONFIGURATION STRUCTURE--------------------------------------------------------------
   # Jobs are generated using nested loops through:
   # 1. For default platform only (Ubuntu) since coverage would not vary between platforms (no need for checks on more platforms)
-  # 2. For default editor version (validation_editors.default) since coverage would not vary between editors (no need for checks on more editors)
+  # 2. For default editor version ({{ validation_editors.default }}) since coverage would not vary between editors (no need for checks on more editors)
 
 #TECHNICAL CONSIDERATIONS---------------------------------------------------------------
   # In theory this job also runs package tests, but we don't want to use it as default since is heavier (because of added coverage analysis) and coverage is not changing that often

.yamato/generated-scripts/infrastructure-instability-detection-linux.sh

@@ -13,8 +13,8 @@ if [ -d "infrastructure_instability_detection_standalone" ]; then
   rm -rf "infrastructure_instability_detection_standalone" || true
 fi
 
-echo "downloading and extracting infrastructure_instability_detection_standalone@1.0.0"
-curl -fs "https://artifactory-slo.bf.unity3d.com/artifactory/automation-and-tooling/infrastructure-instability-detection/standalone/1.0.0/ubuntu.zip" --output "infrastructure_instability_detection_standalone.zip" --retry 5 || true
+echo "downloading and extracting infrastructure_instability_detection_standalone@1.2.2"
+curl -fs "https://artifactory-slo.bf.unity3d.com/artifactory/automation-and-tooling/infrastructure-instability-detection/standalone/1.2.2/ubuntu.zip" --output "infrastructure_instability_detection_standalone.zip" --retry 5 || true
 
 if [ -d "infrastructure_instability_detection" ]; then
   echo "removing infrastructure_instability_detection folder to avoid name clash"

.yamato/generated-scripts/infrastructure-instability-detection-mac.sh

@@ -13,8 +13,8 @@ if [ -d "infrastructure_instability_detection_standalone" ]; then
   rm -rf "infrastructure_instability_detection_standalone" || true
 fi
 
-echo "downloading and extracting infrastructure_instability_detection_standalone@1.0.0"
-curl -fs "https://artifactory-slo.bf.unity3d.com/artifactory/automation-and-tooling/infrastructure-instability-detection/standalone/1.0.0/macos.zip" --output "infrastructure_instability_detection_standalone.zip" --retry 5 || true
+echo "downloading and extracting infrastructure_instability_detection_standalone@1.2.2"
+curl -fs "https://artifactory-slo.bf.unity3d.com/artifactory/automation-and-tooling/infrastructure-instability-detection/standalone/1.2.2/macos.zip" --output "infrastructure_instability_detection_standalone.zip" --retry 5 || true
 
 if [ -d "infrastructure_instability_detection" ]; then
   echo "removing infrastructure_instability_detection folder to avoid name clash"

.yamato/generated-scripts/infrastructure-instability-detection-win.cmd

@@ -2,7 +2,7 @@
 rem This is an auto-generated script. Do not edit manually!
 
 if exist "%TEMP%\BugReporterCrashReportJson"  for /f "delims=" %%i in ('dir /b /a-d "%TEMP%\BugReporterCrashReportJson\*.json"') do curl -X POST  -H "Content-Type: application/json" -T "%TEMP%\BugReporterCrashReportJson\%%i" "https://internal-crash-collector.prd.cds.internal.unity3d.com/api/crash" || echo Failed to upload %%i. Ignoring...
-curl -fs "https://artifactory-slo.bf.unity3d.com/artifactory/automation-and-tooling/infrastructure-instability-detection/standalone/1.0.0/windows.zip" --output "infrastructure_instability_detection_standalone.zip" --retry 5
+curl -fs "https://artifactory-slo.bf.unity3d.com/artifactory/automation-and-tooling/infrastructure-instability-detection/standalone/1.2.2/windows.zip" --output "infrastructure_instability_detection_standalone.zip" --retry 5
 IF EXIST "infrastructure_instability_detection" rmdir /s /q infrastructure_instability_detection
 powershell.exe -nologo -noprofile -command "& { Add-Type -A 'System.IO.Compression.FileSystem'; [IO.Compression.ZipFile]::ExtractToDirectory('infrastructure_instability_detection_standalone.zip', '.'); }" && DEL "infrastructure_instability_detection_standalone.zip"
 curl -fs "https://artifactory-slo.bf.unity3d.com/artifactory/automation-and-tooling/infrastructure-instability-detection/patterns.zip" --output patterns.zip --retry 5

.yamato/ngo-publish.yml

@@ -1,10 +1,10 @@
 ngo_release_preparation:
   name: "NGO release preparation"
   agent: { type: Unity::VM, flavor: b1.small, image: package-ci/ubuntu-22.04:v4 }
-  #triggers:
-  #  recurring:
-  #    - branch: develop # We make new releases from this branch
-  #      frequency: "10 ? * 1" # Runs every Sunday at 10:00 AM
+  triggers:
+    recurring:
+      - branch: develop # We make new releases from this branch
+        frequency: "10 ? * 1" # Runs every Sunday at 10:00 AM
   commands:
     - pip install PyGithub
     - pip install GitPython

.yamato/project-builders/project-builders.yml

@@ -26,7 +26,7 @@ build_{{ netcodeProject[0] }}_project:
     image: package-ci/win10:v4
     flavor: b1.xlarge
   variables:
-    UNITY_VERSION: 6000.2
+    UNITY_VERSION: 6000.0
     SCRIPTING_BACKEND_IL2CPP_MONO: il2cpp
     BURST_ON_OFF: on
     PLATFORM_WIN64_MAC_ANDROID: win64