Added Threshold to V2 Data Format Parsing

amaestas13 · amaestas13 · commit 80afdbce6fd8 · 2022-03-25T10:57:45.000-07:00
Fixed Standard Deviation in Pass Fail Calculation
diff --git a/UnityPerformanceBenchmarkReporter/Entities/Data.cs b/UnityPerformanceBenchmarkReporter/Entities/Data.cs
@@ -18,6 +18,7 @@ public class SampleGroup
         public string Name;
         public SampleUnit Unit;
         public bool IncreaseIsBetter;
+        public double Threshold = 0.15;
         public List<double> Samples = new List<double>();
         public double Min;
         public double Max;
diff --git a/UnityPerformanceBenchmarkReporter/PerformanceTestRunProcessor.cs b/UnityPerformanceBenchmarkReporter/PerformanceTestRunProcessor.cs
@@ -163,10 +163,8 @@ private double GetAggregatedSampleValue(SampleGroup sampleGroup)
         private MeasurementResult DeterminePerformanceResult(SampleGroupResult sampleGroup, uint sigFig)
         {
             var measurementResult = MeasurementResult.Neutral;
-            var positiveThresholdValue = sampleGroup.BaselineValue + sampleGroup.BaselineValue * sampleGroup.Threshold;
-            var negativeThresholdValue = sampleGroup.BaselineValue - sampleGroup.BaselineValue * sampleGroup.Threshold;
-            positiveThresholdValue += sampleGroup.StandardDeviation;
-            negativeThresholdValue -= sampleGroup.StandardDeviation;
+            var positiveThresholdValue = sampleGroup.BaselineValue + (sampleGroup.BaselineValue + sampleGroup.StandardDeviation) * sampleGroup.Threshold;
+            var negativeThresholdValue = sampleGroup.BaselineValue - (sampleGroup.BaselineValue + sampleGroup.StandardDeviation) * sampleGroup.Threshold;
 
             if (sampleGroup.IncreaseIsBetter)
             {
diff --git a/UnityPerformanceBenchmarkReporter/TestResultJsonParser.cs b/UnityPerformanceBenchmarkReporter/TestResultJsonParser.cs
@@ -163,7 +163,8 @@ private static PerformanceTestRun ParseJsonV2(string json)
                             {
                                 Name = sg.Name,
                                 SampleUnit = (Entities.SampleUnit)sg.Unit,
-                                IncreaseIsBetter = sg.IncreaseIsBetter
+                                IncreaseIsBetter = sg.IncreaseIsBetter,
+                                Threshold = sg.Threshold
                             }
                         }).ToList()
                     };
diff --git a/UnityPerformanceBenchmarkReporter/TestResultXmlParser.cs b/UnityPerformanceBenchmarkReporter/TestResultXmlParser.cs
@@ -90,11 +90,13 @@ private static void DeserializeTestResultsV2(IEnumerable<XElement> output, Perfo
                                 Sum = sg.Sum,
                                 StandardDeviation = sg.StandardDeviation,
                                 SampleCount = sg.Samples.Count,
+                                
                                 Definition = new SampleGroupDefinition()
                                 {
                                     Name = sg.Name,
                                     SampleUnit = (Entities.SampleUnit)sg.Unit,
-                                    IncreaseIsBetter = sg.IncreaseIsBetter
+                                    IncreaseIsBetter = sg.IncreaseIsBetter,
+                                    Threshold = sg.Threshold
                                 }
                             }).ToList()
                         };

Original file line number	Diff line number	Diff line change
`@@ -163,10 +163,8 @@ private double GetAggregatedSampleValue(SampleGroup sampleGroup)`
`163`	`163`	`private MeasurementResult DeterminePerformanceResult(SampleGroupResult sampleGroup, uint sigFig)`
`164`	`164`	`{`
`165`	`165`	`var measurementResult = MeasurementResult.Neutral;`
`166`		`- var positiveThresholdValue = sampleGroup.BaselineValue + sampleGroup.BaselineValue * sampleGroup.Threshold;`
`167`		`- var negativeThresholdValue = sampleGroup.BaselineValue - sampleGroup.BaselineValue * sampleGroup.Threshold;`
`168`		`- positiveThresholdValue += sampleGroup.StandardDeviation;`
`169`		`- negativeThresholdValue -= sampleGroup.StandardDeviation;`
	`166`	`+ var positiveThresholdValue = sampleGroup.BaselineValue + (sampleGroup.BaselineValue + sampleGroup.StandardDeviation) * sampleGroup.Threshold;`
	`167`	`+ var negativeThresholdValue = sampleGroup.BaselineValue - (sampleGroup.BaselineValue + sampleGroup.StandardDeviation) * sampleGroup.Threshold;`
`170`	`168`
`171`	`169`	`if (sampleGroup.IncreaseIsBetter)`
`172`	`170`	`{`
Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,8 @@ private static PerformanceTestRun ParseJsonV2(string json)`
`163`	`163`	`{`
`164`	`164`	`Name = sg.Name,`
`165`	`165`	`SampleUnit = (Entities.SampleUnit)sg.Unit,`
`166`		`- IncreaseIsBetter = sg.IncreaseIsBetter`
	`166`	`+ IncreaseIsBetter = sg.IncreaseIsBetter,`
	`167`	`+ Threshold = sg.Threshold`
`167`	`168`	`}`
`168`	`169`	`}).ToList()`
`169`	`170`	`};`