Fixed Compilation Errors, Properly pass down knwon issues

amaestas13 · amaestas13 · commit 2a48d154e7cf · 2022-07-06T11:34:20.000-07:00
diff --git a/UnityPerformanceBenchmarkReporter/Entities/SampleGroupResult.cs b/UnityPerformanceBenchmarkReporter/Entities/SampleGroupResult.cs
@@ -14,6 +14,8 @@ public class SampleGroupResult
         public bool Regressed;
         public bool Progressed;
         public bool RegressedKnown;
+        public bool ContainsKnownIssue;
+        public string KnownIssueDetails;
         public double Min;
         public double Max;
         public double Median;
diff --git a/UnityPerformanceBenchmarkReporter/PerformanceTestRunProcessor.cs b/UnityPerformanceBenchmarkReporter/PerformanceTestRunProcessor.cs
@@ -46,6 +46,8 @@ public List<TestResult> GetTestResults(
                         Average = sampleGroup.Average,
                         StandardDeviation = sampleGroup.StandardDeviation,
                         PercentileValue = sampleGroup.PercentileValue,
+                        ContainsKnownIssue = sampleGroup.Definition.ContainsKnownIssue,
+                        KnownIssueDetails = sampleGroup.Definition.KnownIssueDetails,
                         Sum = sampleGroup.Sum,
                         Zeroes = sampleGroup.Zeroes,
                         SampleCount = sampleGroup.SampleCount,
@@ -97,7 +99,7 @@ public void UpdateTestResultsBasedOnBaselineResults(List<TestResult> baselineTes
                             sampleGroupResult.Regressed = false;
                             sampleGroupResult.Progressed = true;
                             sampleGroupResult.RegressedKnown = false;
-                        }else if(res = MeasurementResult.RegressionKnown){
+                        }else if(res == MeasurementResult.RegressionKnown){
                             sampleGroupResult.Regressed = true;
                             sampleGroupResult.Progressed = false;
                             sampleGroupResult.RegressedKnown = true;
diff --git a/UnityPerformanceBenchmarkReporter/Program.cs b/UnityPerformanceBenchmarkReporter/Program.cs
@@ -202,6 +202,7 @@ private static void WriteRegressedKnownTestsAndMetricsToConsole(PerformanceTestR
                                     WriteLine("Baseline Value: {0,8:F2}", sampleGroupResult.BaselineValue);
                                     WriteLine("Threshold %   : {0,8:F2}", sampleGroupResult.Threshold);
                                     WriteLine("Actual Diff % : {0,8:F2}", Math.Abs(sampleGroupResult.BaselineValue - sampleGroupResult.AggregatedValue) / sampleGroupResult.BaselineValue);
+                                    WriteLine($"Known Issue: {sampleGroupResult.KnownIssueDetails}");
                                 }
                                 --indentLevel;
                                 WriteLine("\r\n");
diff --git a/UnityPerformanceBenchmarkReporter/TestResultXmlParser.cs b/UnityPerformanceBenchmarkReporter/TestResultXmlParser.cs
@@ -96,7 +96,7 @@ private static void DeserializeTestResultsV2(IEnumerable<XElement> output, Perfo
                                     Name = sg.Name,
                                     SampleUnit = (Entities.SampleUnit)sg.Unit,
                                     IncreaseIsBetter = sg.IncreaseIsBetter,
-                                    Threshold = sg.Threshold
+                                    Threshold = sg.Threshold,
                                     ContainsKnownIssue = sg.ContainsKnownIssue,
                                     KnownIssueDetails = sg.KnownIssueDetails
                                 }

Original file line number	Diff line number	Diff line change
`@@ -202,6 +202,7 @@ private static void WriteRegressedKnownTestsAndMetricsToConsole(PerformanceTestR`
`202`	`202`	`WriteLine("Baseline Value: {0,8:F2}", sampleGroupResult.BaselineValue);`
`203`	`203`	`WriteLine("Threshold % : {0,8:F2}", sampleGroupResult.Threshold);`
`204`	`204`	`WriteLine("Actual Diff % : {0,8:F2}", Math.Abs(sampleGroupResult.BaselineValue - sampleGroupResult.AggregatedValue) / sampleGroupResult.BaselineValue);`
	`205`	`+ WriteLine($"Known Issue: {sampleGroupResult.KnownIssueDetails}");`
`205`	`206`	`}`
`206`	`207`	`--indentLevel;`
`207`	`208`	`WriteLine("\r\n");`
Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ private static void DeserializeTestResultsV2(IEnumerable<XElement> output, Perfo`
`96`	`96`	`Name = sg.Name,`
`97`	`97`	`SampleUnit = (Entities.SampleUnit)sg.Unit,`
`98`	`98`	`IncreaseIsBetter = sg.IncreaseIsBetter,`
`99`		`- Threshold = sg.Threshold`
	`99`	`+ Threshold = sg.Threshold,`
`100`	`100`	`ContainsKnownIssue = sg.ContainsKnownIssue,`
`101`	`101`	`KnownIssueDetails = sg.KnownIssueDetails`
`102`	`102`	`}`