1177 absorb javascript client#1638
Conversation
| #!/usr/bin/env bash | ||
|
|
||
| # Set date variable for use in version | ||
| printf -v date '%(%Y.%m.%d)T' |
There was a problem hiding this comment.
We use tags for versioning, Look at the various release.yamls. So the version should come through an environment variable or argument.
There was a problem hiding this comment.
then again I now see the note in the readme so maybe that's already taken care of.
There was a problem hiding this comment.
Will remove these scripts for this repo, helped with local setup in windows
MikeNeilson
left a comment
MikeNeilson
left a comment
There was a problem hiding this comment.
Change this all to use java/gradle to generate the API itself, there's an existing subproject, adjust options as required to match existing output.
Additionally, for now, remove the publish steps we'll deal with that in a follow up after we verify everything works.
The existing tests should be valid, you might have to experiment with exactly where they go and how they get referenced.
You might be able to reference https://github.com/opendcs/opendcs/tree/main/java/api-clients for some additional examples.
Also make sure that there is some form of build task, should be in the gradle, that does the equivalent of what npm run build would do (the OpenDCS Typescript client does this). The generators can sometimes output incorrect code and that catches that before it's used anywhere.
|
Note to self from Mike Make sure i'm using gradle commands to do things like build the docs/examples/run the generator Check how OpenDCS does this - build.gradle file that knows how to integrate into the gradle build. Gradle plugin should do generation Move tests to the javascript dir with the other tests Make sure to target current gradle version for CDA Node plugin for gradle Make a |
| "description": "PRIMARY production server" | ||
| }, | ||
| { | ||
| "url": "https://water.usace.army.mil/cwms-data", |
There was a problem hiding this comment.
This no longer works and needs to be removed
…s builds from depending on the shared user npm cache and improves CI/reproducibility
krowvin
force-pushed
the
1177-absorb-javascript-client
branch
from
18b4071 to
99907de
Compare
2 participants
This is a rough copy from
https://github.com/hydrologicengineeringcenter/cwms-data-api-client-javascript
Will need
Placing here to work on it for others to see. Will mark reviewers/ready for review later.