URock output not matching inputs

[sstrumwasser]

Describe the bug
When I run URock, the output is for an area from a previous run, not based on the extent of the inputs. I think it may have to do with temporary files.

To Reproduce
Steps to reproduce the behavior:
Run URock with one study area then another. I updated the software to the dev version recently.

Desktop (please complete the following information):

• OS: Windows 11
• QGIS Version: 3.34
• UMEP Version 2.1.24
• SuPy Version 2024.4.54.dev

Screenshots
Input is larger raster, bottom. Output is smaller raster, top.

Additional context
Recently installed dev version, have been running URock repeatedly for a few weeks.

[j3r3m1]

Should be working correctly in the new UMEP version (2.1.26)

[sstrumwasser]

I reinstalled UMEP-dev this morning after your changes and it's showing version 2.1.25. I have a couple more errors - they are different when I use different input data. I can send along the data if that's helpful.

1st error:

QgsProcessingException: Could not create layer [C:\Users\SSTRUM](file:///C:/Users/SSTRUM)~1\AppData\Local\Temp\URock_2025-06-02T13_51_43_391440\order_changed.gpkg: Creation of data source failed (OGR error: A file system object called '[C:\Users\SSTRUM](file:///C:/Users/SSTRUM)~1\AppData\Local\Temp\URock_2025-06-02T13_51_43_391440\order_changed.gpkg' already exists.)

2nd error:

QgsProcessingException: Traceback (most recent call last):
  File "[C:\Users\sstrumwasser\AppData\Roaming\QGIS\QGIS3\profiles\default\python\plugins\UMEP_processing_main\processor\urock_processing_algorithm.py", line 454](file:///C:/Users/sstrumwasser/AppData/Roaming/QGIS/QGIS3/profiles/default/python/plugins/UMEP_processing_main/processor/urock_processing_algorithm.py#line=453), in processAlgorithm
    MainCalculation.main(javaEnvironmentPath = javaEnvVar,
  File "[C:\Users\sstrumwasser\AppData\Roaming\QGIS\QGIS3\profiles\default\python\plugins\UMEP_processing_main\functions\URock\MainCalculation.py", line 823](file:///C:/Users/sstrumwasser/AppData/Roaming/QGIS/QGIS3/profiles/default/python/plugins/UMEP_processing_main/functions/URock/MainCalculation.py#line=822), in main
    saveData.saveBasicOutputs(cursor = cursor                , z_out = z_out,
  File "[C:\Users\sstrumwasser\AppData\Roaming\QGIS\QGIS3\profiles\default\python\plugins\UMEP_processing_main\functions\URock\saveData.py", line 163](file:///C:/Users/sstrumwasser/AppData/Roaming/QGIS/QGIS3/profiles/default/python/plugins/UMEP_processing_main/functions/URock/saveData.py#line=162), in saveBasicOutputs
    saveRasterFile(cursor = cursor,
  File "[C:\Users\sstrumwasser\AppData\Roaming\QGIS\QGIS3\profiles\default\python\plugins\UMEP_processing_main\functions\URock\saveData.py", line 445](file:///C:/Users/sstrumwasser/AppData/Roaming/QGIS/QGIS3/profiles/default/python/plugins/UMEP_processing_main/functions/URock/saveData.py#line=444), in saveRasterFile
    output_ds = driver.CreateCopy(outputFilePathAndNameBaseRaster + OUTPUT_RASTER_EXTENSION,
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "[C:\OSGeo4W\apps\Python312\Lib\site-packages\osgeo\gdal.py", line 3817](file:///C:/OSGeo4W/apps/Python312/Lib/site-packages/osgeo/gdal.py#line=3816), in CreateCopy
    return _gdal.Driver_CreateCopy(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: Received a NULL pointer.

Looking into the code on the second one it looks like there is a reference to tmp_file at line 441 that is never produced, so GDAL can't open it.

[j3r3m1]

Strange that you have a version 2.1.25 while the code you are showing is 2.1.26. Anyway, I have updated the 2.1.26 (bad boy) instead of creating a 2.1.27, which should now be OK.

Are you batch-running URock ? Files already existing means you have started two simulations at two exact same times. I cannot really replicate your error but I have tried to make a more unique folder for each simulation in order to see if it solves your errors (should solve both of them in my opinion).

[sstrumwasser]

I encountered the same error with your update but I think I've found the problem. The order_changed file is being created in the same temp directory 3 times, once for each of the wind directions (HWS, VWS, WS). I added + "_" + colname to the output of orderbyexpression (~line 560 in saveData.py) and that fixed it. Now the outputs are produced but the algorithm runs into and error trying to remove the order_changed temp files. Not sure how to fix that but hopefully it's trivial!

QgsProcessingException: Traceback (most recent call last):
  File "[C:\Users\sstrumwasser\AppData\Roaming\QGIS\QGIS3\profiles\default\python\plugins\UMEP_processing_main\processor\urock_processing_algorithm.py", line 454](file:///C:/Users/sstrumwasser/AppData/Roaming/QGIS/QGIS3/profiles/default/python/plugins/UMEP_processing_main/processor/urock_processing_algorithm.py#line=453), in processAlgorithm
    MainCalculation.main(javaEnvironmentPath = javaEnvVar,
  File "[C:\Users\sstrumwasser\AppData\Roaming\QGIS\QGIS3\profiles\default\python\plugins\UMEP_processing_main\functions\URock\MainCalculation.py", line 873](file:///C:/Users/sstrumwasser/AppData/Roaming/QGIS/QGIS3/profiles/default/python/plugins/UMEP_processing_main/functions/URock/MainCalculation.py#line=872), in main
    rmtree(tmp_dir_unique)
  File "[C:\OSGeo4W\apps\Python312\Lib\shutil.py", line 781](file:///C:/OSGeo4W/apps/Python312/Lib/shutil.py#line=780), in rmtree
    return _rmtree_unsafe(path, onexc)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "[C:\OSGeo4W\apps\Python312\Lib\shutil.py", line 635](file:///C:/OSGeo4W/apps/Python312/Lib/shutil.py#line=634), in _rmtree_unsafe
    onexc(os.unlink, fullname, err)
  File "[C:\OSGeo4W\apps\Python312\Lib\shutil.py", line 633](file:///C:/OSGeo4W/apps/Python312/Lib/shutil.py#line=632), in _rmtree_unsafe
    os.unlink(fullname)
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: '[C:\\Users\\SSTRUM](file:///C://Users//SSTRUM)~1\\AppData\\Local\\Temp\\URock_2025-06-03T142115ab99f9f5-f85a-4578-a7d6-b91be14877f8\\order_changed_HWS.gpkg'

[j3r3m1]

OK, updated with your remark concerning the wind directions (good catch) and do not remove tmp files at the end. Should be removed automatically at computer restart... Now try version 2.1.27

[j3r3m1]

@sstrumwasser did it work at the end with version 2.1.27 and higher ?

[sstrumwasser]

I didn't get a chance to test 2.1.27 (tight deadline) but will try to soon and let you know.