Handle Docker volume cleanup during install/uninstall

Author: merfanian

scripts/install-oneliner.sh

@@ -152,7 +152,25 @@ INSTALL_DIR="$HOME/.needle"
 # Remove old installation if exists
 if [ -d "$INSTALL_DIR" ]; then
     print_warning "Directory $INSTALL_DIR already exists. Removing old installation..."
-    rm -rf "$INSTALL_DIR"
+    
+    # Stop any running services first
+    if [ -f "$INSTALL_DIR/docker/docker-compose.infrastructure.yaml" ]; then
+        print_status "Stopping existing Docker services..."
+        docker compose -f "$INSTALL_DIR/docker/docker-compose.infrastructure.yaml" down -v 2>/dev/null || true
+    fi
+    
+    # Remove Docker volumes (may require elevated permissions)
+    if [ -d "$INSTALL_DIR/volumes" ]; then
+        print_status "Cleaning up Docker volumes..."
+        # Use Docker to remove volume files (runs as root)
+        docker run --rm -v "$INSTALL_DIR/volumes:/volumes" alpine sh -c "rm -rf /volumes/*" 2>/dev/null || true
+    fi
+    
+    # Now remove the directory
+    rm -rf "$INSTALL_DIR" 2>/dev/null || {
+        print_error "Failed to remove $INSTALL_DIR. You may need to run: sudo rm -rf $INSTALL_DIR"
+        exit 1
+    }
 fi
 
 # Clone repository directly to ~/.needle

scripts/uninstall.sh

@@ -131,8 +131,23 @@ fi
 
 ### Step 4: Remove entire Needle directory
 print_status "Removing Needle installation directory..."
-rm -rf "$NEEDLE_DIR"
-print_success "Needle directory removed"
+
+# Clean up Docker volume files (may have root ownership)
+if [ -d "$NEEDLE_DIR/volumes" ]; then
+    print_status "Cleaning up Docker volume files..."
+    docker run --rm -v "$NEEDLE_DIR/volumes:/volumes" alpine sh -c "rm -rf /volumes/*" 2>/dev/null || true
+fi
+
+rm -rf "$NEEDLE_DIR" 2>/dev/null || {
+    print_error "Failed to remove some files in $NEEDLE_DIR"
+    print_status "You may need to run: sudo rm -rf $NEEDLE_DIR"
+}
+
+if [ ! -d "$NEEDLE_DIR" ]; then
+    print_success "Needle directory removed"
+else
+    print_warning "Some files could not be removed. Run: sudo rm -rf $NEEDLE_DIR"
+fi
 
 ### Step 5: Final message
 print_success "🎉 Uninstallation complete!"