fix: Improper accessing of editor DOM element #2234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the editor DOM element being read from
editor.prosemirrorView.domElementtoeditor.domElementin some places. Especially in theCreateLinkButtoncomponent, this is an important distinction as the DOM element doesn't exist when the component is cleaning up, leading to errors.closes #2189
Rationale
The
CreateLinkButtoncomponent will throw an error if it's being unmounted with the editor view.Changes
See above.
Impact
N/A
Testing
N/A
Screenshots/Video
N/A
Checklist
Additional Notes