chore: Memoize Floating UI options in TableHandlesController
#2222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
YousefED
approved these changes
Dec 6, 2025
Collaborator
YousefED
left a comment
YousefED
left a comment
There was a problem hiding this comment.
looks good! Could you notice the memo missing? (i.e.: did it cause any errors or jankiness)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds memoization to Floating UI options in
TableHandlesController.Additionally, a bug has been fixed with the extend rows/columns buttons. If the mouse cursor would move from the table element to the button and started dragging it, the position would update ok. If the mouse cursor would move from outside the table element (i.e. from elsewhere in the table block) and started dragging it, the position would no longer update. This was because in the latter case, the extension state's
rowIndexandcolIndexwould be undefined, and that incorrectly prevented the table reference element from being updated, which in turn prevented the button positions from updating.Rationale
Minor code cleanup & useful bug fix.
Changes
N/A
Impact
N/A
Testing
Went through the UI testing doc to ensure no regressions & updated doc with new test case.
Screenshots/Video
N/A
Checklist
Additional Notes