Skip to content

Commit 5dfa4d1

Browse files
authored
Fix gulp-zip v6 ESM compatibility (#36)
* Fix gulp-zip v6 ESM compatibility gulp-zip v6 is pure ESM. Use dynamic import() instead of require() to load it in the CommonJS gulpfile. * Update gulp-zip to v6.1.0
1 parent 1789c13 commit 5dfa4d1

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

gulpfile.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const pump = require('pump');
44
// gulp plugins and utils
55
var livereload = require('gulp-livereload');
66
var postcss = require('gulp-postcss');
7-
var zip = require('gulp-zip');
7+
var zipModule;
88
var uglify = require('gulp-uglify');
99
var beeper = require('beeper');
1010

@@ -62,7 +62,10 @@ function js(done) {
6262
], handleError(done));
6363
}
6464

65-
function zipper(done) {
65+
async function zipper(done) {
66+
if (!zipModule) {
67+
zipModule = (await import('gulp-zip')).default;
68+
}
6669
var targetDir = 'dist/';
6770
var themeName = require('./package.json').name;
6871
var filename = themeName + '.zip';
@@ -73,7 +76,7 @@ function zipper(done) {
7376
'!node_modules', '!node_modules/**',
7477
'!dist', '!dist/**'
7578
]),
76-
zip(filename),
79+
zipModule(filename),
7780
dest(targetDir)
7881
], handleError(done));
7982
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
"gulp-uglify": "3.0.2",
5656
"gulp-util": "3.0.8",
5757
"gulp-watch": "5.0.1",
58-
"gulp-zip": "5.1.0",
58+
"gulp-zip": "6.1.0",
5959
"postcss": "8.5.6",
6060
"postcss-color-function": "4.1.0",
6161
"postcss-custom-properties": "15.0.0",

0 commit comments

Comments
 (0)