Fix TypeScript migration issues based on PR feedback

- replace-permalink: Return 'undefined' for missing author (match original behavior)
- replace-permalink: Remove unnecessary String() conversion for id
- absolute-to-transform-ready: Extend AbsoluteToRelativeOptions to remove type casts
- build-early-exit-match: Fix type guards to properly check string type and length
- markdown-absolute-to-relative: Remove unnecessary earlyExitMatchStr check
- relative-to-absolute: Remove incorrect comment and unsafe ! operator, use type assertion

Author: vershwal

packages/url-utils/src/utils/absolute-to-transform-ready.ts

@@ -1,12 +1,9 @@
 import type {TransformReadyReplacementOptions} from './types';
-import absoluteToRelative, {type AbsoluteToRelativeOptionsInput} from './absolute-to-relative';
+import absoluteToRelative, {type AbsoluteToRelativeOptions} from './absolute-to-relative';
 import {URL} from 'url';
 
-export interface AbsoluteToTransformReadyOptions extends TransformReadyReplacementOptions {
+export interface AbsoluteToTransformReadyOptions extends TransformReadyReplacementOptions, AbsoluteToRelativeOptions {
     withoutSubdirectory: boolean;
-    ignoreProtocol: boolean;
-    assetsOnly: boolean;
-    staticImageUrlPrefix: string;
     staticFilesUrlPrefix?: string;
     staticMediaUrlPrefix?: string;
     imageBaseUrl?: string | null;
@@ -53,30 +50,30 @@ const absoluteToTransformReady = function (
 
     // convert to relative with stripped subdir
     // always returns root-relative starting with forward slash
-    const rootRelativeUrl = absoluteToRelative(url, root, options as AbsoluteToRelativeOptionsInput);
+    const rootRelativeUrl = absoluteToRelative(url, root, options);
 
     if (isRelative(rootRelativeUrl)) {
         return `${options.replacementStr}${rootRelativeUrl}`;
     }
 
     if (options.mediaBaseUrl) {
-        const mediaRelativeUrl = absoluteToRelative(url, options.mediaBaseUrl, options as AbsoluteToRelativeOptionsInput);
+        const mediaRelativeUrl = absoluteToRelative(url, options.mediaBaseUrl, options);
 
         if (isRelative(mediaRelativeUrl)) {
             return `${options.replacementStr}${mediaRelativeUrl}`;
         }
     }
 
     if (options.filesBaseUrl) {
-        const filesRelativeUrl = absoluteToRelative(url, options.filesBaseUrl, options as AbsoluteToRelativeOptionsInput);
+        const filesRelativeUrl = absoluteToRelative(url, options.filesBaseUrl, options);
 
         if (isRelative(filesRelativeUrl)) {
             return `${options.replacementStr}${filesRelativeUrl}`;
         }
     }
 
     if (options.imageBaseUrl) {
-        const imageRelativeUrl = absoluteToRelative(url, options.imageBaseUrl, options as AbsoluteToRelativeOptionsInput);
+        const imageRelativeUrl = absoluteToRelative(url, options.imageBaseUrl, options);
 
         if (isRelative(imageRelativeUrl)) {
             return `${options.replacementStr}${imageRelativeUrl}`;

packages/url-utils/src/utils/build-early-exit-match.ts

@@ -23,12 +23,12 @@ type BuildEarlyExitMatchOptions = BaseUrlOptionsInput & {
  */
 function buildEarlyExitMatch(siteUrl: string, options: BuildEarlyExitMatchOptions = {}): string | null {
     const candidates = [siteUrl, options.imageBaseUrl, options.filesBaseUrl, options.mediaBaseUrl]
-        .filter((value): value is string => Boolean(value))
+        .filter((value: string | null | undefined): value is string => typeof value === 'string' && value.length > 0)
         .map((value: string) => {
             let normalized = options.ignoreProtocol ? value.replace(/http:|https:/, '') : value;
             return normalized.replace(/\/$/, '');
         })
-        .filter((value): value is string => Boolean(value))
+        .filter((value: string): boolean => Boolean(value))
         .map(escapeRegExp);
 
     if (!candidates.length) {

packages/url-utils/src/utils/markdown-absolute-to-relative.ts

@@ -13,9 +13,7 @@ function markdownAbsoluteToRelative(
     const options: MarkdownTransformOptionsInput = Object.assign({}, defaultOptions, _options);
 
     options.earlyExitMatchStr = options.ignoreProtocol ? siteUrl.replace(/http:|https:/, '') : siteUrl;
-    if (options.earlyExitMatchStr) {
-        options.earlyExitMatchStr = options.earlyExitMatchStr.replace(/\/$/, '');
-    }
+    options.earlyExitMatchStr = options.earlyExitMatchStr.replace(/\/$/, '');
 
     // need to ignore itemPath because absoluteToRelative functions doen't take that option
     const transformFunctions = {

packages/url-utils/src/utils/relative-to-absolute.ts

@@ -55,8 +55,7 @@ const relativeToAbsolute = function relativeToAbsolute(
 
     // return the path as-is if it's not an asset path and we're only modifying assets
     if (options.assetsOnly) {
-        // staticImageUrlPrefix is always set from defaultOptions via Object.assign
-        const staticImageUrlPrefixRegex = new RegExp(options.staticImageUrlPrefix!);
+        const staticImageUrlPrefixRegex = new RegExp(options.staticImageUrlPrefix as string);
         if (!path.match(staticImageUrlPrefixRegex)) {
             return path;
         }

packages/url-utils/src/utils/replace-permalink.ts

@@ -29,7 +29,7 @@ function replacePermalink(permalink: string, resource: PermalinkResource, timezo
             return publishedAtMoment.format('DD');
         },
         author: function () {
-            return resource.primary_author?.slug ?? primaryTagFallback;
+            return resource.primary_author?.slug ?? 'undefined';
         },
         primary_author: function () {
             return resource.primary_author ? resource.primary_author.slug : primaryTagFallback;
@@ -41,7 +41,7 @@ function replacePermalink(permalink: string, resource: PermalinkResource, timezo
             return resource.slug;
         },
         id: function () {
-            return String(resource.id);
+            return resource.id;
         }
     };