Backfill Missing FTL Translations for Markings, Materials, IPC/Silion, Et All#121
Backfill Missing FTL Translations for Markings, Materials, IPC/Silion, Et All#121rebaserHEAD wants to merge 3 commits into
Conversation
…n emotes Sweep across the repo for prototypes whose name/chatMessage fields pointed at locale keys that did not exist (or used literal English instead of keys). All gaps closed: 27 marking primary keys, 102 marking sublayer keys, 11 material names, and 20 emote name/chatMessage keys across upstream + every fork dir. Adds Tools/ftl-audit.ps1 so this regression can be re-checked after future prototype changes.
|
Can we re-kick this CI check? looks like it died mid way for some reason according to the logs. |
The backfill commit added chat-emote-name-growl and chat-emote-name-purr to the nyanotrasen locale, but _Starlight already defined them; Linguini reported duplicate Message entries and the bundle load logged _logSawmill.Error, failing Content.IntegrationTests. Drop the nyanotrasen redefinitions (leaving a pointer comment), and while the locale files were open, prune three other orphans no prototype ever references: name-hiss in _Starlight (real Hiss uses name-reptilian-hiss), name-mars + msg-mars in _Goobstation, and the typo'd msg-lurr / msg-liss also in _Starlight. Audit verified post-fix: 0 duplicate defs, 0 dangling refs across chat-emote-* and delta-chat-emote-* namespaces.
mnva0
left a comment
There was a problem hiding this comment.
Thank you for this PR! Not a test or full review—just some things I noticed
There was a problem hiding this comment.
Since this is for Triad, it may be a good idea to move this somewhere else? I would wait for input from other maintainers before making changes though
There was a problem hiding this comment.
yeah we can pull it out if we want but I don't disagree that this should probably be moved to a namespaced folder under tools but at the same time it seems like a fork dumping ground lol
|
One more time! |
|
Can you run just the failing test? Something fucky is going on. |
|
If it keep failing and unrelated then just ignore it atp |
|
Yeah I've checked it on my side machine a few more times and I can't see why it would be causing an issue other than maybe it's just a lot of changes? but even then... ftl file changes aren't that huge so... yeah lol |
About the PR
Sweep across the repo for prototypes whose
name:/chatMessages:fields pointed at locale keys that did not exist, or used literal English instead of keys. All gaps closed: 27 marking primary keys, 102 marking sublayer keys, 11 material names, and 20 emote name/chatMessage keys across the upstream tree and every fork directory (_DV,_EinsteinEngines,_Goobstation,_Impstation,_Moffstation,_Mono,_NF,_Obelisk,_Starlight,_white,Nyanotrasen).Highlights:
Bluespace,BrassGlass,UraniumGlass,ReinforcedUraniumGlass,Cotton,Brass,Pyrogel, threeFuelGrade*variants, andPrizeTickethadname:fields that were either raw English ("fuel-grade plasma","prize ticket") or pointed at undefined keys. YAMLs now referencematerials-*keys, and the keys are defined in the matching locale dir.WhirrandBoophadchatMessages: [ whirrs ]/[ boops. ](literal). Now point atchat-emote-msg-whirr/-boop, both defined.chatMessagesand in some cases literalname:fields. All converted to proper locale keys with FTL entries added.LefttvsLeft), Feroxi animated tail variants, Hydrakin painted ear/tail sublayers, Resomi earring case mismatch, Snake large tail RSI-state mismatch, Lizard/Vox animated wagging variants, Rodentia default ear/tail, CatEars sublayers, and others.Audit tool lives at
Tools/ftl-audit.ps1for future re-checks.Why / Balance
Players who pick a marking that has no FTL key see the raw prototype ID (e.g.
marking-AvaliBicoloredTipsLeftHand-l_hand_front) in the customization picker. Materials with literal-string names work in chat but bypass localization entirely, so any future translation work would skip them. IPC emotes were the most visible offender (rawwhirrsshowing up in chat instead of resolving through the locale system).This is a strict bug-fix sweep with no balance impact.
Media
N/A, locale strings only.
Requirements
How to test
marking-Xxx-yyyID.*whirrand*boopemotes and confirm they render asFoo whirrs./Foo boops.in chat instead of raw text.*ring,*pew,*bark,*howl,*gnash, etc.) and confirm chat output is well-formed.Tools/ftl-audit.ps1and confirm the report shows0missing entries across all four categories.Breaking changes
None. All changes are additive locale entries plus prototype
name:/chatMessages:field redirects from literal strings to locale keys. Save data is unaffected because marking/material/emote IDs themselves are unchanged.Changelog
🆑