Fix Hydrakin Plasma & Tritium Metabolism#119
Open
rebaserHEAD wants to merge 1 commit into
Open
Conversation
Plasma and Tritium both fired the Toxins alert (TOX icon) at >=1.5u in the lung even though their poison HealthChange already excludes Hydrakin, so the icon was a UI lie. Add the same OrganType: Hydrakin, shouldHave: false guard to both AdjustAlert effects. Tritium additionally dealt 1 Radiation/tick from inhalation with no species exclusion, contradicting the Hydrakin guidebook claim that unique gases are "mostly positive". Exclude Hydrakin from the inhaled-tritium radiation HealthChange. The bloodstream Poison-group radiation is left intact - injecting isotopes should still hurt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Cleans up two longstanding inconsistencies in the Hydrakin gas-metabolism block in
Resources/Prototypes/Reagents/gases.yml:Toxinsalert was raised at >=1.5u in the lung even though the poisonHealthChangealready excludes Hydrakin. Added the sameOrganType: Hydrakin, shouldHave: falseguard to bothAdjustAlerteffects so the UI matches the actual damage state.HealthChange. The bloodstream Poison-group radiation (3/tick, fires when Tritium is injected/drunk/touched) is intentionally left intact — shooting up radioactive isotopes should still hurt.Why / Balance
Hydrakin already get an
Oxygenatecarve-out for all of Plasma/Tritium/Frezon/N2O/BZ/Healium/Nitrium/Pluoxium and are excluded from the poison damage on Plasma & Tritium. The lore (iceworld with frezon-heavy atmosphere, "capable of breathing all gases") and the in-game guidebook page both already promise this — the missing carve-outs onAdjustAlertand the inhaled-radiationHealthChangewere holes in that contract, not intended balance. No new Hydrakin capabilities are being added; existing ones are just being made internally consistent.Media
N/A — fix for an alert icon and an unintended damage tick. No visual content.
Requirements
How to test
Breaking changes
None. Pure YAML condition additions on existing effects; no prototype renames, no public API changes.
Changelog
🆑