Skip to content

Commit a76c871

Browse files
Toreburnclaude
andcommitted
Fix workflow failures: concurrency group + non-fatal commits
Two issues causing "run failed" emails: 1. update-patches had no concurrency group, so it raced with fetch-all-patches at hours 0/6/12/18 and on pushes. Both tried to commit patches.json simultaneously. Now both share the "patch-updates" concurrency group so they queue. 2. When git pull --rebase hit a conflict on patches.json, the step failed and blocked the Pages deploy entirely. Now the commit step has continue-on-error and rebase --abort fallback, so the deploy always runs with the freshly aggregated data. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 83d756b commit a76c871

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

.github/workflows/fetch-all-patches.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,14 +153,15 @@ jobs:
153153
continue-on-error: true # Don't block deploy, but annotations will surface
154154

155155
- name: Commit and push changes
156+
continue-on-error: true # Don't block deploy if push conflicts
156157
run: |
157158
git config --local user.email "action@github.com"
158159
git config --local user.name "GitHub Action"
159160
git add data/
160161
if ! git diff --staged --quiet; then
161162
git commit -m "Update patch data $(date -u +%Y-%m-%d)"
162-
git pull --rebase origin master
163-
git push
163+
git pull --rebase origin master || git rebase --abort
164+
git push || echo "Push failed, will still deploy from working directory"
164165
fi
165166
166167
- name: Prepare site directory

.github/workflows/update-patches.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ on:
88
paths:
99
- '.github/workflows/update-patches.yml'
1010

11+
concurrency:
12+
group: patch-updates
13+
cancel-in-progress: false
14+
1115
jobs:
1216
update-patches:
1317
runs-on: ubuntu-latest
@@ -37,14 +41,15 @@ jobs:
3741
run: node scripts/fetch-patches.js
3842

3943
- name: Commit and push if changes
44+
continue-on-error: true # Don't block deploy if push conflicts
4045
run: |
4146
git config --local user.email "action@github.com"
4247
git config --local user.name "GitHub Action"
4348
git add data/patches.json data/vendors/*.json
4449
if ! git diff --staged --quiet; then
4550
git commit -m "Update patch data [skip ci]"
46-
git pull --rebase origin master
47-
git push
51+
git pull --rebase origin master || git rebase --abort
52+
git push || echo "Push failed, will still deploy from working directory"
4853
fi
4954
5055
- name: Prepare site directory

0 commit comments

Comments
 (0)