Skip to content

Commit f165dfb

Browse files
author
DavidQ
committed
Finalize Tool Template V2 visual consistency and architecture contract - PR_26126_079-template-v2-final-visual-and-contract-lock
1 parent 3cd9d55 commit f165dfb

2 files changed

Lines changed: 46 additions & 2 deletions

File tree

docs/dev/reports/playwright_v8_coverage_report.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,5 +160,4 @@ Uncovered or low-coverage changed JS files:
160160
(100%) none changed - no changed runtime JS files
161161

162162
Changed JS files considered:
163-
(0%) tests/helpers/playwrightV8CoverageReporter.mjs - changed JS file not collected as browser runtime coverage
164-
(0%) tests/playwright/PreviewGeneratorV2Baseline.spec.mjs - changed JS file not collected as browser runtime coverage
163+
(0%) tools/templates-v2/tests/playwright/FirstClassToolStarter.spec.mjs - changed JS file not collected as browser runtime coverage
Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
PR_26126_079 Tool Template V2 Final Visual And Contract Lock
2+
3+
Scope:
4+
- Reviewed tools/templates-v2 against Palette Manager V2 and Preview Generator V2.
5+
- No template runtime behavior changes were required.
6+
- No live tools, samples, schemas, roadmap, or start_of_day folders were modified.
7+
8+
Visual consistency checks:
9+
- Header uses the shared V2 shell pattern with src/engine/theme assets, shared-theme-header host, and Tool Template V2 local header frame.
10+
- Body/background/control colors remain aligned to Preview Generator V2 and Palette Manager V2 purple tool surface styling.
11+
- Tool NAV and workspace NAV remain mutually exclusive and preserve existing launch-mode behavior.
12+
- Left panel remains user input/setup only.
13+
- Center panel remains the primary preview/work surface.
14+
- Right panel remains output summary above Status/logging.
15+
- Accordions use accordion-v2 structure and behavior.
16+
- Non-editable display field matches the Selected Swatch readonly field pattern.
17+
- Editable field matches the taller Tags `No tags.` field pattern.
18+
- Buttons and Status Clear placement/style remain aligned with the V2 tool pattern.
19+
20+
Contract checks:
21+
- No inline `<script>` blocks were found in tools/templates-v2/index.html.
22+
- No inline `<style>` blocks were found in tools/templates-v2/index.html.
23+
- No inline event handlers were found in tools/templates-v2/index.html.
24+
- No tools/shared import, script reference, CSS reference, or runtime dependency was found in template HTML/CSS/JS. Visible text and docs only mention tools/shared as a deprecated dependency.
25+
- src/engine/theme is used for main theme CSS, accordionV2 CSS, and shared header mounting.
26+
- One class per JavaScript file verified; bootstrap has no class and each app/control/service file exports one class.
27+
- One control/section per control class remains documented and represented in the template.
28+
- Playwright workspace-v2 coverage includes Tool Template V2 and reports 10 exercised template runtime JS files.
29+
30+
Validation:
31+
- node --check tools/templates-v2/js/bootstrap.js passed.
32+
- node --check tools/templates-v2/js/ToolStarterApp.js passed.
33+
- node --check for all tools/templates-v2/js/controls/*.js and js/services/*.js passed.
34+
- node --check tools/templates-v2/tests/playwright/FirstClassToolStarter.spec.mjs passed.
35+
- No inline script/style/event-handler matches were found in tools/templates-v2/index.html.
36+
- npx playwright test --config tools/templates-v2/playwright.config.mjs passed, 10 tests.
37+
- npm run test:workspace-v2 passed, 7 tests.
38+
- docs/dev/reports/playwright_v8_coverage_report.txt was produced and includes Tool Template V2 coverage.
39+
40+
Manual test notes:
41+
- Open tools/templates-v2/index.html and confirm default tool mode NAV, panel roles, accordions, editable/non-editable fields, and Status Clear remain visually correct.
42+
- Open tools/templates-v2/index.html?launch=workspace and confirm workspace NAV appears while tool NAV remains hidden.
43+
44+
Ready state:
45+
- Tool Template V2 is ready to use as the first-class tool starter.

0 commit comments

Comments
 (0)