Skip to content

Commit ef51abc

Browse files
author
DavidQ
committed
Replace Asset Manager V2 palette UAT with workspace UAT and separate Playwright suites - PR_26126_106-asset-manager-v2-workspace-uat-and-test-separation
1 parent 79df154 commit ef51abc

20 files changed

Lines changed: 8487 additions & 1836 deletions

docs/dev/reports/PR_26126_093_asset_manager_v2_manual_validation_notes.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
- `node --check tools/asset-manager-v2/js/AssetManagerV2App.js`
55
- `node --check tools/asset-manager-v2/js/controls/AssetFormControl.js`
66
- `node --check tools/asset-manager-v2/js/controls/AssetCatalogControl.js`
7-
- `node --check tools/asset-manager-v2/js/services/TemporaryUatSamplePalette.js`
7+
- `node --check tools/asset-manager-v2/js/services/TemporaryUatWorkspace.js`
88
- `node --check tools/asset-manager-v2/js/services/WorkspaceBridge.js`
99
- `node --check src/shared/assets/assetPreviewHelpers.js`
1010
- `node --check tests/playwright/PreviewGeneratorV2Baseline.spec.mjs`
@@ -19,7 +19,7 @@
1919
## Manual Checks Covered By Tests
2020
- Disabled and grayed ID textbox.
2121
- Color ID generation from normalized swatch names.
22-
- Temporary `?palette=sample` UAT palette loading.
22+
- Temporary `?workspace=UAT` UAT palette loading.
2323
- Color picker replacing the file picker and Status-only empty palette messages.
2424
- Audio, font, and image preview path resolution from Workspace V2 game assets.
2525
- Selected Asset Detail accordion and Stretch Override fieldset styling.

docs/dev/reports/PR_26126_093_asset_manager_v2_palette_sample_notes.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# PR_26126_093 Asset Manager V2 Palette Sample Notes
22

33
## Temporary UAT Loader
4-
- Added `tools/asset-manager-v2/js/services/TemporaryUatSamplePalette.js`.
4+
- Added `tools/asset-manager-v2/js/services/TemporaryUatWorkspace.js`.
55
- The loader is explicitly marked temporary UAT-only and isolated for later removal.
6-
- It is activated only by `?palette=sample`.
6+
- It is activated only by `?workspace=UAT`.
77
- Normal Workspace V2 palette loading remains separate.
88

99
## Palette Format
@@ -19,7 +19,7 @@
1919
- Swatches include only schema-valid `symbol`, `hex`, `name`, `source`, and `tags` fields.
2020

2121
## Behavior
22-
- `?palette=sample` loads the palette into memory and populates the Asset Manager V2 Color picker.
22+
- `?workspace=UAT` loads the palette into memory and populates the Asset Manager V2 Color picker.
2323
- The file picker stays hidden when Type is Color.
2424
- Color asset IDs are generated from swatch names, for example `Signal Violet!` becomes `assets.color.hud.signal-violet`.
2525

docs/dev/reports/PR_26126_096_asset_manager_v2_manual_validation_notes.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
## Commands
44
- `node --check tools/asset-manager-v2/js/assetPreviewHelpers.js`
55
- `node --check tools/asset-manager-v2/js/services/WorkspaceBridge.js`
6-
- `node --check tools/asset-manager-v2/js/services/TemporaryUatSamplePalette.js`
6+
- `node --check tools/asset-manager-v2/js/services/TemporaryUatWorkspace.js`
77
- `node --check tools/asset-manager-v2/js/AssetManagerV2App.js`
88
- `node --check tests/playwright/PreviewGeneratorV2Baseline.spec.mjs`
99
- `npx playwright test tests/playwright/PreviewGeneratorV2Baseline.spec.mjs --project=playwright --reporter=list -g "Asset Manager V2"`
@@ -20,6 +20,6 @@
2020
- Selected Asset Detail height is increased to at least 220px.
2121
- Asset preview remains inside Selected Asset Detail.
2222
- Workspace preview context is games-only.
23-
- `?palette=sample` temporary UAT root uses `games/Asteroids/` for preview/path testing only.
24-
- `?palette=sample` image previews resolve under `/games/Asteroids/assets/...`.
23+
- `?workspace=UAT` temporary UAT workspace root uses `games/Asteroids/` for preview/path testing only.
24+
- `?workspace=UAT` image previews resolve under `/games/Asteroids/assets/...`.
2525
- Sample JSON files were not modified.
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
# PR_26126_096 Asset Manager V2 Temporary UAT Session Root Notes
22

33
## Temporary Behavior
4-
- `?palette=sample` remains isolated in `TemporaryUatSamplePalette.js`.
5-
- For UAT preview/path testing only, `?palette=sample` now provides the temporary game root `games/Asteroids/`.
4+
- `?workspace=UAT` remains isolated in `TemporaryUatWorkspace.js`.
5+
- For UAT preview/path testing only, `?workspace=UAT` now provides the temporary game root `games/Asteroids/`.
66
- The temporary root is used only by Asset Manager V2 preview options.
77
- Asset records still store normalized asset paths such as `assets/images/uat-preview.png`; the game root is not persisted into asset entries.
88
- The code and Status log both mark this behavior as temporary UAT-only.
99

1010
## Preview Result
11-
- During `?palette=sample`, file-backed previews for `assets/...` paths resolve through `/games/Asteroids/assets/...`.
11+
- During `?workspace=UAT`, file-backed previews for `assets/...` paths resolve through `/games/Asteroids/assets/...`.
1212
- The temporary preview path does not use Sample or Tool roots.
1313
- Palette color behavior remains unchanged and still uses the temporary sample palette swatches only.
1414

1515
## Validation
1616
- Playwright validates the temporary Status message for `games/Asteroids/`.
17-
- Playwright validates a `?palette=sample` image asset preview renders with `/games/Asteroids/assets/images/uat-preview.png`.
17+
- Playwright validates a `?workspace=UAT` image asset preview renders with `/games/Asteroids/assets/images/uat-preview.png`.
1818
- Playwright validates the UAT preview path excludes `/samples/` and `/tools/`.

docs/dev/reports/PR_26126_097_asset_manager_v2_font_preview_notes.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
## Path Resolution
1010
- Font preview URLs continue to resolve through the active Workspace game root.
11-
- During temporary `?palette=sample` UAT testing, `assets/fonts/vector-battle.ttf` resolves to `/games/Asteroids/assets/fonts/vector-battle.ttf`.
11+
- During temporary `?workspace=UAT` UAT testing, `assets/fonts/vector-battle.ttf` resolves to `/games/Asteroids/assets/fonts/vector-battle.ttf`.
1212
- Existing Workspace V2 font previews continue to resolve under `/games/Asteroids/assets/...` when `gameId=Asteroids` is active.
1313

1414
## Failure Reporting

docs/dev/reports/PR_26126_105_asset_manager_v2_launch_guard_notes.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
## Guarded Launches
44
- Direct Asset Manager V2 launch without Workspace Manager context now shows the launch guard overlay before controls are mounted.
55
- Workspace Manager launch without an active palette now shows the same guard overlay.
6-
- The temporary UAT-only `?palette=sample` context remains allowed and supplies the sample Asteroids game root for preview/path testing.
6+
- The temporary UAT-only `?workspace=UAT` context remains allowed and supplies the sample Asteroids game root for preview/path testing.
77

88
## Overlay Message
99
- The guard message states: `Asset Manager V2 is only available through Workspace Manager with a game workspace and palette.`

docs/dev/reports/PR_26126_105_asset_manager_v2_manual_validation_notes.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
- `npm run test:workspace-v2` passed 13/13 Playwright tests.
1414
- Playwright validates direct Asset Manager V2 launch shows the launch guard overlay.
1515
- Playwright validates Workspace launch without an active palette shows the launch guard overlay.
16-
- Playwright validates `?palette=sample` remains a valid temporary UAT context.
16+
- Playwright validates `?workspace=UAT` remains a valid temporary UAT context.
1717
- Playwright validates Path is disabled and visually matches the disabled ID field.
1818
- Playwright validates click/tap asset selection continues to update selected tile styling, Selected Asset Detail, and preview.
1919
- The keyboard cleanup `rg` search returned no matches in Asset Manager V2 source or the touched Playwright spec.
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# PR_26126_106 Keyboard Cleanup Review Notes
2+
3+
## Review Scope
4+
- Re-reviewed Asset Manager V2 source and Playwright tests after moving the Asset Manager coverage to its own spec.
5+
- Searched Asset Manager source, `AssetManagerV2.spec.mjs`, and `PreviewGeneratorV2Baseline.spec.mjs` for the retired navigation keys and keyboard terms.
6+
7+
## Result
8+
- No Asset Manager V2 handling or assertions remain for KeyD, KeyA, KeyS, KeyW, ArrowLeft, ArrowRight, ArrowUp, ArrowDown, Home, End, PageUp, PageDown, or Enter navigation.
9+
- No WASD, arrow-key, page-key, or `keydown` asset-navigation references remain in the reviewed source/tests.
10+
- Asset selection remains click/tap driven and is validated in `AssetManagerV2.spec.mjs`.
11+
12+
## Validation
13+
- `npm run test:workspace-v2` passed 14/14 tests.
14+
- No sample JSON was modified.
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# PR_26126_106 Test Separation Notes
2+
3+
## Dedicated Spec
4+
- Asset Manager V2 Playwright coverage moved from `tests/playwright/PreviewGeneratorV2Baseline.spec.mjs` to `tests/playwright/AssetManagerV2.spec.mjs`.
5+
- Asset Manager launch, UAT palette/session, import/export, preview, Workspace insertion, and launch-guard assertions now live in the dedicated Asset Manager V2 spec.
6+
- `PreviewGeneratorV2Baseline.spec.mjs` no longer contains Asset Manager V2 helpers or assertions.
7+
8+
## Workspace Gate
9+
- `npm run test:workspace-v2` now runs both `PreviewGeneratorV2Baseline.spec.mjs` and `AssetManagerV2.spec.mjs` with one worker.
10+
- Both specs share `tests/helpers/workspaceV2CoverageReporter.mjs` so the Playwright/V8 report remains combined across the separated suite.
11+
- The required validation passed with 14/14 Playwright tests.
12+
13+
## Scope
14+
- The separated suite preserves Palette Manager V2 coverage naming and Asset Manager V2 runtime coverage in the combined V8 report.
15+
- No sample JSON was modified.
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# PR_26126_106 Workspace UAT Notes
2+
3+
## Launch Modes
4+
- Asset Manager V2 now allows only Workspace Manager session launches or temporary `?workspace=UAT`.
5+
- Direct launch without Workspace Manager session context hard-fails to the launch guard overlay.
6+
- `?workspace=PROD` hard-fails to the launch guard overlay; production launch is only supported through Workspace Manager session state.
7+
8+
## Temporary UAT Context
9+
- `?workspace=UAT` seeds the temporary Asset Manager V2 UAT session with `gameRoot = games/Asteroids/`.
10+
- `?workspace=UAT` seeds `assetsPath = games/Asteroids/assets`.
11+
- `?workspace=UAT` seeds the temporary UAT sample palette for Color asset validation and palette-only picking.
12+
- Preview paths under UAT continue to resolve through `/games/Asteroids/assets/...`.
13+
14+
## Retired Query
15+
- Removed the old sample-palette query source helper path, messages, tests, and report references.
16+
- The isolated helper is now `TemporaryUatWorkspace.js`.
17+
- No sample JSON was modified.

0 commit comments

Comments
 (0)