Fix Workspace Manager click handler to use data-tool-id for correct tool launch - PR 11.182

Author: DavidQ

docs/dev/codex_commands.md

@@ -1,49 +1,15 @@
-# Codex Commands — PR 11.181
 
 Model: GPT-5 high
 Reasoning: high
 
-Fix Workspace Manager SVG launch mapping.
+Fix click handler in:
+tools/Workspace Manager/main.js
 
-Primary files:
-- `tools/Workspace Manager/main.js`
-- `tools/shared/toolRegistry.js` only if registry data is wrong
-- `tools/SVG Asset Studio/main.js` only if entry log is missing after correct launch URL
+- Use dataset.toolId from clicked element
+- Remove any fallback/default tool logic
 
-Hard rules:
-- Do not modify schemas.
-- Do not modify sample 1902 JSON.
-- Do not modify shell behavior.
-- Do not restore shared handoff.
-- Do not migrate all tools.
+Validate:
+node --check tools/Workspace Manager/main.js
 
-Steps:
-1. Add `[WORKSPACE_REGISTRY_RESOLVE]` logging for registry resolution.
-2. Add `[WORKSPACE_TOOL_TILE_RENDER]` logging for rendered tool tiles/buttons.
-3. Add `[WORKSPACE_TOOL_CLICK]` logging before launch dispatch.
-4. Keep/add `[WORKSPACE_TOOL_LAUNCH]` logging.
-5. Add `[SVG_LAUNCH_REQUEST]` for SVG launch.
-6. Fix the first broken link causing SVG click not to launch `svg-asset-studio`.
-7. Create report:
-   - `docs/dev/reports/pr_11_181_validation.md`
-
-Validation:
-- `node --check "tools/Workspace Manager/main.js"`
-- `node --check tools/shared/toolRegistry.js`
-- `node --check "tools/SVG Asset Studio/main.js"`
-
-Manual UAT:
-- Open sample 1902.
-- Click SVG Asset Studio.
-- Confirm:
-  - `[WORKSPACE_TOOL_CLICK] datasetToolId: svg-asset-studio`
-  - `[WORKSPACE_TOOL_LAUNCH] requestedToolId: svg-asset-studio`
-  - `[SVG_LAUNCH_REQUEST]`
-  - `[SVG_ENTRY_TOP]`
-
-Full samples smoke:
-- Skip.
-- Reason: targeted Workspace Manager registry/tile/click launch mapping fix.
-
-Return ZIP artifact at:
-`<project folder>/tmp/PR_11_181_20260430_01.zip`
+Manual:
+Click SVG → verify correct logs

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Fix Workspace Manager SVG tool mapping from registry through click handler - PR 11.181
+Fix Workspace Manager click handler to use data-tool-id for correct tool launch - PR 11.182

docs/pr/BUILD_PR_LEVEL_11_182_FIX_CLICK_HANDLER_TOOL_ID.md

@@ -0,0 +1,51 @@
+
+# BUILD_PR_LEVEL_11_182_FIX_CLICK_HANDLER_TOOL_ID
+
+## Purpose
+Fix Workspace Manager click handler so it launches the correct tool (SVG) instead of always launching vector-map-editor.
+
+## Root Cause
+Click handler is not using `data-tool-id` from the clicked tile.
+
+## Fix
+Use closest `[data-tool-id]` element and pass its dataset value to launchTool.
+
+## Implementation
+
+File:
+tools/Workspace Manager/main.js
+
+Replace click handler logic with:
+
+document.addEventListener("click", (e) => {
+  const el = e.target.closest("[data-tool-id]");
+  if (!el) return;
+
+  const toolId = el.dataset.toolId;
+
+  console.log("[WORKSPACE_TOOL_CLICK]", {
+    clickedToolId: toolId,
+    element: el
+  });
+
+  launchTool(toolId);
+});
+
+## Rules
+- MUST use dataset.toolId
+- MUST NOT fallback to default tool
+- MUST NOT use activeTool/global state
+
+## Acceptance
+Click SVG Asset Studio:
+
+Logs:
+[WORKSPACE_TOOL_CLICK] svg-asset-studio
+[WORKSPACE_TOOL_LAUNCH] svg-asset-studio
+
+Then:
+[SVG_ENTRY_TOP]
+[SVG_HOSTED_WORKSPACE_ENTRY]
+
+UI:
+SVG loads correctly

tools/Workspace Manager/main.js

@@ -172,44 +172,16 @@ function readToolIdFromWorkspaceClickTarget(target = null) {
   if (!(target instanceof Element)) {
     return "";
   }
-  const closestWithToolId = target.closest("[data-tool-id], [data-tool-host-tool-id], [data-tool]");
-  const datasetToolId = normalizeTextParam(
-    closestWithToolId?.getAttribute("data-tool-id")
-      || closestWithToolId?.getAttribute("data-tool-host-tool-id")
-      || closestWithToolId?.getAttribute("data-tool")
-      || ""
-  );
-  if (datasetToolId) {
-    return normalizeToken(datasetToolId);
-  }
-  const link = target.closest("a[href]") || target.querySelector?.("a[href]");
-  const href = link instanceof HTMLAnchorElement ? link.getAttribute("href") || link.href : "";
-  if (!href) {
-    return "";
-  }
-  try {
-    const url = new URL(href, window.location.href);
-    const pathname = decodeURIComponent(url.pathname).replace(/\\/g, "/");
-    const match = manifest.tools.find((entry) => {
-      const launchPath = normalizeTextParam(entry.launchPath).replace(/\\/g, "/");
-      const entryPoint = normalizeTextParam(entry.entryPoint).replace(/\\/g, "/");
-      return (launchPath && pathname.endsWith(launchPath.replace(/^\.\.\//, "/tools/")))
-        || (entryPoint && pathname.endsWith(`/tools/${entryPoint}`));
-    });
-    return match?.id || "";
-  } catch {
-    return "";
-  }
+  const closestWithToolId = target.closest("[data-tool-id]");
+  const datasetToolId = normalizeTextParam(closestWithToolId?.dataset?.toolId);
+  return datasetToolId ? normalizeToken(datasetToolId) : "";
 }
 
 function traceWorkspaceToolClick({ target = null, datasetToolId = "", resolvedToolId = "", source = "" } = {}) {
   const clickedText = target instanceof Element ? normalizeTextParam(target.textContent || "") : "";
   const eventTarget = target instanceof Element ? target.tagName.toLowerCase() : "";
   const closestToolId = target instanceof Element
-    ? normalizeTextParam(target.closest("[data-tool-id], [data-tool-host-tool-id], [data-tool]")?.getAttribute("data-tool-id")
-      || target.closest("[data-tool-id], [data-tool-host-tool-id], [data-tool]")?.getAttribute("data-tool-host-tool-id")
-      || target.closest("[data-tool-id], [data-tool-host-tool-id], [data-tool]")?.getAttribute("data-tool")
-      || "")
+    ? normalizeTextParam(target.closest("[data-tool-id]")?.dataset?.toolId)
     : "";
   console.log("[WORKSPACE_TOOL_CLICK]", {
     source,
@@ -1566,15 +1538,10 @@ function bindPagerDelegatedEvents() {
     const toolNavTarget = target.closest(".tools-platform-frame__nav-link, .tools-platform-frame__nav-tool-row");
     if (toolNavTarget instanceof Element) {
       const resolvedToolId = readToolIdFromWorkspaceClickTarget(toolNavTarget);
-      const datasetToolId = normalizeTextParam(
-        toolNavTarget.getAttribute("data-tool-id")
-          || toolNavTarget.getAttribute("data-tool-host-tool-id")
-          || toolNavTarget.getAttribute("data-tool")
-          || ""
-      );
+      const datasetToolId = normalizeTextParam(toolNavTarget.closest("[data-tool-id]")?.dataset?.toolId);
       traceWorkspaceToolClick({
         target: toolNavTarget,
-        datasetToolId: datasetToolId || resolvedToolId,
+        datasetToolId,
         resolvedToolId,
         source: "tool-nav"
       });