Move Asteroids vector maps into manifest single-source ownership and remove hardcoded runtime maps - PR_26133_113-manifest-vector-map-migration

Author: DavidQ

docs/dev/reports/PR_26133_113-manifest-vector-map-migration_report.md

@@ -0,0 +1,76 @@
+# PR_26133_113-manifest-vector-map-migration Report
+
+## Summary
+- Read `docs/dev/PROJECT_INSTRUCTIONS.md` before implementation.
+- Used `PR_26133_112-object-vector-shape-geometry-layout_report.md` as prior reference; the `PR_26133_112` delta ZIP was not present under `tmp/`.
+- Moved Asteroids vector map ownership into `games/Asteroids/game.manifest.json` under `tools.vector-map-editor.vectorMapDocument`.
+- Added manifest-owned vector maps for ship collision, life icon, UFO collision, attract ship/asteroid/UFO, and splash/attract/UI title metadata.
+- Added manifest-owned Object Vector runtime role bindings and removed hardcoded role object ID fallbacks from runtime resolution.
+- Routed Asteroids gameplay collision geometry, UFO geometry, life icon drawing, and attract silhouettes through manifest-loaded vector maps.
+- Runtime now fails visibly when required Asteroids vector maps or role bindings are missing instead of silently falling back to hardcoded vector data.
+
+## Changed Files
+- `games/Asteroids/game.manifest.json`
+- `games/Asteroids/game/asteroidsVectorMaps.js`
+- `games/Asteroids/game/asteroidsObjectVectorRoles.js`
+- `games/Asteroids/game/AsteroidsGameScene.js`
+- `games/Asteroids/game/AsteroidsAttractAdapter.js`
+- `games/Asteroids/game/AsteroidsWorld.js`
+- `games/Asteroids/entities/Ship.js`
+- `games/Asteroids/entities/Ufo.js`
+- `games/Asteroids/index.js`
+- `tests/games/asteroidsManifestObjectVectors.mjs`
+- `tests/games/AsteroidsAssetReferenceAdoption.test.mjs`
+- `tests/games/AsteroidsPlatformDemo.test.mjs`
+- `tests/games/AsteroidsVectorTransforms.test.mjs`
+- `tests/games/AsteroidsCollisionTimingStress.test.mjs`
+- `tests/games/AsteroidsHardening.test.mjs`
+- `tests/games/AsteroidsValidation.test.mjs`
+- `tests/games/AsteroidsPresentation.test.mjs`
+- `tests/playwright/tools/WorkspaceManagerV2.spec.mjs`
+- `docs/dev/reports/PR_26133_113-manifest-vector-map-migration_report.md`
+
+## Validation
+- PASS: `node --check games/Asteroids/game/asteroidsVectorMaps.js`
+- PASS: `node --check games/Asteroids/game/asteroidsObjectVectorRoles.js`
+- PASS: `node --check games/Asteroids/game/AsteroidsGameScene.js`
+- PASS: `node --check games/Asteroids/entities/Ship.js`
+- PASS: `node --check games/Asteroids/entities/Ufo.js`
+- PASS: `node --check games/Asteroids/game/AsteroidsWorld.js`
+- PASS: `node --check games/Asteroids/index.js`
+- PASS: `node -e "JSON.parse(require('fs').readFileSync('games/Asteroids/game.manifest.json','utf8')); console.log('manifest json ok');"`
+- PASS: targeted Asteroids manifest/vector-map validation command loaded 8 manifest vector maps with usage counts `{ gameplay: 4, collision: 3, ui: 2, attract: 4, splash: 1 }` and all 6 runtime role bindings.
+- PASS: targeted splash/attract/gameplay vector loading validation covered manifest `splash`, `attract`, `gameplay`, `collision`, and `ui` usage buckets, attract vector rendering, gameplay life icon vector rendering, and gameplay Object Vector runtime rendering.
+- PASS: targeted Asteroids tests:
+  - `AsteroidsAssetReferenceAdoption`
+  - `AsteroidsPlatformDemo`
+  - `AsteroidsVectorTransforms`
+  - `AsteroidsCollisionTimingStress`
+  - `AsteroidsHardening`
+  - `AsteroidsValidation`
+  - `AsteroidsPresentation`
+- PASS: `git diff --check` (line-ending warnings only)
+- PASS: `npm run test:workspace-v2` (56 passed)
+
+## Playwright
+- Playwright impacted: Yes.
+- Validated Workspace Manager V2 Asteroids manifest loading, vector-map-editor manifest persistence, attract vector map rendering, gameplay Object Vector rendering, gameplay life icon vector rendering, manifest role binding validation, and no hardcoded Asteroids asset injection on empty Asset Manager payloads.
+- Expected pass behavior: Asteroids boots from manifest-owned vector maps and Object Vector role bindings, renders attract/gameplay vectors, and exposes vector map diagnostics.
+- Expected fail behavior: tests fail if required vector maps are missing, role bindings are missing or tagless, hardcoded fallback injection returns, or Workspace V2 manifest save/status behavior regresses.
+- Playwright V8 coverage report was regenerated by the workspace-v2 run at `docs/dev/reports/playwright_v8_coverage_report.txt`; coverage remains advisory.
+
+## Full Samples Smoke
+- Skipped full samples smoke test by request.
+- Reason: the change is scoped to Asteroids manifest/runtime vector-map ownership and targeted Workspace V2/Asteroids validations passed; shared sample loader/framework behavior was not changed.
+
+## Manual Validation
+1. Open Workspace Manager V2 and select the Asteroids game manifest.
+2. Launch Asteroids from the workspace.
+3. Expected: Asteroids boots without vector map validation errors and attract mode renders manifest-backed ship/asteroid/UFO vectors.
+4. Start gameplay and force or wait for a UFO.
+5. Expected: ship, asteroids, UFO, collisions, and life icons use manifest-loaded vector/object geometry with no hardcoded vector-map fallback.
+6. Temporarily remove a required Asteroids vector map or `objectVectorRoles` binding from the manifest.
+7. Expected: boot/runtime validation fails visibly with the missing manifest vector map or role binding named in the error.
+
+## ZIP
+- Output path: `tmp/PR_26133_113-manifest-vector-map-migration_delta.zip`

games/Asteroids/entities/Ship.js

@@ -7,19 +7,20 @@ Ship.js
 import { wrap } from '../utils/math.js';
 import { transformPoints } from '../../../src/engine/rendering/index.js';
 
-const SMALL_VECTOR_MAP = [
-  { x: 14, y: 0 },
-  { x: -10, y: -8 },
-  { x: -6, y: -3 },
-  { x: -6, y: 3 },
-  { x: -10, y: 8 },
-  { x: 14, y: 0 },
-];
+function normalizePoints(points) {
+  return Array.isArray(points)
+    ? points.map((point) => ({
+      x: Number(point?.x ?? 0),
+      y: Number(point?.y ?? 0),
+    })).filter((point) => Number.isFinite(point.x) && Number.isFinite(point.y))
+    : [];
+}
 
 export default class Ship {
-  constructor(x, y) {
+  constructor(x, y, { collisionPoints = [] } = {}) {
     this.spawnX = x;
     this.spawnY = y;
+    this.collisionPoints = normalizePoints(collisionPoints);
     this.reset();
   }
 
@@ -55,21 +56,10 @@ export default class Ship {
   }
 
   getPoints() {
-    return transformPoints(SMALL_VECTOR_MAP, {
+    return transformPoints(this.collisionPoints, {
       x: this.x,
       y: this.y,
       rotation: this.angle,
     });
   }
-
-  getFlamePoints(pulse = 1) {
-    const rear = this.angle + Math.PI;
-    const flameReach = (18 + pulse * 9) * 0.5;
-    const wingSpread = (8 + pulse * 2) * 0.5;
-    return [
-      { x: this.x + Math.cos(rear) * flameReach, y: this.y + Math.sin(rear) * flameReach },
-      { x: this.x + Math.cos(this.angle + 2.7) * wingSpread, y: this.y + Math.sin(this.angle + 2.7) * wingSpread },
-      { x: this.x + Math.cos(this.angle - 2.7) * wingSpread, y: this.y + Math.sin(this.angle - 2.7) * wingSpread },
-    ];
-  }
 }

games/Asteroids/entities/Ufo.js

@@ -26,25 +26,22 @@ const UFO_PROFILES = {
   },
 };
 
-const VECTOR_MAPS = {
-  small: [
-    { x: -14, y: 3 }, { x: 14, y: 3 }, { x: 9, y: 9 }, { x: -9, y: 9 }, { x: -14, y: 3 }, { x: -9, y: -3 },
-    { x: -5, y: -3 }, { x: -5, y: -6 }, { x: -2, y: -9 }, { x: 2, y: -9 }, { x: 5, y: -6 }, { x: 5, y: -3 }, { x: -5, y: -3 },
-    { x: 9, y: -3 }, { x: 14, y: 3 },
-  ],
-  large: [
-    { x: -21, y: 4.5 }, { x: 21, y: 4.5 }, { x: 13.5, y: 13.5 }, { x: -13.5, y: 13.5 }, { x: -21, y: 4.5 }, { x: -13.5, y: -4.5 },
-    { x: -7.5, y: -4.5 }, { x: -7.5, y: -9 }, { x: -3, y: -13.5 }, { x: 3, y: -13.5 }, { x: 7.5, y: -9 }, { x: 7.5, y: -4.5 }, { x: -7.5, y: -4.5 },
-    { x: 13.5, y: -4.5 }, { x: 21, y: 4.5 },
-  ],
-};
+function normalizePoints(points) {
+  return Array.isArray(points)
+    ? points.map((point) => ({
+      x: Number(point?.x ?? 0),
+      y: Number(point?.y ?? 0),
+    })).filter((point) => Number.isFinite(point.x) && Number.isFinite(point.y))
+    : [];
+}
 
 export default class Ufo {
-  constructor(bounds, type = 'large', level = 1, rng = Math.random) {
+  constructor(bounds, type = 'large', level = 1, rng = Math.random, { collisionPoints = [] } = {}) {
     this.bounds = bounds;
     this.rng = typeof rng === 'function' ? rng : Math.random;
     this.type = UFO_PROFILES[type] ? type : 'large';
     this.profile = UFO_PROFILES[this.type];
+    this.collisionPoints = normalizePoints(collisionPoints);
     this.direction = this.rng() > 0.5 ? 1 : -1;
     this.x = this.direction > 0 ? -48 : bounds.width + 48;
     this.y = randomRange(120, bounds.height - 140, this.rng);
@@ -108,7 +105,7 @@ export default class Ufo {
   }
 
   getCollisionPolygon() {
-    return transformPoints(VECTOR_MAPS[this.type], {
+    return transformPoints(this.collisionPoints, {
       x: this.x,
       y: this.y,
     });