Skip to content

Commit e57dbdf

Browse files
author
DavidQ
committed
Fix Palette Manager accordion flex sizing so palette grids fill height and scroll internally - PR_26124_037-fix-palette-grid-flex-height. Revert broken Palette Manager flex-height layout and restore usable scrolling tile viewports - PR_26124_038-revert-broken-palette-flex-height. Stabilize Palette Manager grid viewport heights with predictable internal scrolling - PR_26124_039-palette-grid-stable-viewport-heights. Increase Palette Manager source grid height while preserving stable internal scrolling - PR_26124_040-palette-source-grid-taller.
1 parent cdf2537 commit e57dbdf

7 files changed

Lines changed: 188 additions & 399 deletions

File tree

‎docs/dev/reports/PR_26124_037_report.md‎

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# PR_26124_037 Palette Grid Flex Height Report
2+
3+
## Scope
4+
- Updated Palette Manager V2 CSS layout for User Palette and Source Palette tile grids.
5+
- No JavaScript, sorting logic, swatch size logic, JSON behavior, workspace, toolState, session, schema, sample JSON, games, or tools/shared changes.
6+
7+
## Changes
8+
- Center panel now explicitly has `height: 100%` and `min-height: 0`.
9+
- Open center accordions use `flex: 1 1 auto`, `min-height: 0`, and `overflow: hidden`.
10+
- Center accordion content uses `display: flex`, `flex-direction: column`, `flex: 1 1 auto`, `min-height: 0`, and `overflow: hidden`.
11+
- Shared User/Source tile grid uses `flex: 1 1 0`, `height: auto`, `min-height: 0`, `max-height: none`, and `overflow-y: auto`.
12+
- Removed the stale fixed-height `.palette-manager-v2__list` block.
13+
- Reduced tile grid bottom padding from `150px` to `8px` to remove large empty space under swatches.
14+
15+
## Manual CSS Verification
16+
- Verified the center flex chain from panel to open accordion to accordion content to tile grid.
17+
- Verified non-grid controls remain fixed above the scrolling tile grid.
18+
- Verified both User Palette and Source Palette use the shared `.palette-manager-v2__tile-grid` rules.
19+
20+
## Validation
21+
- No changed JavaScript files; syntax check not required.
22+
- `git diff --check`
23+
24+
## Packaging
25+
- Delta ZIP: `tmp/PR_26124_037-fix-palette-grid-flex-height_delta.zip`

‎docs/dev/reports/PR_26124_038_report.md‎

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# PR_26124_038 Revert Broken Palette Flex Height Report
2+
3+
## Scope
4+
- Fixed the Palette Manager V2 layout regression from the flex-height pass.
5+
- CSS-only change; no sorting logic, swatch size logic, JSON behavior, workspace, toolState, session, schema, sample JSON, games, or tools/shared changes.
6+
7+
## Changes
8+
- Removed center-panel open accordion flex-fill rules that made palette accordions too tall.
9+
- Removed center-panel accordion-content flex-height management so accordion content returns to normal grid flow.
10+
- Kept controls above the scroll area.
11+
- Restored explicit usable internal-scroll viewport heights:
12+
- User Palette tile grid: `max-height: 320px`
13+
- Source Palette tile grid: `max-height: 420px`
14+
- Preserved `overflow-x: visible` for tile hover popovers.
15+
16+
## Manual CSS Verification
17+
- Verified the center-panel flex-fill overrides are no longer present.
18+
- Verified accordion content uses the base grid layout.
19+
- Verified both tile grids use internal `overflow-y: auto` with explicit viewport max heights.
20+
21+
## Validation
22+
- No changed JavaScript files; syntax check not required.
23+
- `git diff --check`
24+
25+
## Packaging
26+
- Delta ZIP: `tmp/PR_26124_038-revert-broken-palette-flex-height_delta.zip`

‎docs/dev/reports/PR_26124_039_report.md‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# PR_26124_039 Palette Grid Stable Viewport Heights Report
2+
3+
## Scope
4+
- Stabilized Palette Manager V2 User Palette and Source Palette tile grid viewport heights.
5+
- CSS-only change; no sorting logic, swatch size logic, JSON behavior, workspace, toolState, session, schema, sample JSON, games, or tools/shared changes.
6+
7+
## Changes
8+
- User Palette grid now uses `max-height: clamp(220px, 28vh, 360px)` with internal `overflow-y: auto`.
9+
- Source Palette grid now uses `max-height: clamp(260px, 34vh, 460px)` with internal `overflow-y: auto`.
10+
- Preserved normal accordion content flow and avoided open-accordion flex-fill rules.
11+
- Preserved `overflow-x: visible` on the shared tile grid for hover popovers where possible.
12+
13+
## Manual CSS Validation
14+
- Verified no center-panel open accordion flex-fill rule remains.
15+
- Verified accordion content continues to use the base grid layout.
16+
- Verified User Palette and Source Palette grids have independent scroll containers.
17+
- Verified no sorting, size, JSON, workspace, or shared logic changed.
18+
19+
## Validation
20+
- CSS/manual validation only.
21+
- `git diff --check`
22+
23+
## Packaging
24+
- Delta ZIP: `tmp/PR_26124_039-palette-grid-stable-viewport-heights_delta.zip`

‎docs/dev/reports/PR_26124_040_report.md‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
# PR_26124_040 Report
2+
3+
## Purpose
4+
Increase the Palette Manager source palette grid usable height while preserving stable internal scrolling.
5+
6+
## Changes
7+
- Updated `tools/palette-manager-v2/paletteManagerV2.css` so `.palette-manager-v2__tile-grid--source` uses `max-height: clamp(360px, 48vh, 620px);`.
8+
- Kept the User Palette grid stable at `max-height: clamp(220px, 28vh, 360px);`.
9+
- Left the center panel accordion flow unchanged; no flex-fill accordion behavior was added.
10+
11+
## Scope Checks
12+
- Runtime/data logic unchanged.
13+
- JSON behavior unchanged.
14+
- `tools/shared` unchanged.
15+
- No workspace, toolState, or session logic added.
16+
17+
## Validation
18+
- CSS/manual validation: confirmed the source grid keeps `overflow-y: auto`, the base tile grid keeps `overflow-x: visible`, and the user grid retains its previous stable viewport behavior.
19+
- CSS/manual validation: confirmed center accordion content remains in normal grid flow and no center-panel open-accordion flex-fill rule was introduced.
20+
- `git diff --check -- tools/palette-manager-v2/paletteManagerV2.css` passed with only the existing Git LF/CRLF warning.

‎docs/dev/reports/codex_changed_files.txt‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,2 @@
1-
docs/dev/reports/PR_26124_035_report.md
2-
docs/dev/reports/PR_26124_035_scrollbar_completion_report.md
3-
tools/palette-manager-v2/controls/SourcePaletteBrowserControl.js
4-
tools/palette-manager-v2/controls/UserPaletteControl.js
5-
tools/palette-manager-v2/index.html
6-
tools/palette-manager-v2/modules/PaletteManagerApp.js
1+
docs/dev/reports/PR_26124_040_report.md
72
tools/palette-manager-v2/paletteManagerV2.css

0 commit comments

Comments
 (0)