Refactor Palette Manager V2 into class-based controls and centralize read-only palettes in engine palette list - PR_26124_027-palette-manager-clean-class-architecture

Author: DavidQ

docs/dev/reports/PR_26124_027_report.md

@@ -0,0 +1,42 @@
+# PR_26124_027 Palette Manager Clean Class Architecture
+
+## Summary
+- Rebuilt `tools/palette-manager-v2/main.js` as bootstrap/orchestration only.
+- Split Palette Manager behavior into class-based controls:
+  - `PaletteEditorControl`
+  - `UserPaletteControl`
+  - `SourcePaletteBrowserControl`
+  - `PaletteImportExportControl`
+  - `PaletteValidationErrorControl`
+- Added `tools/common/PaletteUsageService.js` as the reusable swatch usage boundary. It returns `false` and does not scan samples or games.
+- Moved source palette authority to `src/engine/paletteList.js` through frozen `SOURCE_PALETTES`.
+- Deleted `src/engine/paletteDefaults.js` and confirmed no active runtime references remain.
+
+## Contract Notes
+- Runtime tool id remains `palette-manager-v2`.
+- Published output key remains `tools.palette-browser`.
+- User palette shape remains:
+
+```json
+{
+  "swatches": [
+    {
+      "symbol": "R",
+      "hex": "#FF0000",
+      "name": "Red",
+      "source": "user"
+    }
+  ]
+}
+```
+
+## Validation
+- `node --check` passed for changed Palette Manager, common, and palette engine JavaScript files.
+- Palette source VM check passed: `SOURCE_PALETTES` exposes `crayola`, `w3c`, and `javascript`; source arrays are frozen; legacy `palettesList.crayola032` remains available.
+- `node scripts/validate-active-tools-surface.mjs` passed.
+- `node scripts/validate-project-system.mjs` failed on pre-existing project-system surface issues outside this PR scope.
+- `git diff --check` passed with line-ending warnings only.
+- Playwright remains intentionally skipped/removed as V2-only surface.
+
+## Package
+- Delta ZIP: `tmp/PR_26124_027-palette-manager-clean-class-architecture_delta.zip`

docs/dev/reports/codex_changed_files.txt

@@ -1,86 +1,37 @@
 # git status --short
-D .github/workflows/workspace-v2-playwright.yml
- M docs/design/tools/TOOLS_REENGINEERING_INDEX.md
- D docs/design/tools/palette-browser/REENGINEERING_DESIGN.md
- M docs/dev/reports/codex_changed_files.txt
+M docs/dev/reports/codex_changed_files.txt
  M docs/dev/reports/codex_review.diff
+ M docs/dev/reports/project_system_validation.txt
  M docs/dev/roadmaps/MASTER_ROADMAP_TOOLS.md
- M package.json
- M scripts/audit-sample-json-ownership.mjs
- D scripts/run-workspace-v2-playwright-gate.mjs
- M scripts/sync-tool-hints-from-workspace-manager.mjs
- D scripts/update-tool-completion-audit-from-playwright.mjs
- M scripts/validate-active-tools-surface.mjs
- M scripts/validate-project-system.mjs
- D tests/asset-manager.spec.js
- D tests/playwright/tool-validation/workspace-v2.tool-validation.spec.js
- D tests/playwright/workspace-v2.validation.spec.js
- M tests/tools/AssetUsageIntegration.test.mjs
- M tests/tools/ToolEntryLaunchContract.test.mjs
- M tests/tools/ToolLayoutDockingControlNormalization.test.mjs
- M tests/tools/ToolWorkspaceSchemaManifestBoundaries.test.mjs
- D tests/ui/workspace-v2.asset-manager.spec.js
- D "tools/Palette Browser/README.md"
- D "tools/Palette Browser/assets/images/preview.svg"
- D "tools/Palette Browser/how_to_use.html"
- D "tools/Palette Browser/index.html"
- D "tools/Palette Browser/main.js"
- D "tools/Palette Browser/paletteBrowser.css"
- M tools/dev/checkSharedExtractionGuard.baseline.json
- M tools/shared/assetUsageIntegration.js
- M tools/shared/documentModeGuards.js
- M tools/shared/platformShell.js
- M tools/shared/projectSystemAdapters.js
- M tools/shared/projectToolIntegration.js
- M tools/shared/toolLoadDiagnostics.js
- M tools/templates/starter-project-template/config/starter.project.json
- M tools/toolRegistry.js
-?? docs/design/tools/palette-manager-v2/
-?? docs/dev/reports/PR_26124_026_report.md
-?? tools/palette-manager-v2/
+ D src/engine/paletteDefaults.js
+ M src/engine/paletteList.js
+ M tools/palette-manager-v2/README.md
+ M tools/palette-manager-v2/index.html
+ M tools/palette-manager-v2/main.js
+?? docs/dev/reports/PR_26124_027_report.md
+?? tools/common/
+?? tools/palette-manager-v2/controls/
+?? tools/palette-manager-v2/modules/
 
-# git diff --stat
-.github/workflows/workspace-v2-playwright.yml      |   39 -
- docs/design/tools/TOOLS_REENGINEERING_INDEX.md     |    6 +-
- .../tools/palette-browser/REENGINEERING_DESIGN.md  |  134 ---
- docs/dev/roadmaps/MASTER_ROADMAP_TOOLS.md          |    7 +-
- package.json                                       |    2 -
- scripts/audit-sample-json-ownership.mjs            |    6 +-
- scripts/run-workspace-v2-playwright-gate.mjs       |   72 --
- scripts/sync-tool-hints-from-workspace-manager.mjs |    2 +-
- ...pdate-tool-completion-audit-from-playwright.mjs |  216 -----
- scripts/validate-active-tools-surface.mjs          |    5 +-
- scripts/validate-project-system.mjs                |    6 +-
- tests/asset-manager.spec.js                        |   24 -
- .../workspace-v2.tool-validation.spec.js           |  208 ----
- tests/playwright/workspace-v2.validation.spec.js   |  252 -----
- tests/tools/AssetUsageIntegration.test.mjs         |    2 +-
- tests/tools/ToolEntryLaunchContract.test.mjs       |    8 +-
- .../ToolLayoutDockingControlNormalization.test.mjs |    4 +-
- .../ToolWorkspaceSchemaManifestBoundaries.test.mjs |   12 +-
- tests/ui/workspace-v2.asset-manager.spec.js        |  118 ---
- tools/Palette Browser/README.md                    |   22 -
- tools/Palette Browser/assets/images/preview.svg    |   84 --
- tools/Palette Browser/how_to_use.html              |   71 --
- tools/Palette Browser/index.html                   |   90 --
- tools/Palette Browser/main.js                      | 1023 --------------------
- tools/Palette Browser/paletteBrowser.css           |  254 -----
- tools/dev/checkSharedExtractionGuard.baseline.json |   10 -
- tools/shared/assetUsageIntegration.js              |   12 +-
- tools/shared/documentModeGuards.js                 |    4 +-
- tools/shared/platformShell.js                      |   19 +-
- tools/shared/projectSystemAdapters.js              |   25 +-
- tools/shared/projectToolIntegration.js             |   16 +-
- tools/shared/toolLoadDiagnostics.js                |    8 +-
- .../config/starter.project.json                    |    4 +-
- tools/toolRegistry.js                              |   18 +-
- 34 files changed, 68 insertions(+), 2715 deletions(-)
+# git diff --stat (excluding codex review artifacts)
+docs/dev/reports/project_system_validation.txt |   9 +-
+ docs/dev/roadmaps/MASTER_ROADMAP_TOOLS.md      |   4 +-
+ src/engine/paletteDefaults.js                  |  19 -
+ src/engine/paletteList.js                      |  54 +++
+ tools/palette-manager-v2/README.md             |   1 +
+ tools/palette-manager-v2/index.html            |   1 +
+ tools/palette-manager-v2/main.js               | 565 +------------------------
+ 7 files changed, 86 insertions(+), 567 deletions(-)
 
-# untracked files included in codex_review.diff
-docs/design/tools/palette-manager-v2/REENGINEERING_DESIGN.md
-docs/dev/reports/PR_26124_026_report.md
-tools/palette-manager-v2/how_to_use.html
-tools/palette-manager-v2/index.html
-tools/palette-manager-v2/main.js
-tools/palette-manager-v2/paletteManagerV2.css
-tools/palette-manager-v2/README.md
+# untracked file additions
+ docs/dev/reports/PR_26124_027_report.md | 42 +
+ tools/common/PaletteUsageService.js | 5 +
+ tools/palette-manager-v2/controls/PaletteEditorControl.js | 55 +
+ tools/palette-manager-v2/controls/PaletteImportExportControl.js | 75 +
+ tools/palette-manager-v2/controls/PaletteValidationErrorControl.js | 20 +
+ tools/palette-manager-v2/controls/SourcePaletteBrowserControl.js | 67 +
+ tools/palette-manager-v2/controls/UserPaletteControl.js | 34 +
+ tools/palette-manager-v2/modules/PaletteManagerApp.js | 323 +
+ tools/palette-manager-v2/modules/PaletteValidationService.js | 65 +
+ tools/palette-manager-v2/modules/SwatchRow.js | 46 +
+ tools/palette-manager-v2/modules/paletteUtils.js | 30 +