Clean up Object Vector Studio V2 object panel actions, z-action sizing, and object/game/name identity fields - PR_26132_023-object-vector-studio-v2-object-panel-cleanup

Author: DavidQ

docs/dev/reports/playwright_v8_coverage.txt

@@ -20,8 +20,10 @@ Exercised tool entry points detected:
 (0%) Workspace Manager - not exercised by this Playwright run
 
 Changed runtime JS files covered:
-(80%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 99/99; executed functions 4/5
-(90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 3217/3217; executed functions 335/373
+(80%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 97/97; executed functions 4/5
+(90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 3187/3187; executed functions 331/369
+(95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 409/409; executed functions 53/56
+(98%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - executed lines 914/914; executed functions 106/108
 
 Files with executed line/function counts where available:
 (2%) src/engine/input/ActionInputService.js - executed lines 397/397; executed functions 1/51
@@ -167,7 +169,7 @@ Files with executed line/function counts where available:
 (80%) src/engine/persistence/StorageService.js - executed lines 49/49; executed functions 4/5
 (80%) tools/asset-manager-v2/js/controls/AccordionSection.js - executed lines 27/27; executed functions 4/5
 (80%) tools/asset-manager-v2/js/controls/AssetFormControl.js - executed lines 563/563; executed functions 49/61
-(80%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 99/99; executed functions 4/5
+(80%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 97/97; executed functions 4/5
 (80%) tools/palette-manager-v2/modules/PaletteHistoryStack.js - executed lines 54/54; executed functions 8/10
 (80%) tools/preview-generator-v2/controls/AccordionSection.js - executed lines 31/31; executed functions 4/5
 (80%) tools/preview-generator-v2/PreviewGeneratorV2Logger.js - executed lines 19/19; executed functions 4/5
@@ -193,7 +195,7 @@ Files with executed line/function counts where available:
 (88%) tools/world-vector-studio-v2/js/controls/SourceInputControl.js - executed lines 33/33; executed functions 7/8
 (89%) tools/asset-manager-v2/js/services/AssetSchemaValidator.js - executed lines 295/295; executed functions 25/28
 (89%) tools/preview-generator-v2/controls/StatusLogControl.js - executed lines 32/32; executed functions 8/9
-(90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 3217/3217; executed functions 335/373
+(90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 3187/3187; executed functions 331/369
 (90%) tools/palette-manager-v2/modules/PaletteValidationService.js - executed lines 88/88; executed functions 9/10
 (90%) tools/text2speech-V2/js/controls/ActionNavControl.js - executed lines 117/117; executed functions 19/21
 (90%) tools/text2speech-V2/js/TextToSpeechToolApp.js - executed lines 807/807; executed functions 62/69
@@ -208,9 +210,9 @@ Files with executed line/function counts where available:
 (93%) tools/workspace-manager-v2/js/controls/ToolTilesControl.js - executed lines 137/137; executed functions 14/15
 (94%) games/shared/workspaceGameMetadataHydrator.js - executed lines 106/106; executed functions 16/17
 (94%) tools/common/PaletteSortService.js - executed lines 103/103; executed functions 17/18
-(95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 401/401; executed functions 52/55
+(95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 409/409; executed functions 53/56
 (95%) tools/session-inspector-v2/js/services/SessionInspectorV2StorageService.js - executed lines 142/142; executed functions 18/19
-(98%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - executed lines 914/914; executed functions 105/107
+(98%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - executed lines 914/914; executed functions 106/108
 (100%) games/Asteroids/entities/Asteroid.js - executed lines 72/72; executed functions 11/11
 (100%) games/Asteroids/flow/attract.js - executed lines 17/17; executed functions 1/1
 (100%) games/Asteroids/flow/highscore.js - executed lines 16/16; executed functions 1/1
@@ -293,5 +295,8 @@ Uncovered or low-coverage changed JS files:
 
 Changed JS files considered:
 (0%) tests/playwright/tools/WorkspaceManagerV2.spec.mjs - changed JS file not collected as browser runtime coverage
+(0%) tools/object-vector-studio-v2/tests/playwright/FirstClassToolStarter.spec.mjs - changed JS file not collected as browser runtime coverage
 (80%) tools/object-vector-studio-v2/js/bootstrap.js - changed JS file with browser V8 coverage
 (90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - changed JS file with browser V8 coverage
+(95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - changed JS file with browser V8 coverage
+(98%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - changed JS file with browser V8 coverage

docs/pr/PR_26132_023-object-vector-studio-v2-object-panel-cleanup.md

@@ -0,0 +1,84 @@
+# PR_26132_023-object-vector-studio-v2-object-panel-cleanup
+
+## Scope
+
+Updates Object Vector Studio V2 object panel layout, z-action button sizing, and durable object identity naming. No unrelated tools and no sample JSON changes.
+
+## Changes
+
+- Moved Add, Rename, Duplicate, and Delete from the Objects accordion to the bottom of the Object accordion.
+- Removed the Object Type input, datalist wiring, object type normalization, object type suggestions, and object type payload persistence.
+- Kept Object Name and Tag inputs on inline label/input rows.
+- Matched z-action button sizing to shape icon buttons in Words and Icons modes for Bring Forward, Send Backward, Bring To Front, Send To Back, Group Shapes, and Ungroup.
+- Updated Object Vector Studio V2 durable object identity to `object.<game>.<name>`.
+- Updated rename/add flows so object ids remain schema-compliant when object names change.
+- Updated Asteroids Object Vector assets to remove object-level `type` fields while preserving shape `type` fields.
+- Updated Object Vector Studio V2 schema and runtime validation to reject object-level `type` and non-`object.game.name` ids.
+- Updated Object Vector Studio V2 documentation to describe object/game/name identity in object tiles.
+
+## Validation
+
+Playwright impacted: Yes.
+
+Commands run:
+
+- `node --check tools/object-vector-studio-v2/js/ToolStarterApp.js`
+- `node --check tools/object-vector-studio-v2/js/bootstrap.js`
+- `node --check tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js`
+- `node --check src/engine/rendering/ObjectVectorRuntimeAssetService.js`
+- `node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs`
+- `node --check tools/object-vector-studio-v2/tests/playwright/FirstClassToolStarter.spec.mjs`
+- `node -e "const fs=require('fs'); for (const file of ['tools/schemas/tools/object-vector-studio-v2.schema.json','games/Asteroids/game.manifest.json']) { JSON.parse(fs.readFileSync(file,'utf8')); console.log(file + ' OK'); }"`
+- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list --grep "Object Vector Studio V2"`
+- `npx playwright test --config=tools/object-vector-studio-v2/playwright.config.mjs --workers=1 --reporter=list`
+- `npm run test:workspace-v2`
+- `git diff --check`
+
+Result:
+
+- Focused Object Vector Studio V2 workspace coverage passed: 6 passed.
+- Tool-local Object Vector Studio V2 coverage passed: 4 passed.
+- Full Workspace Manager V2 suite passed: 45 passed.
+- Playwright V8 coverage refreshed at `docs/dev/reports/playwright_v8_coverage.txt`.
+- Full samples smoke test skipped per request; this PR does not modify sample JSON.
+
+## Playwright Coverage
+
+Validates:
+
+- z-action button/icon size parity with shape icon buttons.
+- Object actions live at the bottom of the Object accordion.
+- Object Type UI is absent.
+- Object Name and Tag rows are inline.
+- `object.game.name` schema validation rejects old object ids.
+- Object-level `type` payload drift is rejected.
+- Rename updates the schema-compliant identity id consistently.
+- Object Vector asset authoring, animation, inheritance, runtime rendering, and workspace launch flows still load with the new identity contract.
+
+Expected pass behavior:
+
+- Object Vector Studio V2 uses durable object ids shaped as `object.<game>.<name>`, keeps object actions in the Object panel, and rejects old object type/id drift before render.
+
+Expected fail behavior:
+
+- Invalid Object Vector payloads log visible FAIL entries and do not partially render.
+
+## Manual Validation
+
+1. Open `tools/object-vector-studio-v2/index.html`.
+2. Import a valid Object Vector Studio V2 payload.
+3. Confirm the Object accordion shows inline Object Name and Tag rows and has Add/Rename/Duplicate/Delete at the bottom.
+4. Confirm the Objects accordion has no Add/Rename/Duplicate/Delete action row.
+5. Toggle Words/Icons and confirm z-action buttons match the shape tool button footprint.
+6. Rename an object and confirm JSON Details updates its id to `object.<game>.<renamed-name>`.
+7. Try importing a payload with object-level `type` or a bare id such as `ship`; confirm it fails visibly before render.
+
+Expected outcome:
+
+- The Object panel is cleaner, object identity follows the schema naming standard, and old object type payloads are rejected.
+
+## Out Of Scope
+
+- No unrelated tools.
+- No sample JSON changes.
+- No full samples smoke test.

games/Asteroids/game.manifest.json

@@ -256,7 +256,6 @@
             {
               "id": "object.asteroids.ship",
               "name": "Asteroids Ship",
-              "type": "ship",
               "shapes": [
                 {
                   "id": "ship-hull",
@@ -405,7 +404,6 @@
             {
               "id": "object.asteroids.asteroid.large",
               "name": "Large Asteroid",
-              "type": "object",
               "shapes": [
                 {
                   "id": "large-asteroid-ridge",
@@ -484,7 +482,6 @@
             {
               "id": "object.asteroids.asteroid.medium",
               "name": "Medium Asteroid",
-              "type": "object",
               "shapes": [
                 {
                   "id": "medium-asteroid-ridge",
@@ -559,7 +556,6 @@
             {
               "id": "object.asteroids.asteroid.small",
               "name": "Small Asteroid",
-              "type": "object",
               "shapes": [
                 {
                   "id": "small-asteroid-ridge",
@@ -630,7 +626,6 @@
             {
               "id": "object.asteroids.ufo.large",
               "name": "Large UFO",
-              "type": "enemy",
               "shapes": [
                 {
                   "id": "large-ufo-body",
@@ -707,7 +702,6 @@
             {
               "id": "object.asteroids.ufo.small",
               "name": "Small UFO",
-              "type": "enemy",
               "shapes": [
                 {
                   "id": "small-ufo-body",

src/engine/rendering/ObjectVectorRuntimeAssetService.js

@@ -9,6 +9,10 @@ function clone(value) {
   return JSON.parse(JSON.stringify(value));
 }
 
+function isObjectIdentityId(value) {
+  return /^object\.[a-z0-9-]+\.[a-z0-9][a-z0-9.-]*$/.test(String(value || ""));
+}
+
 function typeMatches(expectedType, value) {
   if (expectedType === "array") {
     return Array.isArray(value);
@@ -287,13 +291,9 @@ export class ObjectVectorRuntimeAssetService {
     const dependencyGraph = new Map();
     const objectsById = new Map();
     const objectsByName = new Map();
-    const objectsByType = new Map();
     payload.objects.forEach((object) => {
       objectsById.set(object.id, object);
       objectsByName.set(object.name.toLowerCase(), object);
-      const typedObjects = objectsByType.get(object.type) || [];
-      typedObjects.push(object);
-      objectsByType.set(object.type, typedObjects);
       dependencyGraph.set(object.id, object.baseObjectId ? [object.baseObjectId] : []);
     });
     (payload.assetLibrary?.assets || []).forEach((asset) => {
@@ -308,20 +308,19 @@ export class ObjectVectorRuntimeAssetService {
       dependencyGraph,
       objectsById,
       objectsByName,
-      objectsByType,
       payload,
       sourceLabel
     };
   }
 
-  resolveObject(assetSet, { assetId = "", objectId = "", name = "", type = "" } = {}) {
+  resolveObject(assetSet, { assetId = "", objectId = "", name = "" } = {}) {
     if (!assetSet) {
       this.log("FAIL", "Object Vector runtime object resolution failed: no validated asset set is loaded.");
       return null;
     }
-    const cacheKey = `${assetSet.sourceLabel}:${assetId || objectId || name || type || "unknown"}`;
+    const cacheKey = `${assetSet.sourceLabel}:${assetId || objectId || name || "unknown"}`;
     if (this.assetCache.has(cacheKey)) {
-      this.logCacheOnce(cacheKey, `Object Vector runtime cache hit for ${assetId || objectId || name || type}.`);
+      this.logCacheOnce(cacheKey, `Object Vector runtime cache hit for ${assetId || objectId || name}.`);
       return this.assetCache.get(cacheKey);
     }
 
@@ -340,11 +339,8 @@ export class ObjectVectorRuntimeAssetService {
     if (!object && name) {
       object = assetSet.objectsByName.get(name.toLowerCase()) || null;
     }
-    if (!object && type) {
-      object = assetSet.objectsByType.get(type)?.[0] || null;
-    }
     if (!object) {
-      this.log("FAIL", `Object Vector runtime object resolution failed: objectId=${objectId || "none"} name=${name || "none"} type=${type || "none"}.`);
+      this.log("FAIL", `Object Vector runtime object resolution failed: objectId=${objectId || "none"} name=${name || "none"}.`);
       return null;
     }
 
@@ -658,6 +654,9 @@ export class ObjectVectorRuntimeAssetService {
     if (!isPlainObject(schema.$defs?.shape) || !Array.isArray(schema.$defs.shape.oneOf)) {
       errors.push("Object Vector Studio V2 schema must define shape variants.");
     }
+    if (Object.prototype.hasOwnProperty.call(schema.$defs?.object?.properties || {}, "type")) {
+      errors.push("Object Vector Studio V2 object schema must not define object type.");
+    }
   }
 
   validatePayload(payload) {
@@ -705,6 +704,9 @@ export class ObjectVectorRuntimeAssetService {
   validateInheritanceReferences(payload, errors) {
     const objectsById = new Map();
     payload.objects.forEach((object, objectIndex) => {
+      if (!isObjectIdentityId(object.id)) {
+        errors.push(`root.objects[${objectIndex}].id ${object.id} must follow object.game.name.`);
+      }
       if (objectsById.has(object.id)) {
         errors.push(`root.objects[${objectIndex}].id ${object.id} duplicates an existing object id.`);
         return;
@@ -884,7 +886,6 @@ export class ObjectVectorRuntimeAssetService {
         id: object.id.trim(),
         name: object.name.trim(),
         tags: Array.isArray(object.tags) ? object.tags.map((tag) => tag.trim()).filter(Boolean) : undefined,
-        type: object.type.trim().toLowerCase(),
         shapes: object.shapes.map((shape) => ({
           ...shape,
           id: shape.id.trim(),