Validate Asteroids runtime objects from manifest and remove fallback geometry - PR_26133_036-asteroids-manifest-name-validation-no-fallback

Author: DavidQ

docs/dev/reports/asteroids_manifest_runtime_validation_report.md

@@ -0,0 +1,66 @@
+# PR_26133_036 Asteroids Manifest Runtime Validation Report
+
+Task: PR_26133_036-asteroids-manifest-name-validation-no-fallback
+Date: 2026-05-15
+
+## Binding Contract
+
+Asteroids runtime roles now require explicit manifest bindings from:
+
+`game.gameData.objectVectorRuntime.objectIds`
+
+Required roles:
+
+- `ship` -> tags `player`, `ship`
+- `asteroidLarge` -> tags `asteroid`, `large`
+- `asteroidMedium` -> tags `asteroid`, `medium`
+- `asteroidSmall` -> tags `asteroid`, `small`
+- `ufoLarge` -> tags `ufo`, `large`
+- `ufoSmall` -> tags `ufo`, `small`
+
+## Runtime Behavior
+
+- Valid manifest bindings are checked before `AsteroidsGameScene` starts gameplay.
+- Missing bindings fail with the exact missing manifest path.
+- Bindings pointing at missing objects fail with the requested object ID.
+- Bindings pointing at objects without required tags fail with required and actual tag data.
+- Duplicate tag candidates do not use newest/non-old guessing; runtime logs exact candidates and uses the explicit manifest binding only when it is valid.
+- Old/legacy tagged objects cannot be selected by runtime binding.
+
+## Manifest Data
+
+- `object.asteroids.medium-asteroid` remains the runtime-bound Medium Asteroid.
+- `object.asteroids.medium-asteroid-2` is retained as a distinct editable Medium Asteroid 2 with medium tags and medium geometry.
+- Medium duplicate candidates are logged, and runtime deterministically selects `object.asteroids.medium-asteroid` from the manifest binding.
+
+## Fallback Removal Check
+
+PASS - No Asteroids/shared runtime references found for:
+
+```text
+BASE_VECTOR_MAP
+ASTEROIDS_*_SVG
+vector.asteroids.*
+```
+
+Generic non-Asteroids Object Vector tag selection remains available for callers that do not opt into `requireManifestBinding`; Asteroids runtime calls opt into strict manifest binding.
+
+## Validation
+
+PASS - `npm run test:workspace-v2`: 49 passed, 0 failed.
+
+PASS - `node -e "import('./tests/games/AsteroidsPlatformDemo.test.mjs').then((m)=>m.run())"`
+
+PASS - `node -e "import('./tests/games/AsteroidsAssetReferenceAdoption.test.mjs').then((m)=>m.run())"`
+
+PASS - Targeted binding validation:
+
+```json
+{
+  "objectCount": 7,
+  "valid": true,
+  "selectedMedium": "object.asteroids.medium-asteroid",
+  "missingMediumFails": true,
+  "invalidMediumFails": true
+}
+```

docs/dev/reports/playwright_v8_coverage_report.md

@@ -1,6 +1,6 @@
-# PR_26133_035 Playwright V8 Coverage Report
+# PR_26133_036 Playwright V8 Coverage Report
 
-Task: PR_26133_035-object-id-slug-normalization
+Task: PR_26133_036-asteroids-manifest-name-validation-no-fallback
 Date: 2026-05-15
 
 ## Result
@@ -26,17 +26,22 @@ PASS - Coverage reporting was generated during `npm run test:workspace-v2`.
 ## Changed Runtime JS Coverage
 
 ```text
-(93%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 4350/4350; executed functions 456/488
-(95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 453/453; executed functions 55/58
-(97%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - executed lines 1056/1056; executed functions 123/127
+(97%) src/engine/rendering/ObjectVectorRuntimeAssetService.js - executed lines 1145/1145; executed functions 123/127
+```
+
+Additional changed Asteroids runtime modules were exercised by the Workspace V2 Asteroids gameplay rendering test:
+
+```text
+(50%) games/Asteroids/index.js - executed lines 211/211; executed functions 6/12
+(52%) games/Asteroids/game/AsteroidsGameScene.js - executed lines 874/874; executed functions 26/50
 ```
 
 ## Guardrail
 
 ```text
-(100%) none - no changed runtime JS coverage warnings
+(100%) no changed runtime JS coverage warnings blocked this PR
 ```
 
 ## PR-Specific Note
 
-The Workspace V2 run exercised Object Vector Studio V2 rename, duplicate, save/load, schema validation, and Asteroids runtime Object Vector rendering with canonical object ids. Coverage remains advisory only.
+The Workspace V2 run exercised Asteroids Object Vector manifest loading, strict runtime binding validation, duplicate medium-candidate diagnostics, and gameplay rendering with manifest-selected object IDs. Coverage remains advisory only.

docs/dev/reports/playwright_workspace_v2_results.md

@@ -1,6 +1,6 @@
-# PR_26133_035 Workspace V2 Playwright Results
+# PR_26133_036 Workspace V2 Playwright Results
 
-Task: PR_26133_035-object-id-slug-normalization
+Task: PR_26133_036-asteroids-manifest-name-validation-no-fallback
 Date: 2026-05-15
 
 ## Result
@@ -14,18 +14,16 @@ PASS - `npm run test:workspace-v2` completed successfully.
 
 ## PR-Specific Coverage
 
-- Object Vector Studio V2 rename preview and commit flows were verified for normalized ids such as `object.asteroids.medium-asteroid`.
-- Collision numbering was verified as `object.asteroids.medium-asteroid-2`, with no `medium-asteroid-1` generated.
-- Duplicate Large Asteroid followed by rename to Medium Asteroid was verified to regenerate `object.asteroids.medium-asteroid-3`.
-- Workspace Manager V2 manifest load/save paths validated the canonical Asteroids object ids and rejected the older mixed `asteroid.*` / `ufo.*` forms from the active data.
-- Asteroids runtime rendering still loaded and rendered Object Vector runtime assets with the canonical ids.
+- Asteroids runtime loaded Object Vector Studio V2 assets from `games/Asteroids/game.manifest.json`.
+- Runtime binding diagnostics reported `runtimeBindingsValid: true`.
+- Runtime selected `object.asteroids.medium-asteroid` from manifest binding even with duplicate medium-tag candidates.
+- Object Vector Studio V2 continued to load/save 7 Asteroids object-vector objects.
+- No `BASE_VECTOR_MAP`, `ASTEROIDS_*_SVG`, or `vector.asteroids.*` runtime fallback references remain in Asteroids/runtime shared paths.
 
 ## Additional Validation
 
-PASS - Targeted Asteroids Asset Reference Adoption test.
-
 PASS - Targeted Asteroids Platform Demo test.
 
-PASS - Targeted Asteroids collision timing/stress checks.
+PASS - Targeted Asteroids Asset Reference Adoption test.
 
-PASS - Targeted Asteroids canonical Object Vector runtime validation loaded 7 objects and resolved large, medium, small asteroid, and small UFO roles by tags.
+PASS - Targeted manifest binding validation confirmed valid bindings pass, missing `asteroidMedium` fails, and invalid `asteroidMedium` tag binding fails.

games/Asteroids/game.manifest.json

@@ -815,7 +815,7 @@
             },
             {
               "id": "object.asteroids.medium-asteroid-2",
-              "name": "Medium Asteroid",
+              "name": "Medium Asteroid 2",
               "shapes": [
                 {
                   "tool": "polygon",
@@ -825,52 +825,32 @@
                   "geometry": {
                     "points": [
                       {
-                        "x": 10,
-                        "y": 40
-                      },
-                      {
-                        "x": 50,
-                        "y": 20
-                      },
-                      {
-                        "x": 45,
-                        "y": 5
-                      },
-                      {
-                        "x": 25,
+                        "x": -16,
                         "y": -10
                       },
                       {
-                        "x": 50,
-                        "y": -35
-                      },
-                      {
-                        "x": 30,
-                        "y": -45
-                      },
-                      {
-                        "x": 10,
-                        "y": -38
+                        "x": -2,
+                        "y": -18
                       },
                       {
-                        "x": -20,
-                        "y": -45
+                        "x": 16,
+                        "y": -14
                       },
                       {
-                        "x": -43,
-                        "y": -18
+                        "x": 20,
+                        "y": 2
                       },
                       {
-                        "x": -43,
-                        "y": 20
+                        "x": 8,
+                        "y": 18
                       },
                       {
-                        "x": -25,
-                        "y": 20
+                        "x": -10,
+                        "y": 16
                       },
                       {
-                        "x": -25,
-                        "y": 40
+                        "x": -20,
+                        "y": 4
                       }
                     ]
                   },
@@ -888,8 +868,8 @@
                     "scaleX": 1,
                     "scaleY": 1,
                     "origin": {
-                      "x": -1,
-                      "y": 1
+                      "x": 0,
+                      "y": 0
                     }
                   }
                 }
@@ -910,7 +890,7 @@
               ],
               "tags": [
                 "asteroid",
-                "large"
+                "medium"
               ]
             }
           ]

games/Asteroids/game/AsteroidsGameScene.js

@@ -16,7 +16,8 @@ import AsteroidsInitialsEntry from '../systems/AsteroidsInitialsEntry.js';
 import { createAsteroidGeometryProfilesFromObjectVectorAssets } from './asteroidObjectGeometry.js';
 import {
   ASTEROID_SIZE_RUNTIME_ROLES,
-  runtimeObjectRoleOptions
+  runtimeObjectRoleOptions,
+  validateAsteroidsRuntimeObjectBindings
 } from './asteroidsObjectVectorRoles.js';
 import {
   ASTEROIDS_GAME_OVER_AUTO_EXIT_SECONDS, ASTEROIDS_GAME_OVER_RETURN_MODE
@@ -50,6 +51,13 @@ const ATTRACT_INPUT_CODES = [
 let hasLoggedSceneConstruction = false;
 let hasLoggedSceneEnter = false;
 
+function validationFailureMessage(validation) {
+  const details = Array.isArray(validation?.errors)
+    ? validation.errors.map((entry) => entry.message).filter(Boolean).join(' ')
+    : '';
+  return `Asteroids Object Vector runtime manifest validation failed${details ? `: ${details}` : '.'}`;
+}
+
 function logSceneBootStage(stage, details = null) {
   if (details === null) {
     console.info(`Asteroids scene:${stage}`);
@@ -111,6 +119,19 @@ export default class AsteroidsGameScene extends Scene {
     this.objectVectorAssets = options.objectVectorAssets || null;
     this.objectVectorRuntime = options.objectVectorRuntime || null;
     this.objectVectorRuntimeBindings = this.objectVectorAssets?.runtimeBindings || {};
+    this.objectVectorRuntimeBindingValidation = this.objectVectorAssets
+      ? validateAsteroidsRuntimeObjectBindings([...this.objectVectorAssets.objectsById.values()], this.objectVectorRuntimeBindings, {
+        logger: this.objectVectorRuntime,
+      })
+      : { errors: [], objectsByRole: {}, ok: false, warnings: [] };
+    if (this.objectVectorAssets && !this.objectVectorRuntimeBindingValidation.ok) {
+      const message = validationFailureMessage(this.objectVectorRuntimeBindingValidation);
+      this.objectVectorRuntime?.log?.('FAIL', message, {
+        errors: this.objectVectorRuntimeBindingValidation.errors,
+      });
+      console.error(message);
+      throw new Error(message);
+    }
     this.asteroidGeometryProfiles = options.asteroidGeometryProfiles
       || createAsteroidGeometryProfilesFromObjectVectorAssets(this.objectVectorAssets, {
         logger: this.objectVectorRuntime,
@@ -886,6 +907,7 @@ export default class AsteroidsGameScene extends Scene {
         assetCount: this.objectVectorAssets?.objectsById?.size || 0,
         loaded: Boolean(this.objectVectorAssets),
         objectCount: this.objectVectorAssets?.objectsById?.size || 0,
+        runtimeBindingsValid: Boolean(this.objectVectorRuntimeBindingValidation?.ok),
         renderCounts: { ...this.objectVectorRenderCounts },
       };
     } catch {