Rename Session Inspector V2 State view to Tool Data and clarify JSON meaning - PR_26128_020-session-inspector-v2-tool-data-label

Author: DavidQ

docs/dev/reports/playwright_session_inspector_v2_state_view.md

@@ -0,0 +1,22 @@
+# Playwright Session Inspector V2 State View
+
+## Command
+`npm run test:workspace-v2`
+
+## Result
+- Passed: 15/15
+- Runtime: about 1.3 minutes
+
+## Targeted Coverage
+- Session Inspector V2 has no Schema section/control label.
+- State section/control is present.
+- JSON shows the selected storage entry's full stored object.
+- State shows only the selected normalized tool object's `state` section.
+- State shows an actionable empty-state message when no `state` section exists.
+- JSON and State accordions open and close predictably.
+- Controls, Filters, Entries, and Status accordions continue to open and close.
+- Workspace Manager V2 hydration remains normalized to `workspace.tools.<tool-id>`.
+- Old split `.schema` and `.state` per-tool keys are not recreated.
+
+## Skipped
+- Full samples smoke test was skipped by request. The changed behavior is covered by `tests/playwright/tools/WorkspaceManagerV2.spec.mjs`.

docs/dev/reports/session_inspector_v2_state_view.md

@@ -0,0 +1,37 @@
+# Session Inspector V2 State View
+
+## Scope
+- Removed the Session Inspector V2 Schema section/control.
+- Removed Session Inspector V2 user-facing Schema labels.
+- Added a State section/control.
+- Preserved the JSON section as the full selected storage object view.
+- Preserved normalized Workspace Manager V2 tool hydration keys:
+  - `workspace.tools.<tool-id>`
+- Did not recreate split `.schema` or `.state` per-tool session keys.
+
+## Implementation Notes
+- `StateControl` renders only the selected normalized tool object's top-level `state` section.
+- When a selected entry has no top-level `state`, State shows an actionable empty state naming the selected storage entry.
+- JSON still renders the full stored value for the selected tile.
+- JSON and State accordions use the existing Session Inspector V2 accordion pattern and were validated alongside Controls, Filters, Entries, and Status.
+- Per-tile Delete and Delete All behavior were preserved.
+
+## Guardrails
+- No cross-tool communication was added.
+- Preview Generator V2 image generation behavior was not modified.
+- Sample JSON was not modified.
+- Roadmap content was not modified.
+
+## Validation
+- Passed `npm run test:workspace-v2` with 15/15 tests.
+- Verified no Session Inspector V2 Schema control/label remains.
+- Verified State control appears.
+- Verified State shows only selected item `state`.
+- Verified JSON shows the full selected item object.
+- Verified JSON and State accordions open and close predictably.
+- Verified Controls, Filters, Entries, and Status accordions still work.
+- Verified normalized `workspace.tools.<tool-id>` keys remain.
+- Verified old split `.schema` and `.state` tool keys are not recreated.
+
+## Skipped
+- Full samples smoke test was skipped because this PR is limited to the Session Inspector V2 JSON/State view and normalized Workspace V2 session-key validation. The requested targeted Workspace V2 Playwright suite covers the affected behavior.

tests/playwright/tools/WorkspaceManagerV2.spec.mjs

@@ -431,7 +431,10 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator(".session-inspector-v2__json-accordion-header")).toContainText("JSON");
       await expect(page.locator(".session-inspector-v2__json-accordion-header")).not.toContainText("Details");
       await expect(page.locator(".session-inspector-v2__json-accordion-header #copySessionInspectorV2JsonButton")).toHaveText("Copy");
-      await expect(page.locator(".session-inspector-v2__schema-accordion-header")).toContainText("Schema");
+      await expect(page.locator(".session-inspector-v2__state-accordion-header")).toContainText("State");
+      await expect(page.locator(".session-inspector-v2__schema-accordion-header")).toHaveCount(0);
+      await expect(page.locator("#sessionInspectorV2SchemaOutput")).toHaveCount(0);
+      await expect(page.locator("body")).not.toContainText("Schema");
       expect(await page.locator(".session-inspector-v2__panel--left > .accordion-v2 > .accordion-v2__header > span:first-child").evaluateAll((labels) => labels.map((label) => label.textContent.trim()))).toEqual([
         "Controls",
         "Filters"
@@ -563,7 +566,7 @@ test.describe("Workspace Manager V2 bootstrap", () => {
         "sessionInspectorV2FiltersContent",
         "sessionInspectorV2EntriesContent",
         "sessionInspectorV2JsonContent",
-        "sessionInspectorV2SchemaContent",
+        "sessionInspectorV2StateContent",
         "sessionInspectorV2StatusContent"
       ]) {
         await expectSessionInspectorV2AccordionToggles(page, contentId);
@@ -620,7 +623,7 @@ test.describe("Workspace Manager V2 bootstrap", () => {
 
       await page.locator('[data-session-inspector-v2-entry-id="sessionStorage:session-inspector-v2-alpha"]').click();
       await expect(page.locator("#sessionInspectorV2JsonOutput")).toHaveText("true");
-      await expect(page.locator("#sessionInspectorV2SchemaOutput")).toContainText("No schema section is present for sessionStorage:session-inspector-v2-alpha.");
+      await expect(page.locator("#sessionInspectorV2StateOutput")).toContainText("No state section is present for sessionStorage:session-inspector-v2-alpha.");
       const copiedJsonText = await page.locator("#sessionInspectorV2JsonOutput").textContent();
       await page.locator("#copySessionInspectorV2JsonButton").click();
       await expect(page.locator("#statusLog")).toHaveValue(/OK Copied JSON content to clipboard\./);
@@ -651,7 +654,7 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#sessionInspectorV2EntryList [data-session-inspector-v2-entry-id]")).toHaveCount(0);
       await expect(page.locator("#sessionInspectorV2EntryList")).toContainText("No matching storage entries.");
       await expect(page.locator("#sessionInspectorV2JsonOutput")).toHaveText("{}");
-      await expect(page.locator("#sessionInspectorV2SchemaOutput")).toHaveText("Select a storage entry with a top-level schema section.");
+      await expect(page.locator("#sessionInspectorV2StateOutput")).toHaveText("Select a normalized tool entry with a top-level state section.");
       await expect(page.locator("#sessionInspectorV2Summary > span")).toHaveText([
         "(0) Entries shown.",
         "(0) SessionStorage.",
@@ -678,7 +681,7 @@ test.describe("Workspace Manager V2 bootstrap", () => {
     }
   });
 
-  test("shows normalized workspace tool sessions as JSON and Schema views", async ({ page }) => {
+  test("shows normalized workspace tool sessions as JSON and State views", async ({ page }) => {
     const pageErrors = [];
     await page.addInitScript(() => {
       window.sessionStorage.setItem("workspace.tools.preview-generator-v2", JSON.stringify({
@@ -711,10 +714,12 @@ test.describe("Workspace Manager V2 bootstrap", () => {
           payload: { assets: {} }
         }
       }));
-      window.sessionStorage.setItem("workspace.tools.no-schema-test", JSON.stringify({
-        state: {
+      window.sessionStorage.setItem("workspace.tools.no-state-test", JSON.stringify({
+        schema: {
           source: "workspace-manager-v2",
-          toolId: "no-schema-test"
+          toolId: "no-state-test",
+          schemaRole: "workspace-launch-context",
+          schemaRef: "tools/schemas/workspace.manifest.schema.json"
         }
       }));
     });
@@ -727,7 +732,10 @@ test.describe("Workspace Manager V2 bootstrap", () => {
     try {
       await expect(page.locator("#sessionInspectorV2EntryList [data-session-inspector-v2-entry-id]")).toHaveCount(3);
       await expect(page.locator(".session-inspector-v2__json-accordion-header")).toContainText("JSON");
-      await expect(page.locator(".session-inspector-v2__schema-accordion-header")).toContainText("Schema");
+      await expect(page.locator(".session-inspector-v2__state-accordion-header")).toContainText("State");
+      await expect(page.locator(".session-inspector-v2__schema-accordion-header")).toHaveCount(0);
+      await expect(page.locator("#sessionInspectorV2SchemaOutput")).toHaveCount(0);
+      await expect(page.locator("body")).not.toContainText("Schema");
       await expect(page.locator("#sessionInspectorV2EntryList [data-session-inspector-v2-entry-id='sessionStorage:workspace.tools.preview-generator-v2']")).toHaveCount(1);
       await expect(page.locator("#sessionInspectorV2EntryList [data-session-inspector-v2-entry-id='sessionStorage:workspace.tools.preview-generator-v2.schema']")).toHaveCount(0);
       await expect(page.locator("#sessionInspectorV2EntryList [data-session-inspector-v2-entry-id='sessionStorage:workspace.tools.preview-generator-v2.state']")).toHaveCount(0);
@@ -736,12 +744,13 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#sessionInspectorV2JsonOutput")).toContainText('"schema"');
       await expect(page.locator("#sessionInspectorV2JsonOutput")).toContainText('"state"');
       await expect(page.locator("#sessionInspectorV2JsonOutput")).toContainText('"repoReferenceKey": "workspace.repo.reference"');
-      await expect(page.locator("#sessionInspectorV2SchemaOutput")).toContainText('"schemaRef": "tools/schemas/workspace.manifest.schema.json"');
-      await expect(page.locator("#sessionInspectorV2SchemaOutput")).not.toContainText('"state"');
-      await expect(page.locator("#sessionInspectorV2SchemaOutput")).not.toContainText('"repoReferenceKey"');
+      await expect(page.locator("#sessionInspectorV2StateOutput")).toContainText('"repoReferenceKey": "workspace.repo.reference"');
+      await expect(page.locator("#sessionInspectorV2StateOutput")).toContainText('"gameRoot": "games/Asteroids/"');
+      await expect(page.locator("#sessionInspectorV2StateOutput")).not.toContainText('"schema"');
+      await expect(page.locator("#sessionInspectorV2StateOutput")).not.toContainText('"schemaRef"');
 
-      await page.locator('[data-session-inspector-v2-entry-id="sessionStorage:workspace.tools.no-schema-test"]').click();
-      await expect(page.locator("#sessionInspectorV2SchemaOutput")).toContainText("No schema section is present for sessionStorage:workspace.tools.no-schema-test.");
+      await page.locator('[data-session-inspector-v2-entry-id="sessionStorage:workspace.tools.no-state-test"]').click();
+      await expect(page.locator("#sessionInspectorV2StateOutput")).toContainText("No state section is present for sessionStorage:workspace.tools.no-state-test.");
 
       await page.locator('[data-session-inspector-v2-delete-entry-id="sessionStorage:workspace.tools.preview-generator-v2"]').click();
       await expect(page.locator("#sessionInspectorV2EntryList [data-session-inspector-v2-entry-id]")).toHaveCount(2);

tools/session-inspector-v2/README.md

@@ -13,5 +13,5 @@ Session Inspector V2 is a first-class tool for inspecting and clearing current-o
 - Seed a storage key in the current origin.
 - Refresh the tool and verify the key appears in the Entries list.
 - Select an entry and confirm the JSON panel shows the full stored value.
-- Select a normalized workspace tool entry and confirm the Schema panel shows only its schema section.
+- Select a normalized workspace tool entry and confirm the State panel shows only its state section.
 - Use per-entry Delete or Delete All and verify the Entries list and status log update immediately.

tools/session-inspector-v2/index.html

@@ -95,7 +95,7 @@ <h2 class="tools-platform-frame__eyebrow">Session storage visibility</h2>
         </section>
       </section>
 
-      <aside class="session-inspector-v2__panel session-inspector-v2__panel--right tool-shell-common__fullscreen-panel tool-shell-common__fullscreen-side-panel tool-shell-common__fullscreen-panel-right" aria-label="Session JSON and schema">
+      <aside class="session-inspector-v2__panel session-inspector-v2__panel--right tool-shell-common__fullscreen-panel tool-shell-common__fullscreen-side-panel tool-shell-common__fullscreen-panel-right" aria-label="Session JSON and state">
         <section class="accordion-v2 session-inspector-v2__accordion session-inspector-v2__accordion--fill is-open" data-accordion-v2-open="true">
           <div class="accordion-v2__header session-inspector-v2__json-accordion-header" role="button" tabindex="0" aria-expanded="true" aria-controls="sessionInspectorV2JsonContent">
             <span>JSON</span>
@@ -110,12 +110,12 @@ <h2 class="tools-platform-frame__eyebrow">Session storage visibility</h2>
         </section>
 
         <section class="accordion-v2 session-inspector-v2__accordion session-inspector-v2__accordion--fill is-open" data-accordion-v2-open="true">
-          <div class="accordion-v2__header session-inspector-v2__schema-accordion-header" role="button" tabindex="0" aria-expanded="true" aria-controls="sessionInspectorV2SchemaContent">
-            <span>Schema</span>
+          <div class="accordion-v2__header session-inspector-v2__state-accordion-header" role="button" tabindex="0" aria-expanded="true" aria-controls="sessionInspectorV2StateContent">
+            <span>State</span>
             <span class="accordion-v2__icon" aria-hidden="true">+</span>
           </div>
-          <div id="sessionInspectorV2SchemaContent" class="accordion-v2__content">
-            <pre id="sessionInspectorV2SchemaOutput" class="session-inspector-v2__output">Select a storage entry with a top-level schema section.</pre>
+          <div id="sessionInspectorV2StateContent" class="accordion-v2__content">
+            <pre id="sessionInspectorV2StateOutput" class="session-inspector-v2__output">Select a normalized tool entry with a top-level state section.</pre>
           </div>
         </section>
 

tools/session-inspector-v2/js/SessionInspectorV2App.js

@@ -9,7 +9,7 @@ export class SessionInspectorV2App {
     refreshButton,
     returnToWorkspaceButton,
     runtimeContract,
-    schema,
+    state,
     statusLog,
     storageService,
     windowRef = window
@@ -24,7 +24,7 @@ export class SessionInspectorV2App {
     this.refreshButton = refreshButton;
     this.returnToWorkspaceButton = returnToWorkspaceButton;
     this.runtimeContract = runtimeContract || { storageAccess: "read-only" };
-    this.schema = schema;
+    this.state = state;
     this.statusLog = statusLog;
     this.storageService = storageService;
     this.selectedId = "";
@@ -66,7 +66,7 @@ export class SessionInspectorV2App {
     this.entryList.render(this.entries, this.selectedId);
     const selectedEntry = this.entries.find((entry) => entry.id === this.selectedId);
     this.json.render(selectedEntry);
-    this.schema.render(selectedEntry);
+    this.state.render(selectedEntry);
     this.filters.setSummary(this.summaryCounts());
     if (!silent) {
       this.statusLog.ok(`Loaded ${this.entries.length} matching storage entries.`);
@@ -85,7 +85,7 @@ export class SessionInspectorV2App {
     this.entryList.render(this.entries, this.selectedId);
     const entry = this.entries.find((candidate) => candidate.id === entryId);
     this.json.render(entry);
-    this.schema.render(entry);
+    this.state.render(entry);
     if (entry) {
       this.statusLog.info(`Selected ${entry.storageType}:${entry.key}.`);
     }

tools/session-inspector-v2/js/bootstrap.js

@@ -3,7 +3,7 @@ import { AccordionSection } from "./controls/AccordionSection.js";
 import { EntryListControl } from "./controls/EntryListControl.js";
 import { FilterControl } from "./controls/FilterControl.js";
 import { JsonControl } from "./controls/JsonControl.js";
-import { SchemaControl } from "./controls/SchemaControl.js";
+import { StateControl } from "./controls/StateControl.js";
 import { StatusLogControl } from "./controls/StatusLogControl.js";
 import { sessionInspectorV2RuntimeContract } from "./services/SessionInspectorV2RuntimeContract.js";
 import { SessionInspectorV2StorageService } from "./services/SessionInspectorV2StorageService.js";
@@ -35,8 +35,8 @@ window.addEventListener("DOMContentLoaded", () => {
     refreshButton: requireElement("#refreshSessionInspectorV2Button"),
     returnToWorkspaceButton: requireElement("#returnToWorkspaceButton"),
     runtimeContract: sessionInspectorV2RuntimeContract(),
-    schema: new SchemaControl({
-      output: requireElement("#sessionInspectorV2SchemaOutput")
+    state: new StateControl({
+      output: requireElement("#sessionInspectorV2StateOutput")
     }),
     statusLog: new StatusLogControl({
       clearButton: requireElement("#clearSessionInspectorV2StatusButton"),

tools/session-inspector-v2/js/controls/SchemaControl.js

@@ -0,0 +1,22 @@
+export class StateControl {
+  constructor({ output }) {
+    this.output = output;
+  }
+
+  clear() {
+    this.output.textContent = "Select a normalized tool entry with a top-level state section.";
+  }
+
+  render(entry) {
+    if (!entry) {
+      this.clear();
+      return;
+    }
+    const value = entry.parseOk ? entry.parsedValue : null;
+    if (!value || typeof value !== "object" || Array.isArray(value) || !Object.prototype.hasOwnProperty.call(value, "state")) {
+      this.output.textContent = `No state section is present for ${entry.storageType}:${entry.key}. Select a normalized tool entry with a top-level state section.`;
+      return;
+    }
+    this.output.textContent = JSON.stringify(value.state, null, 2);
+  }
+}