Remove hidden Object Vector Studio zoom scale multiplier - PR_26140_050-remove-vector-hidden-zoom-scale

Author: DavidQ

docs/dev/reports/PR_26140_050-remove-vector-hidden-zoom-scale_report.md

@@ -0,0 +1,25 @@
+# PR_26140_050-remove-vector-hidden-zoom-scale
+
+## Summary
+- Removed Object Vector Studio V2 hidden VIEWPORT_ZOOM_VIEWBOX_SCALE/viewBoxZoom multiplier.
+- Made viewport.zoom 1.0 map directly to 100% by moving the current visual scale into DEFAULT_VIEWPORT dimensions: 3200x2200.
+- Preserved the PR_26140_049 initial visual geometry size, pan behavior, reset viewBox, wheel zoom, pointer mapping, and hit-test interactions.
+- Left Collision Inspector V2 percent zoom behavior unchanged.
+
+## Validation
+- PASS: node --check tools/object-vector-studio-v2/js/ToolStarterApp.js.
+- PASS: node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs.
+- PASS: node --check tests/playwright/tools/CollisionInspectorV2.spec.mjs.
+- PASS: targeted ES module import validation for Object Vector Studio V2 and Collision Inspector V2 modules.
+- PASS: targeted static zoom validation confirmed no VIEWPORT_ZOOM_VIEWBOX_SCALE/viewBoxZoom remains, Object Vector Studio V2 default zoom is 100%, range remains 10% to 1000%, and Collision Inspector V2 remains percent-based.
+- PASS: npx playwright test tests/playwright/tools/CollisionInspectorV2.spec.mjs --project=playwright --workers=1 --reporter=list, 4 passed.
+- PASS: npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list --grep "shows Object Vector Studio V2 layout shell|creates Object Vector Studio V2 shapes with canvas drawing|edits Object Vector Studio V2 preview shapes|aligns Object Vector Studio V2 selection bounds|expands Object Vector Studio V2 asset authoring controls|drags selected Object Vector Studio V2 shapes|tracks Object Vector Studio V2 dirty state", 7 passed after serial rerun.
+- PASS: npm run test:workspace-v2, 58 passed.
+- PASS: git diff --check.
+- PASS: V8 coverage guardrail lists tools/object-vector-studio-v2/js/ToolStarterApp.js at 94% function coverage and no changed-runtime warnings.
+- PASS: no games, samples, or start_of_day files changed.
+- SKIPPED: full samples smoke test, per request.
+
+## Notes
+- A first focused OVS subset run was invalidated by a Playwright artifact-file race after running two Playwright commands concurrently; the same focused subset passed when rerun serially.
+- No sample JSON files were touched.

tests/playwright/tools/WorkspaceManagerV2.spec.mjs

@@ -105,16 +105,13 @@ function displayAbsoluteOutputPath(server, relativePath) {
 
 async function objectVectorLogicalClientPoint(page, x, y) {
   return page.locator("#objectVectorStudioV2RenderSurface").evaluate((surface, point) => {
-    const app = window.__objectVectorStudioV2App;
     const bounds = surface.getBoundingClientRect();
-    const viewBoxZoom = app.viewBoxZoom();
-    const viewWidth = 320 / viewBoxZoom;
-    const viewHeight = 220 / viewBoxZoom;
+    const [viewX, viewY, viewWidth, viewHeight] = surface.getAttribute("viewBox").split(/\s+/).map(Number);
     const drawingX = point.x * 10;
     const drawingY = point.y * 10;
     return {
-      x: bounds.left + ((drawingX - app.viewport.x + viewWidth / 2) / viewWidth) * bounds.width,
-      y: bounds.top + ((drawingY - app.viewport.y + viewHeight / 2) / viewHeight) * bounds.height
+      x: bounds.left + ((drawingX - viewX) / viewWidth) * bounds.width,
+      y: bounds.top + ((drawingY - viewY) / viewHeight) * bounds.height
     };
   }, { x, y });
 }
@@ -3436,8 +3433,9 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#statusLog")).toHaveValue(/OK Tools mode selected from keyboard: select\./);
 
       const zoomSource = await readFile("tools/object-vector-studio-v2/js/ToolStarterApp.js", "utf8");
-      expect(zoomSource).toContain("const DEFAULT_VIEWPORT = Object.freeze({ height: 220, width: 320, x: 0, y: 0, zoom: 1.0 });");
-      expect(zoomSource).toContain("const VIEWPORT_ZOOM_VIEWBOX_SCALE = 0.1;");
+      expect(zoomSource).toContain("const DEFAULT_VIEWPORT = Object.freeze({ height: 2200, width: 3200, x: 0, y: 0, zoom: 1.0 });");
+      expect(zoomSource).not.toContain("VIEWPORT_ZOOM_VIEWBOX_SCALE");
+      expect(zoomSource).not.toContain("viewBoxZoom");
       expect(zoomSource).toContain("const MAX_ZOOM = 10.0;");
       expect(zoomSource).toContain("const MIN_ZOOM = 0.1;");
       expect(zoomSource).toContain("const ZOOM_STEP = 0.1;");

tools/object-vector-studio-v2/js/ToolStarterApp.js

@@ -27,8 +27,7 @@ const ANGLE_SNAP_STEP_SESSION_KEY = "object-vector-studio-v2.angleSnapStep";
 const GRID_RENDER_SESSION_KEY = "object-vector-studio-v2.gridRender";
 const CENTER_ORIGIN_SESSION_KEY = "object-vector-studio-v2.centerOrigin";
 const SVG_NS = "http://www.w3.org/2000/svg";
-const DEFAULT_VIEWPORT = Object.freeze({ height: 220, width: 320, x: 0, y: 0, zoom: 1.0 });
-const VIEWPORT_ZOOM_VIEWBOX_SCALE = 0.1;
+const DEFAULT_VIEWPORT = Object.freeze({ height: 2200, width: 3200, x: 0, y: 0, zoom: 1.0 });
 const GRID_STEP = 10;
 const OBJECT_PREVIEW_DRAWING_SCALE = GRID_STEP;
 const MAX_ZOOM = 10.0;
@@ -3348,8 +3347,8 @@ export class ToolStarterApp {
     if (!this.gridRenderEnabled) {
       return;
     }
-    const width = DEFAULT_VIEWPORT.width / this.viewBoxZoom();
-    const height = DEFAULT_VIEWPORT.height / this.viewBoxZoom();
+    const width = DEFAULT_VIEWPORT.width / this.viewport.zoom;
+    const height = DEFAULT_VIEWPORT.height / this.viewport.zoom;
     const minX = this.viewport.x - width / 2;
     const maxX = this.viewport.x + width / 2;
     const minY = this.viewport.y - height / 2;
@@ -3599,8 +3598,8 @@ export class ToolStarterApp {
     if (!bounds.width || !bounds.height) {
       return null;
     }
-    const viewWidth = DEFAULT_VIEWPORT.width / this.viewBoxZoom();
-    const viewHeight = DEFAULT_VIEWPORT.height / this.viewBoxZoom();
+    const viewWidth = DEFAULT_VIEWPORT.width / this.viewport.zoom;
+    const viewHeight = DEFAULT_VIEWPORT.height / this.viewport.zoom;
     const drawingX = point.x * OBJECT_PREVIEW_DRAWING_SCALE;
     const drawingY = point.y * OBJECT_PREVIEW_DRAWING_SCALE;
     return {
@@ -4542,8 +4541,8 @@ export class ToolStarterApp {
   }
 
   updateViewport() {
-    const width = DEFAULT_VIEWPORT.width / this.viewBoxZoom();
-    const height = DEFAULT_VIEWPORT.height / this.viewBoxZoom();
+    const width = DEFAULT_VIEWPORT.width / this.viewport.zoom;
+    const height = DEFAULT_VIEWPORT.height / this.viewport.zoom;
     const viewX = this.formatViewportNumber(this.viewport.x - width / 2);
     const viewY = this.formatViewportNumber(this.viewport.y - height / 2);
     this.elements.renderSurface.setAttribute("viewBox", `${viewX} ${viewY} ${this.formatViewportNumber(width)} ${this.formatViewportNumber(height)}`);
@@ -4580,10 +4579,6 @@ export class ToolStarterApp {
     return Math.round(this.viewport.zoom * 100);
   }
 
-  viewBoxZoom(zoom = this.viewport.zoom) {
-    return zoom * VIEWPORT_ZOOM_VIEWBOX_SCALE;
-  }
-
   zoomViewportByStep(step) {
     const nextZoom = Number((this.viewport.zoom + step).toFixed(3));
     this.zoomViewport(nextZoom);
@@ -4616,9 +4611,8 @@ export class ToolStarterApp {
       return;
     }
     const zoom = this.clampedViewportZoom(nextZoom);
-    const viewBoxZoom = this.viewBoxZoom(zoom);
-    const viewWidth = DEFAULT_VIEWPORT.width / viewBoxZoom;
-    const viewHeight = DEFAULT_VIEWPORT.height / viewBoxZoom;
+    const viewWidth = DEFAULT_VIEWPORT.width / zoom;
+    const viewHeight = DEFAULT_VIEWPORT.height / zoom;
     this.viewport.zoom = zoom;
     this.viewport.x = Number((anchor.x - (anchor.ratioX - 0.5) * viewWidth).toFixed(6));
     this.viewport.y = Number((anchor.y - (anchor.ratioY - 0.5) * viewHeight).toFixed(6));
@@ -4672,9 +4666,8 @@ export class ToolStarterApp {
     }
     const ratioX = (clientX - bounds.left) / bounds.width;
     const ratioY = (clientY - bounds.top) / bounds.height;
-    const viewBoxZoom = this.viewBoxZoom(zoom);
-    const viewWidth = DEFAULT_VIEWPORT.width / viewBoxZoom;
-    const viewHeight = DEFAULT_VIEWPORT.height / viewBoxZoom;
+    const viewWidth = DEFAULT_VIEWPORT.width / zoom;
+    const viewHeight = DEFAULT_VIEWPORT.height / zoom;
     return {
       ratioX,
       ratioY,