Skip to content

Commit c847c00

Browse files
author
DavidQ
committed
Samples: runtime harness fix (phase-XX support)
1 parent c641b0f commit c847c00

6 files changed

Lines changed: 44 additions & 22 deletions

docs/dev/CODEX_COMMANDS.md

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,19 @@
11
MODEL: GPT-5.4
2-
REASONING: high
2+
REASONING: low
33

44
COMMAND:
5-
Implement BUILD_PR_LEVEL_6_4_SAMPLE_RUNTIME_VALIDATION.
5+
Implement BUILD_PR_LEVEL_6_4_RUNTIME_VALIDATION_PLUS_HARNESS_FIX.
66

7-
Scope:
8-
- samples runtime only
7+
Change:
8+
In tests/runtime/LaunchSmokeAllEntries.test.mjs
99

10-
Steps:
11-
1. Load each sample.
12-
2. Verify no runtime errors.
13-
3. Confirm render loop executes.
14-
4. Confirm no blocking console errors.
15-
5. Fix only path/runtime issues if required (no refactors).
10+
Replace:
11+
^phase\d{2}$
1612

17-
Validation:
18-
- all samples run
19-
- no crashes
20-
- navigation intact
13+
With:
14+
^phase-?\d{2}$
2115

22-
Output:
23-
<project folder>/tmp/BUILD_PR_LEVEL_6_4_SAMPLE_RUNTIME_VALIDATION.zip
16+
Do not modify anything else.
17+
18+
Return ZIP:
19+
<project folder>/tmp/BUILD_PR_LEVEL_6_4_RUNTIME_VALIDATION_PLUS_HARNESS_FIX.zip

docs/dev/COMMIT_COMMENT.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Samples: runtime validation
1+
Samples: runtime harness fix (phase-XX support)
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Validated runtime execution of all samples.
1+
Added regex fix so launch-smoke discovers phase-XX samples.
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
[ ] all samples load
2-
[ ] no crashes
3-
[ ] console clean
1+
[ ] regex updated
2+
[ ] samples discovered
3+
[ ] smoke passes
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# BUILD PR — Level 6.4 Runtime Validation + Harness Fix
2+
3+
## Purpose
4+
Complete runtime validation by aligning launch-smoke harness with phase-XX structure.
5+
6+
## Scope
7+
- samples runtime
8+
- tests/runtime/LaunchSmokeAllEntries.test.mjs (single-line fix)
9+
10+
## Changes
11+
- update phase detection regex:
12+
from: /^phase\d{2}$/
13+
to: /^phase-?\d{2}$/
14+
15+
## Constraints
16+
- no refactor
17+
- no expansion
18+
- one-line change only
19+
20+
## Validation
21+
- samples discovered correctly
22+
- launch-smoke runs against phase-XX
23+
- no regression
24+
25+
## Output
26+
<project folder>/tmp/BUILD_PR_LEVEL_6_4_RUNTIME_VALIDATION_PLUS_HARNESS_FIX.zip

tests/runtime/LaunchSmokeAllEntries.test.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ function discoverSamples(range) {
148148
if (!fs.existsSync(baseDir)) return results;
149149

150150
for (const phaseEntry of fs.readdirSync(baseDir, { withFileTypes: true })) {
151-
if (!phaseEntry.isDirectory() || !/^phase\d{2}$/.test(phaseEntry.name)) continue;
151+
if (!phaseEntry.isDirectory() || !/^phase-?\d{2}$/.test(phaseEntry.name)) continue;
152152
const phaseDir = path.join(baseDir, phaseEntry.name);
153153

154154
for (const sampleEntry of fs.readdirSync(phaseDir, { withFileTypes: true })) {

0 commit comments

Comments
 (0)