Audit remaining Asteroids direct draw paths after manifest object render cleanup - PR_26133_128-asteroids-effect-render-path-audit

Author: DavidQ

docs/dev/reports/PR_26133_128-asteroids-effect-render-path-audit_report.md

@@ -0,0 +1,48 @@
+# PR_26133_128 Asteroids Effect Render Path Audit
+
+## Summary
+- Audited the direct renderer draws left after PR_26133_127.
+- Kept UI/effect draws out of Object Vector Studio V2 when they are not persistent object geometry.
+- Removed the remaining hardcoded object-like effect geometry: ship debris fragments now derive their segment geometry from the manifest-owned ship hull points already loaded by `AsteroidsWorld`.
+- Did not change ship flame flicker, asteroid scale tuning, manifest object geometry, or vector map fallback behavior.
+
+## Direct Draw Classification
+
+| Path | Classification | Decision |
+| --- | --- | --- |
+| Starfield background pixels | Allowed non-object effect/UI draw; intentional runtime effect | Stays as the custom background callback. Stars are procedural background pixels, not Object Vector Studio V2 objects. |
+| HUD/menu text | Allowed non-object effect/UI draw | Stays as renderer text. Scores, labels, and prompts are UI text, not game object geometry. |
+| Attract text panels | Allowed non-object effect/UI draw | Stays as translucent UI panel rectangles. They frame text and are not authored gameplay objects. |
+| Demo trail pixels | Documented as intentional runtime effect | Stays as procedural 2x2 trail pixels tied to demo motion and fade timing. |
+| Pause/initials overlays | Allowed non-object effect/UI draw | Stays as modal UI rectangles/text/strokes. They are interface state, not manifest object geometry. |
+| Particle effects | Documented as intentional runtime effect | Stays in the generic particle system. Explosion particles are transient circles/rects with randomized size, velocity, and fade. |
+| Ship debris fragments | Should use manifest object geometry source; documented as intentional runtime effect | Updated. Debris remains a direct draw effect because fragments need independent velocity/spin/fade, but its hull segments now come from manifest-derived ship geometry instead of a second hardcoded ship shape. |
+
+## Code Changes
+- `games/Asteroids/systems/ShipDebrisSystem.js`
+  - Removed the hardcoded `SHIP_SEGMENTS` ship outline.
+  - Builds debris segments from injected ship geometry points.
+  - Fails visibly/actionably if debris spawn is attempted without manifest-derived hull segments.
+- `games/Asteroids/game/AsteroidsGameScene.js`
+  - Passes `this.world.shipCollisionPoints` into `ShipDebrisSystem`; those points are loaded from the Asteroids Object Vector Studio V2 manifest.
+- `tests/games/AsteroidsPresentation.test.mjs`
+  - Added targeted coverage proving ship debris uses the current manifest-owned scaled ship hull points.
+
+## Validation
+- PASS: targeted Asteroids node validation:
+  - `AsteroidsValidation`
+  - `AsteroidsPresentation`
+  - `AsteroidsVectorTransforms`
+  - `AsteroidsPlatformDemo`
+  - `AsteroidsAssetReferenceAdoption`
+- PASS: targeted Workspace Manager V2/Asteroids Playwright validation:
+  - `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list -g "loads Object Vector Studio V2 runtime assets into Asteroids gameplay rendering"`
+- PASS: `git diff --check`
+- Playwright impacted: Yes. This PR changes an Asteroids runtime effect path and validates launch, attract/demo, gameplay manifest rendering, and bullet/object rendering through the targeted browser slice.
+- Full samples smoke test skipped as requested; this PR only touches Asteroids effect render-path audit/cleanup.
+
+## Manual Validation
+- Open `/games/Asteroids/index.html`.
+- Start gameplay and destroy the ship; expected: debris fragments appear as the same runtime destruction effect, using the manifest-owned ship hull shape as the segment source.
+- Let attract/demo run; expected: attract/demo objects still render from manifest Object Vector Studio V2 objects.
+- Fire bullets at multiple ship angles; expected: bullet geometry/style remains manifest-owned and bullet rotation follows firing direction.

games/Asteroids/game/AsteroidsGameScene.js

@@ -143,7 +143,10 @@ export default class AsteroidsGameScene extends Scene {
     );
     this.gameOverAutoExitRemainingSeconds = 0;
     this.audio = new AsteroidsAudio();
-    this.shipDebris = new ShipDebrisSystem({ rng: this.world.rng });
+    this.shipDebris = new ShipDebrisSystem({
+      rng: this.world.rng,
+      shipGeometryPoints: this.world.shipCollisionPoints,
+    });
     this.particles = new ParticleSystem();
     this.lastEnterPressed = false;
     this.lastOnePressed = false;

games/Asteroids/systems/ShipDebrisSystem.js

@@ -6,15 +6,29 @@ ShipDebrisSystem.js
 */
 import { randomRange } from '../utils/math.js';
 
-const SHIP_SEGMENTS = [
-  [[14, 0], [-10, -8]],
-  [[-10, -8], [-6, -3]],
-  [[-6, -3], [-6, 3]],
-  [[-6, 3], [-10, 8]],
-  [[-10, 8], [14, 0]],
-];
+function normalizePoints(points) {
+  return Array.isArray(points)
+    ? points.map((point) => ({
+      x: Number(point?.x ?? 0),
+      y: Number(point?.y ?? 0),
+    })).filter((point) => Number.isFinite(point.x) && Number.isFinite(point.y))
+    : [];
+}
+
+function createShipSegments(points) {
+  const normalized = normalizePoints(points);
+  return normalized.slice(0, -1).map((start, index) => ({
+    end: normalized[index + 1],
+    start,
+  })).filter((segment) => (
+    segment.start.x !== segment.end.x
+    || segment.start.y !== segment.end.y
+  ));
+}
 
-function rotatePoint([x, y], angle) {
+function rotatePoint(point, angle) {
+  const x = Number(point?.x ?? 0);
+  const y = Number(point?.y ?? 0);
   return {
     x: x * Math.cos(angle) - y * Math.sin(angle),
     y: x * Math.sin(angle) + y * Math.cos(angle),
@@ -27,15 +41,20 @@ function whiteWithAlpha(alpha) {
 }
 
 export default class ShipDebrisSystem {
-  constructor({ rng = Math.random } = {}) {
+  constructor({ rng = Math.random, shipGeometryPoints = [] } = {}) {
     this.fragments = [];
     this.rng = typeof rng === 'function' ? rng : Math.random;
+    this.shipSegments = createShipSegments(shipGeometryPoints);
   }
 
   spawn({ x, y, angle = -Math.PI / 2, vx = 0, vy = 0, lifeSeconds = 3 }) {
-    SHIP_SEGMENTS.forEach((segment, index) => {
-      const start = rotatePoint(segment[0], angle);
-      const end = rotatePoint(segment[1], angle);
+    if (!this.shipSegments.length) {
+      console.error('FAIL Asteroids ship debris render blocked: manifest ship geometry did not provide debris hull segments.');
+      return false;
+    }
+    this.shipSegments.forEach((segment, index) => {
+      const start = rotatePoint(segment.start, angle);
+      const end = rotatePoint(segment.end, angle);
       const burstAngle = angle + (-0.9 + index * 0.45);
       const speed = 90 + index * 26;
       this.fragments.push({
@@ -51,6 +70,7 @@ export default class ShipDebrisSystem {
         end,
       });
     });
+    return true;
   }
 
   clear() {
@@ -74,8 +94,8 @@ export default class ShipDebrisSystem {
 
   render(renderer) {
     this.fragments.forEach((fragment) => {
-      const start = rotatePoint([fragment.start.x, fragment.start.y], fragment.angle);
-      const end = rotatePoint([fragment.end.x, fragment.end.y], fragment.angle);
+      const start = rotatePoint(fragment.start, fragment.angle);
+      const end = rotatePoint(fragment.end, fragment.angle);
       const lifeRatio = fragment.maxLifeSeconds > 0
         ? fragment.lifeSeconds / fragment.maxLifeSeconds
         : 0;

tests/games/AsteroidsPresentation.test.mjs

@@ -315,6 +315,23 @@ function testAsteroidsGameplayObjectsUseSharedManifestBindings() {
   assert.equal(smallUfoCalls.every((call) => call.requireManifestBinding), true);
 }
 
+function testAsteroidsShipDebrisUsesManifestShipHullGeometry() {
+  const scene = new AsteroidsGameScene(createAsteroidsTestSceneOptions({
+    objectVectorAssets: createObjectVectorAssetSet(),
+    objectVectorRuntime: createObjectVectorRuntime([]),
+  }));
+  const spawned = scene.shipDebris.spawn({
+    angle: 0,
+    lifeSeconds: 1,
+    x: 0,
+    y: 0,
+  });
+  assert.equal(spawned, true);
+  assert.equal(scene.shipDebris.fragments.length, 5);
+  assert.deepEqual(scene.shipDebris.fragments[0].start, { x: 15.4, y: 0 });
+  assert.deepEqual(scene.shipDebris.fragments[0].end, { x: -11, y: -8.8 });
+}
+
 function testAsteroidsGameplayBulletsUseManifestObjectGeometry() {
   const renderCalls = [];
   const payload = loadAsteroidsObjectVectorPayload();
@@ -420,6 +437,7 @@ export function run() {
   testAsteroidsMenuHighScoreUsesLeaderboardTop();
   testAsteroidsAttractAsteroidsUseManifestObjectsAndStyles();
   testAsteroidsGameplayObjectsUseSharedManifestBindings();
+  testAsteroidsShipDebrisUsesManifestShipHullGeometry();
   testAsteroidsGameplayBulletsUseManifestObjectGeometry();
   testAsteroidsGameplayRenderDoesNotCoverBackgroundLayer();
 }