Skip to content

Commit be0c7c6

Browse files
author
DavidQ
committed
Move tool Playwright specs under tools tests and enforce session-based production launch - PR_26126_110-playwright-tools-directory-and-workspace-prod-guard
1 parent 26964a7 commit be0c7c6

10 files changed

Lines changed: 4549 additions & 66 deletions
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# PR_26126_110 Manual Validation Notes
2+
3+
## Commands
4+
- `node -e "JSON.parse(require('fs').readFileSync('package.json','utf8')); console.log('package.json ok')"`
5+
- `node --check tests\playwright\tools\AssetManagerV2.spec.mjs`
6+
- `node --check tests\playwright\tools\PreviewGeneratorV2Baseline.spec.mjs`
7+
- `npm run test:asset-manager-v2`
8+
- `npm run test:preview-generator-v2`
9+
- `npm run test:workspace-v2`
10+
- `git diff --check`
11+
12+
## Results
13+
- `package.json` parses successfully after script path updates.
14+
- Asset Manager V2 and Preview Generator V2 moved specs pass JavaScript syntax checks.
15+
- `npm run test:asset-manager-v2` passed 7/7 Playwright tests.
16+
- `npm run test:preview-generator-v2` passed 7/7 Playwright tests.
17+
- `npm run test:workspace-v2` passed 14/14 Playwright tests.
18+
- `?workspace=prod` hard-fails to the Asset Manager V2 launch guard overlay.
19+
- Valid Workspace Manager session launch remains the production access path.
20+
- Full samples smoke test skipped: this PR changes tool Playwright spec locations, npm script paths, and launch-guard test coverage only.
21+
- No sample JSON was modified.
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# PR_26126_110 Test Directory SSoT Notes
2+
3+
## Tool Spec Location
4+
- Moved Asset Manager V2 Playwright coverage to `tests/playwright/tools/AssetManagerV2.spec.mjs`.
5+
- Moved Preview Generator V2 Playwright coverage to `tests/playwright/tools/PreviewGeneratorV2Baseline.spec.mjs`.
6+
- Updated both moved specs to import helpers from `../../helpers/...`.
7+
8+
## Script Ownership
9+
- `test:asset-manager-v2` now targets `tests/playwright/tools/AssetManagerV2.spec.mjs`.
10+
- `test:preview-generator-v2` now targets `tests/playwright/tools/PreviewGeneratorV2Baseline.spec.mjs`.
11+
- `test:workspace-v2` remains the aggregate Workspace V2/tool completion gate and includes both tools-directory specs in one Playwright run.
12+
13+
## Scope
14+
- No Asset Manager V2 runtime behavior changed for the test move.
15+
- No Preview Generator V2 runtime behavior changed.
16+
- No sample JSON was modified.
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# PR_26126_110 Workspace Launch Guard Notes
2+
3+
## Production Access
4+
- Asset Manager V2 production access remains session/context based through Workspace Manager.
5+
- The valid Workspace Manager session path is still covered by the Asset Manager V2 Playwright suite.
6+
- Direct `tools/asset-manager-v2/index.html?workspace=prod` launch is treated as invalid.
7+
8+
## Temporary Access
9+
- `?workspace=UAT` remains the only temporary URL-based Asset Manager V2 access path.
10+
- The UAT path remains covered by the Asset Manager V2 Playwright suite.
11+
12+
## Validation
13+
- Playwright validates `?workspace=prod` hard-fails to the launch guard overlay with `Temporary workspace prod is not supported.`
14+
- Playwright validates valid Workspace Manager launch still opens Asset Manager V2 through session-backed context.
15+
- No sample JSON was modified.

docs/dev/reports/codex_changed_files.txt

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,24 @@
22
M docs/dev/reports/coverage_changed_js_guardrail.txt
33
M docs/dev/reports/playwright_v8_coverage_report.txt
44
M package.json
5-
?? docs/dev/reports/PR_26126_109_manual_validation_notes.md
6-
?? docs/dev/reports/PR_26126_109_test_script_ssot_notes.md
5+
D tests/playwright/AssetManagerV2.spec.mjs
6+
D tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
7+
?? docs/dev/reports/PR_26126_110_manual_validation_notes.md
8+
?? docs/dev/reports/PR_26126_110_test_directory_ssot_notes.md
9+
?? docs/dev/reports/PR_26126_110_workspace_launch_guard_notes.md
10+
?? tests/playwright/tools/
711

812
# git ls-files --others --exclude-standard
9-
docs/dev/reports/PR_26126_109_manual_validation_notes.md
10-
docs/dev/reports/PR_26126_109_test_script_ssot_notes.md
13+
docs/dev/reports/PR_26126_110_manual_validation_notes.md
14+
docs/dev/reports/PR_26126_110_test_directory_ssot_notes.md
15+
docs/dev/reports/PR_26126_110_workspace_launch_guard_notes.md
16+
tests/playwright/tools/AssetManagerV2.spec.mjs
17+
tests/playwright/tools/PreviewGeneratorV2Baseline.spec.mjs
1118

1219
# git diff --stat
13-
docs/dev/reports/coverage_changed_js_guardrail.txt | 1 -
14-
docs/dev/reports/playwright_v8_coverage_report.txt | 3 ---
15-
package.json | 4 +++-
16-
3 files changed, 3 insertions(+), 5 deletions(-)
20+
docs/dev/reports/coverage_changed_js_guardrail.txt | 4 +-
21+
docs/dev/reports/playwright_v8_coverage_report.txt | 7 +-
22+
package.json | 6 +-
23+
tests/playwright/AssetManagerV2.spec.mjs | 1435 --------------------
24+
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 747 ----------
25+
5 files changed, 9 insertions(+), 2190 deletions(-)

0 commit comments

Comments
 (0)