Complete Asset Manager V2 single picker flow - PR_26126_084

Author: DavidQ

docs/dev/PLAN_PR.md

@@ -18,7 +18,8 @@ tools/
     workspace.manifest.schema.json
     tool.manifest.schema.json
     palette.schema.json
-    sample.tool-payload.schema.json
+    samples/
+      sample.tool-payload.schema.json
     tools/
       vector-map-editor.schema.json
       vector-asset-studio.schema.json

docs/dev/reports/PR_26126_084_asset_manager_v2_manual_validation_notes.md

@@ -7,26 +7,29 @@ Date: 2026-05-06
 - Ran `npm run test:workspace-v2`.
 - Confirmed Asset Manager V2 tool mode launch through the Playwright workspace-v2 suite.
 - Confirmed Asset Manager V2 Workspace V2 launch mode through the Playwright workspace-v2 suite.
-- Confirmed picker accept filters for image, audio, font, video, shader, data, and localization file inputs.
-- Confirmed selected-file schema validation, schema rejection, role validation, and Workspace V2 insertion through Playwright.
+- Confirmed the old per-kind file inputs are absent and the single `Pick Asset File` control is present.
+- Confirmed kind derivation from selected file extension/MIME type for image and audio files.
+- Confirmed role selection is required before Add and restricted to the approved kind's roles.
+- Confirmed asset ID assignment includes approved kind, filename slug, and role.
+- Confirmed project-root path normalization for selected open-dialog paths.
+- Confirmed unsupported file rejection, invalid role schema rejection, and Workspace V2 insertion through Playwright.
 - Searched Asset Manager V2 targets for legacy Asset Browser implementation reuse.
-- Checked that no sample or game JSON files were modified.
+- Kept sample JSON files unmodified; the old sample schema path is a compatibility pointer to the moved canonical schema.
 
 ## Results
 
 - `npm run test:workspace-v2`: passed, 10 tests.
-- Tool mode: passed. Asset Manager V2 shows the tool action nav, hides workspace action nav, loads `asset-browser.schema.json`, exposes all seven file picker controls, and validates selected files before Add Asset.
-- Accept filters: passed. Playwright asserted kind-specific accept filters on image, audio, font, video, shader, data, and localization picker inputs.
-- Selected file validation: passed. Image `nebula-backdrop.png` selected with the `background` role derived `image.assets.nebula-backdrop.background`, `assets/images/nebula-backdrop.png`, validated against the schema, and added successfully.
-- Picker rejection: passed. `notes.txt` selected through the image picker was rejected and Add Asset stayed disabled.
+- Tool mode: passed. Asset Manager V2 shows the tool action nav, hides workspace action nav, loads `asset-browser.schema.json`, exposes one picker, derives approved kind, and validates selected files before Add.
+- Selected file validation: passed. `nebula-backdrop.png` selected from a project-root path derived `image`, required `background`, assigned `image.assets.nebula-backdrop.background`, normalized `assets/images/nebula-backdrop.png`, validated, and added successfully.
+- Picker rejection: passed. `notes.exe` was rejected as an unapproved asset type and Add stayed disabled.
 - Role validation: passed. A JSON payload with an audio asset using the image-only `background` role was rejected.
-- Workspace mode: passed. Workspace V2 launched Asset Manager V2 with `launch=workspace`, inserted the selected audio asset into `tools.asset-browser.assets`, and did not create `asset-manager-v2` or `workspace-v2` manifest entries.
+- Workspace mode: passed. Workspace V2 launched Asset Manager V2 with `launch=workspace`, inserted `audio.assets.fire.sound` into `tools.asset-browser.assets`, and did not create `asset-manager-v2` or `workspace-v2` manifest entries.
 - Asset Browser reuse check: passed. No legacy Asset Browser implementation imports or app references were added.
-- Sample JSON check: passed. No sample or game JSON files were modified.
 
 ## Reports
 
 - `docs/dev/reports/playwright_v8_coverage_report.txt`
 - `docs/dev/reports/coverage_changed_js_guardrail.txt`
 - `docs/dev/reports/PR_26126_084_asset_manager_v2_schema_validation_notes.md`
+- `docs/dev/reports/PR_26126_084_asset_manager_v2_path_normalization_notes.md`
 - `docs/dev/reports/PR_26126_084_asset_manager_v2_manual_validation_notes.md`

docs/dev/reports/PR_26126_084_asset_manager_v2_path_normalization_notes.md

@@ -0,0 +1,27 @@
+# PR_26126_084 Asset Manager V2 Path Normalization Notes
+
+Date: 2026-05-06
+
+## Rule
+
+Selected file paths are normalized to repository-relative asset paths:
+
+```text
+HTML-JavaScript-Gaming/assets/audio/fire.wav -> assets/audio/fire.wav
+C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\assets\images\nebula-backdrop.png -> assets/images/nebula-backdrop.png
+```
+
+Backslashes are converted to `/`, repeated separators are collapsed, and the `HTML-JavaScript-Gaming` project-root prefix is removed when present.
+
+## Fallback
+
+If the browser does not expose a project-root path, Asset Manager V2 falls back to the derived kind folder and sanitized filename, for example:
+
+```text
+assets/images/nebula-backdrop.png
+assets/audio/fire.wav
+```
+
+## Validation
+
+Playwright validated both a Windows absolute project path and a project-root-prefixed path through the single picker flow. Both resolved to Workspace V2-safe relative paths before schema validation and insertion.

docs/dev/reports/PR_26126_084_asset_manager_v2_schema_validation_notes.md

@@ -4,26 +4,20 @@ Date: 2026-05-06
 
 ## Schema Changes
 
+- Moved the canonical sample wrapper schema to `tools/schemas/samples/sample.tool-payload.schema.json`.
+- Kept `tools/schemas/sample.tool-payload.schema.json` as a compatibility `$ref` pointer so existing sample JSON files remain unmodified.
 - Expanded `tools/schemas/tools/asset-browser.schema.json` asset id patterns and `kind` enum to include `image`, `audio`, `font`, `video`, `shader`, `data`, and `localization`.
-- Added optional `role` to asset entries.
-- Added schema-owned `assetRolesByKind` rules consumed by Asset Manager V2 validation:
-  - image: `sprite`, `background`, `bezel`, `ui`
-  - audio: `sound`, `music`
-  - font: `ui`, `display`
-  - video: `cutscene`, `loop`
-  - shader: `fragment`, `vertex`, `compute`
-  - data: `config`, `table`
-  - localization: `strings`, `dialogue`
+- Required `role` on asset entries and kept role validation schema-owned through `assetRolesByKind`.
+- Kept `stretchOverride` optional and constrained to `image.*.bezel` assets only; generic asset records do not require Stretch.
 
 ## Runtime Validation
 
-- Asset Manager V2 loads allowed kinds, roles, and role-by-kind rules from `asset-browser.schema.json`.
-- File selection derives a path and asset id, then validates the selected file entry through `AssetSchemaValidator.validateFileSelection()`.
-- The selected file entry is also validated as an `assets` payload before the Add Asset button can persist it.
-- Invalid picker selections are blocked before insertion. Example covered by Playwright: `notes.txt` selected through the image picker is rejected by accept validation.
-- Invalid role combinations are rejected by schema-backed validation. Example covered by Playwright: `role: "background"` on an audio asset is rejected.
-- Image `bezel` role requires an `image.*.bezel` asset id.
-- `stretchOverride` remains allowed only on `image.*.bezel` assets.
+- Asset Manager V2 uses one `Pick Asset File` control for all asset types.
+- File selection derives the approved kind from extension or MIME type before role selection.
+- Role selection is required and limited to allowed roles for the derived kind.
+- Asset IDs are auto-assigned from derived kind, filename, and selected role.
+- Source is always written as `asset-manager-v2`.
+- Invalid extensions, unsupported roles, duplicate asset IDs, and schema-invalid JSON are rejected before insertion.
 
 ## Workspace Location
 

docs/dev/reports/codex_changed_files.txt

@@ -0,0 +1,52 @@
+# git status --short
+M docs/dev/PLAN_PR.md
+ M docs/dev/reports/PR_26126_084_asset_manager_v2_manual_validation_notes.md
+ M docs/dev/reports/PR_26126_084_asset_manager_v2_schema_validation_notes.md
+ M docs/dev/reports/coverage_changed_js_guardrail.txt
+ M docs/dev/reports/playwright_v8_coverage_report.txt
+ M tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
+ M tests/tools/ToolWorkspaceSchemaManifestBoundaries.test.mjs
+ M tests/validation/samples.curriculum.validation.json
+ M tests/validation/samples.runtime.validation.report.json
+ M tests/validation/samples.shared.boundaries.report.json
+ M tools/asset-manager-v2/README.md
+ M tools/asset-manager-v2/index.html
+ M tools/asset-manager-v2/js/AssetManagerV2App.js
+ M tools/asset-manager-v2/js/assetManagerMetadata.js
+ M tools/asset-manager-v2/js/bootstrap.js
+ M tools/asset-manager-v2/js/controls/AssetFormControl.js
+ M tools/asset-manager-v2/js/services/AssetSchemaValidator.js
+ M tools/asset-manager-v2/styles/assetManager.css
+ M tools/schemas/README.md
+ M tools/schemas/sample.tool-payload.schema.json
+ M tools/schemas/tools/asset-browser.schema.json
+?? docs/dev/reports/PR_26126_084_asset_manager_v2_path_normalization_notes.md
+?? tools/schemas/samples/
+
+# git ls-files --others --exclude-standard
+docs/dev/reports/PR_26126_084_asset_manager_v2_path_normalization_notes.md
+tools/schemas/samples/sample.tool-payload.schema.json
+
+# git diff --stat
+docs/dev/PLAN_PR.md                                |   3 +-
+ ...084_asset_manager_v2_manual_validation_notes.md |  21 +--
+ ...084_asset_manager_v2_schema_validation_notes.md |  26 ++--
+ docs/dev/reports/coverage_changed_js_guardrail.txt |  19 +--
+ docs/dev/reports/playwright_v8_coverage_report.txt |  47 ++-----
+ .../playwright/PreviewGeneratorV2Baseline.spec.mjs | 134 +++++++++++++------
+ .../ToolWorkspaceSchemaManifestBoundaries.test.mjs |   2 +-
+ .../validation/samples.curriculum.validation.json  |   2 +-
+ .../samples.runtime.validation.report.json         |   2 +-
+ .../samples.shared.boundaries.report.json          |   2 +-
+ tools/asset-manager-v2/README.md                   |   2 +-
+ tools/asset-manager-v2/index.html                  |  70 +---------
+ tools/asset-manager-v2/js/AssetManagerV2App.js     |  12 ++
+ tools/asset-manager-v2/js/assetManagerMetadata.js  | 130 ++++++++++++++++++-
+ tools/asset-manager-v2/js/bootstrap.js             |   9 +-
+ .../js/controls/AssetFormControl.js                | 144 +++++++++++++--------
+ .../js/services/AssetSchemaValidator.js            |  15 +--
+ tools/asset-manager-v2/styles/assetManager.css     |  47 ++-----
+ tools/schemas/README.md                            |   3 +-
+ tools/schemas/sample.tool-payload.schema.json      |  83 +-----------
+ tools/schemas/tools/asset-browser.schema.json      |   1 +
+ 21 files changed, 393 insertions(+), 381 deletions(-)