|
| 1 | +# PR_26140_069 Engine Domain Index Barrel Removal Phase 3 |
| 2 | + |
| 3 | +## Summary |
| 4 | +- Removed the targeted phase 3 engine domain barrel files: |
| 5 | + - `src/engine/ai/index.js` |
| 6 | + - `src/engine/animation/index.js` |
| 7 | + - `src/engine/automation/index.js` |
| 8 | + - `src/engine/config/index.js` |
| 9 | + - `src/engine/ecs/index.js` |
| 10 | + - `src/engine/entity/index.js` |
| 11 | + - `src/engine/interaction/index.js` |
| 12 | +- Replaced active imports from those barrels with direct canonical file imports. |
| 13 | +- Kept edits to import wiring only. No runtime logic, sample JSON, game/sample entry removal, replacement barrels, or pass-through shims were added. |
| 14 | +- No edits were made under `src/engine/debug/**`, `src/engine/network/**`, or `src/engine/systems/**`. |
| 15 | +- `src/engine/core/index.js` remains untouched in this PR. |
| 16 | +- `src/engine/release/SettingsSystem.js` received a required import-only update from the config barrel to `src/engine/config/ConfigStore.js` so the config barrel could be deleted. |
| 17 | + |
| 18 | +## Direct Import Mapping |
| 19 | +- AI: |
| 20 | + - patrol helpers -> `src/engine/ai/PatrolSystem.js` |
| 21 | + - pathfinding -> `src/engine/ai/GridPathfinding.js` |
| 22 | + - chase/evade steering -> `src/engine/ai/SteeringBehaviors.js` |
| 23 | + - `AIStateController` -> `src/engine/ai/AIStateController.js` |
| 24 | + - group behavior helpers -> `src/engine/ai/GroupBehaviors.js` |
| 25 | +- `AnimationController` -> `src/engine/animation/AnimationController.js` |
| 26 | +- Automation classes -> their one-class files under `src/engine/automation/` |
| 27 | +- `ConfigStore` -> `src/engine/config/ConfigStore.js` |
| 28 | +- `World` -> `src/engine/ecs/World.js` |
| 29 | +- Entity components -> their one-class files under `src/engine/entity/` |
| 30 | +- Interaction helpers -> `src/engine/interaction/InteractionSystem.js` |
| 31 | + |
| 32 | +## Additional Import Validation Repair |
| 33 | +- While validating changed-file imports, `tests/final/EditorAutomationSecurityPipeline.test.mjs` surfaced stale imports from removed `tools/shared/editor/index.js` and `tools/shared/pipeline/index.js`. |
| 34 | +- Because that test was already touched for automation barrel removal, it was updated with direct canonical imports from the existing editor and pipeline files so the requested changed-file import validation and affected domain test can run cleanly. |
| 35 | + |
| 36 | +## Validation |
| 37 | +- PASS: target barrel scan reports `0` active imports/exports from the seven phase 3 barrels. |
| 38 | +- PASS: target deletion scan confirms all seven targeted `index.js` files no longer exist. |
| 39 | +- PASS: no JSON files changed. |
| 40 | +- PASS: `node --check` passed for 42 changed existing JS/MJS files. |
| 41 | +- PASS: local import target validation passed for 42 changed existing JS/MJS files. |
| 42 | +- PASS: `npm run test:workspace-v2` passed 59/59 tests. |
| 43 | +- PASS: targeted affected domain tests passed: |
| 44 | + - `tests/ai/AIBehaviors.test.mjs` |
| 45 | + - `tests/final/EditorAutomationSecurityPipeline.test.mjs` |
| 46 | +- PASS: `git diff --check` exited 0. Git emitted advisory line-ending warnings for touched `.mjs` test files only. |
| 47 | +- SKIPPED: full samples smoke test, per PR instruction. |
0 commit comments