Skip to content

Commit bd06624

Browse files
author
DavidQ
committed
Remove engine domain index barrel exports phase 3 - PR_26140_069-remove-engine-domain-index-barrels-phase3
1 parent 70c237c commit bd06624

50 files changed

Lines changed: 117 additions & 119 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
# PR_26140_069 Engine Domain Index Barrel Removal Phase 3
2+
3+
## Summary
4+
- Removed the targeted phase 3 engine domain barrel files:
5+
- `src/engine/ai/index.js`
6+
- `src/engine/animation/index.js`
7+
- `src/engine/automation/index.js`
8+
- `src/engine/config/index.js`
9+
- `src/engine/ecs/index.js`
10+
- `src/engine/entity/index.js`
11+
- `src/engine/interaction/index.js`
12+
- Replaced active imports from those barrels with direct canonical file imports.
13+
- Kept edits to import wiring only. No runtime logic, sample JSON, game/sample entry removal, replacement barrels, or pass-through shims were added.
14+
- No edits were made under `src/engine/debug/**`, `src/engine/network/**`, or `src/engine/systems/**`.
15+
- `src/engine/core/index.js` remains untouched in this PR.
16+
- `src/engine/release/SettingsSystem.js` received a required import-only update from the config barrel to `src/engine/config/ConfigStore.js` so the config barrel could be deleted.
17+
18+
## Direct Import Mapping
19+
- AI:
20+
- patrol helpers -> `src/engine/ai/PatrolSystem.js`
21+
- pathfinding -> `src/engine/ai/GridPathfinding.js`
22+
- chase/evade steering -> `src/engine/ai/SteeringBehaviors.js`
23+
- `AIStateController` -> `src/engine/ai/AIStateController.js`
24+
- group behavior helpers -> `src/engine/ai/GroupBehaviors.js`
25+
- `AnimationController` -> `src/engine/animation/AnimationController.js`
26+
- Automation classes -> their one-class files under `src/engine/automation/`
27+
- `ConfigStore` -> `src/engine/config/ConfigStore.js`
28+
- `World` -> `src/engine/ecs/World.js`
29+
- Entity components -> their one-class files under `src/engine/entity/`
30+
- Interaction helpers -> `src/engine/interaction/InteractionSystem.js`
31+
32+
## Additional Import Validation Repair
33+
- While validating changed-file imports, `tests/final/EditorAutomationSecurityPipeline.test.mjs` surfaced stale imports from removed `tools/shared/editor/index.js` and `tools/shared/pipeline/index.js`.
34+
- Because that test was already touched for automation barrel removal, it was updated with direct canonical imports from the existing editor and pipeline files so the requested changed-file import validation and affected domain test can run cleanly.
35+
36+
## Validation
37+
- PASS: target barrel scan reports `0` active imports/exports from the seven phase 3 barrels.
38+
- PASS: target deletion scan confirms all seven targeted `index.js` files no longer exist.
39+
- PASS: no JSON files changed.
40+
- PASS: `node --check` passed for 42 changed existing JS/MJS files.
41+
- PASS: local import target validation passed for 42 changed existing JS/MJS files.
42+
- PASS: `npm run test:workspace-v2` passed 59/59 tests.
43+
- PASS: targeted affected domain tests passed:
44+
- `tests/ai/AIBehaviors.test.mjs`
45+
- `tests/final/EditorAutomationSecurityPipeline.test.mjs`
46+
- PASS: `git diff --check` exited 0. Git emitted advisory line-ending warnings for touched `.mjs` test files only.
47+
- SKIPPED: full samples smoke test, per PR instruction.

samples/phase-01/0107/EntityMovementScene.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,10 @@ EntityMovementScene.js
77
import { Scene } from '/src/engine/scene/index.js';
88
import { Theme } from '/src/engine/theme/Theme.js';
99
import { ThemeTokens } from '/src/engine/theme/ThemeTokens.js';
10-
import { Entity, Transform, Velocity, Bounds } from '/src/engine/entity/index.js';
10+
import Entity from '/src/engine/entity/Entity.js';
11+
import Transform from '/src/engine/entity/Transform.js';
12+
import Velocity from '/src/engine/entity/Velocity.js';
13+
import Bounds from '/src/engine/entity/Bounds.js';
1114

1215
const theme = new Theme(ThemeTokens);
1316

samples/phase-01/0108/RenderAdapterScene.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,10 @@ RenderAdapterScene.js
77
import { Scene } from '/src/engine/scene/index.js';
88
import { Theme } from '/src/engine/theme/Theme.js';
99
import { ThemeTokens } from '/src/engine/theme/ThemeTokens.js';
10-
import { Entity, Transform, Velocity, Bounds } from '/src/engine/entity/index.js';
10+
import Entity from '/src/engine/entity/Entity.js';
11+
import Transform from '/src/engine/entity/Transform.js';
12+
import Velocity from '/src/engine/entity/Velocity.js';
13+
import Bounds from '/src/engine/entity/Bounds.js';
1114

1215
const theme = new Theme(ThemeTokens);
1316

samples/phase-01/0115/ECSFoundationScene.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ ECSFoundationScene.js
77
import { Scene } from '/src/engine/scene/index.js';
88
import { Theme } from '/src/engine/theme/Theme.js';
99
import { ThemeTokens } from '/src/engine/theme/ThemeTokens.js';
10-
import { World } from '/src/engine/ecs/index.js';
10+
import World from '/src/engine/ecs/World.js';
1111
import { drawSceneFrame } from '/src/engine/debug/index.js';
1212

1313
const theme = new Theme(ThemeTokens);

samples/phase-01/0116/ECSMovementSystemScene.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ ECSMovementSystemScene.js
77
import { Scene } from '/src/engine/scene/index.js';
88
import { Theme } from '/src/engine/theme/Theme.js';
99
import { ThemeTokens } from '/src/engine/theme/ThemeTokens.js';
10-
import { World } from '/src/engine/ecs/index.js';
10+
import World from '/src/engine/ecs/World.js';
1111
import { createTransform, createSize, createVelocity, createRenderable } from '/src/engine/components/index.js';
1212
import { drawSceneFrame } from '/src/engine/debug/index.js';
1313
import { moveEntities, bounceEntitiesHorizontallyInBounds, renderRectEntities } from '/src/engine/systems/index.js';

samples/phase-01/0117/ECSInputSystemScene.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ ECSInputSystemScene.js
77
import { Scene } from '/src/engine/scene/index.js';
88
import { Theme } from '/src/engine/theme/Theme.js';
99
import { ThemeTokens } from '/src/engine/theme/ThemeTokens.js';
10-
import { World } from '/src/engine/ecs/index.js';
10+
import World from '/src/engine/ecs/World.js';
1111
import {
1212
createTransform,
1313
createSize,

samples/phase-01/0118/ECSCollisionSystemScene.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ ECSCollisionSystemScene.js
77
import { Scene } from '/src/engine/scene/index.js';
88
import { Theme } from '/src/engine/theme/Theme.js';
99
import { ThemeTokens } from '/src/engine/theme/ThemeTokens.js';
10-
import { World } from '/src/engine/ecs/index.js';
10+
import World from '/src/engine/ecs/World.js';
1111
import {
1212
createTransform,
1313
createSize,

samples/phase-01/0119/ECSRenderSystemScene.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ ECSRenderSystemScene.js
77
import { Scene } from '/src/engine/scene/index.js';
88
import { Theme } from '/src/engine/theme/Theme.js';
99
import { ThemeTokens } from '/src/engine/theme/ThemeTokens.js';
10-
import { World } from '/src/engine/ecs/index.js';
10+
import World from '/src/engine/ecs/World.js';
1111
import { drawSceneFrame } from '/src/engine/debug/index.js';
1212
import { renderRectEntities } from '/src/engine/systems/index.js';
1313

samples/phase-01/0120/ECSSceneWorldScene.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ ECSSceneWorldScene.js
77
import { Scene } from '/src/engine/scene/index.js';
88
import { Theme } from '/src/engine/theme/Theme.js';
99
import { ThemeTokens } from '/src/engine/theme/ThemeTokens.js';
10-
import { World } from '/src/engine/ecs/index.js';
10+
import World from '/src/engine/ecs/World.js';
1111
import {
1212
createTransform,
1313
createSize,

samples/phase-01/0121/UIOverlayScene.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ UIOverlayScene.js
77
import { Scene } from '/src/engine/scene/index.js';
88
import { Theme } from '/src/engine/theme/Theme.js';
99
import { ThemeTokens } from '/src/engine/theme/ThemeTokens.js';
10-
import { World } from '/src/engine/ecs/index.js';
10+
import World from '/src/engine/ecs/World.js';
1111
import {
1212
createTransform,
1313
createSize,

0 commit comments

Comments
 (0)