Finalize promotion gate validation and closeout

Author: DavidQ

docs/dev/CODEX_COMMANDS.md

@@ -1,5 +1,5 @@
 MODEL: GPT-5.4-codex
 REASONING: high
 COMMAND:
-Execute docs/pr/BUILD_PR_PROMOTION_GATE_57_OBSERVABILITY_ABORT.md exactly.
-Package to <project folder>/tmp/BUILD_PR_PROMOTION_GATE_57_OBSERVABILITY_ABORT_delta.zip
+Execute docs/pr/BUILD_PR_PROMOTION_GATE_58_VALIDATION_CLOSEOUT.md exactly.
+Package to <project folder>/tmp/BUILD_PR_PROMOTION_GATE_58_VALIDATION_CLOSEOUT_delta.zip

docs/dev/COMMIT_COMMENT.txt

@@ -1 +1 @@
-Add promotion gate observability and abort visibility
+Finalize promotion gate validation and closeout

docs/dev/NEXT_COMMAND.txt

@@ -1 +1 @@
-Next: validation closeout
+End of promotion-gate lane

docs/dev/reports/file_tree.txt

@@ -1,3 +1,2 @@
 src/advanced/promotion/createPromotionGate.js
-src/engine/debug/panels/PromotionGatePanel.js
 src/shared/state/createPromotionStateSnapshot.js

src/advanced/promotion/createPromotionGate.js

@@ -53,12 +53,38 @@ function resolveGateMode({ promoted }) {
 }
 
 function createAbortVisibility({ rollbackTriggered, promoted, reason }) {
-  const aborted = Boolean(rollbackTriggered) && !promoted;
+  const aborted = Boolean(rollbackTriggered);
   return {
     decisionPath: 'PROMOTION_GATE_ABORT_VISIBILITY',
     rollbackTriggered: Boolean(rollbackTriggered),
     aborted,
-    reason: aborted ? 'ROLLBACK_ABORTED_PROMOTION' : String(reason || '')
+    reason: aborted
+      ? (promoted ? 'ROLLBACK_ABORT_VISIBLE' : 'ROLLBACK_ABORTED_PROMOTION')
+      : String(reason || '')
+  };
+}
+
+function createValidationChecklist(evaluation, cycleState) {
+  const modeVisible = typeof evaluation?.mode === 'string' && evaluation.mode.length > 0;
+  const handoffVisible = isPlainObject(evaluation?.handoff)
+    && evaluation.handoff.decisionPath === 'PROMOTION_GATE_HANDOFF';
+  const abortVisible = isPlainObject(evaluation?.abort)
+    && evaluation.abort.decisionPath === 'PROMOTION_GATE_ABORT_VISIBILITY';
+
+  cycleState.passiveSeen = cycleState.passiveSeen || evaluation.mode === 'passive';
+  cycleState.authoritativeSeen = cycleState.authoritativeSeen || evaluation.mode === 'authoritative';
+  cycleState.abortSeen = cycleState.abortSeen || evaluation.abort?.aborted === true;
+  cycleState.fullCycleReached = cycleState.passiveSeen && cycleState.authoritativeSeen && cycleState.abortSeen;
+
+  return {
+    checklistPath: 'PROMOTION_GATE_VALIDATION_CLOSEOUT',
+    modeVisible,
+    handoffVisible,
+    abortVisible,
+    passiveSeen: cycleState.passiveSeen,
+    authoritativeSeen: cycleState.authoritativeSeen,
+    abortSeen: cycleState.abortSeen,
+    fullCycleReached: cycleState.fullCycleReached
   };
 }
 
@@ -68,6 +94,7 @@ function createPromotionGate(options = {}) {
   const stabilityWindowFrames = asPositiveInteger(options.stabilityWindowFrames, 3);
   const logger = typeof options.logger === 'function' ? options.logger : null;
   const onEvaluation = typeof options.onEvaluation === 'function' ? options.onEvaluation : null;
+  const onValidation = typeof options.onValidation === 'function' ? options.onValidation : null;
 
   let promoted = Boolean(options.initiallyPromoted);
   let stableFrames = promoted ? stabilityWindowFrames : 0;
@@ -83,6 +110,12 @@ function createPromotionGate(options = {}) {
     lastEvaluationAtMs: null,
     lastPromotionAtMs: promoted ? Number(now()) : null
   };
+  const validationCycle = {
+    passiveSeen: !promoted,
+    authoritativeSeen: promoted,
+    abortSeen: false,
+    fullCycleReached: false
+  };
 
   function getMetrics() {
     return {
@@ -180,6 +213,7 @@ function createPromotionGate(options = {}) {
       reason: lastReason,
       metrics: getMetrics()
     };
+    evaluation.validation = createValidationChecklist(evaluation, validationCycle);
 
     lastEvaluation = evaluation;
 
@@ -192,6 +226,9 @@ function createPromotionGate(options = {}) {
     if (onEvaluation) {
       onEvaluation(evaluation);
     }
+    if (onValidation) {
+      onValidation(evaluation.validation, evaluation);
+    }
 
     return evaluation;
   }

src/shared/state/createPromotionStateSnapshot.js

@@ -12,6 +12,11 @@ function cloneAbort(value) {
   return { ...value };
 }
 
+function cloneValidation(value) {
+  if (!value || typeof value !== 'object') return null;
+  return { ...value };
+}
+
 function resolveStatusMode({ promoted, lastEvaluation }) {
   const fromEvaluation = lastEvaluation && typeof lastEvaluation.mode === 'string'
     ? lastEvaluation.mode
@@ -29,6 +34,10 @@ function resolveStatusAbort({ lastEvaluation }) {
   return cloneAbort(lastEvaluation?.abort);
 }
 
+function resolveStatusValidation({ lastEvaluation }) {
+  return cloneValidation(lastEvaluation?.validation);
+}
+
 export function createPromotionStateSnapshot({
   promoted,
   stableFrames,
@@ -52,7 +61,8 @@ export function createPromotionStateSnapshot({
   snapshot.status = {
     mode: resolveStatusMode({ promoted, lastEvaluation: snapshot.lastEvaluation }),
     handoff: resolvedHandoff,
-    abort: resolveStatusAbort({ lastEvaluation: snapshot.lastEvaluation })
+    abort: resolveStatusAbort({ lastEvaluation: snapshot.lastEvaluation }),
+    validation: resolveStatusValidation({ lastEvaluation: snapshot.lastEvaluation })
   };
   return snapshot;
 }