Fix shared extraction guard baseline drift

BUILD_PR_LEVEL_19_8_FIX_SHARED_EXTRACTION_GUARD_BASELINE

Author: DavidQ

docs/dev/CODEX_COMMANDS.md

@@ -2,31 +2,31 @@ MODEL: GPT-5.4-codex
 REASONING: high
 
 COMMAND:
-1. Open:
-   tests/samples/SamplesProgramCombinedPass.test.mjs
+1. Run:
+   node tools/dev/checkSharedExtractionGuard.mjs
 
-2. Locate phase expectation assertion.
+2. Capture output differences.
 
-3. Replace hardcoded phase list:
-   phase-01 → phase-15
+3. Locate baseline file (likely in tools/dev or reports).
 
-4. Update to:
-   include phase-16, phase-17, phase-18, phase-19
+4. Determine:
+   - Are new shared entries valid? If YES → update baseline
+   - If NO → fix classification logic
 
-   Preferred:
-   derive phases dynamically from filesystem OR
-   extend static list to 19
+5. Apply smallest change:
+   - update baseline JSON OR
+   - adjust guard filters
 
-5. Run:
-   node ./scripts/run-node-tests.mjs
+6. Run:
+   npm test
 
-6. Confirm:
-   SamplesProgramCombinedPass passes
+7. Confirm:
+   pretest passes (no baseline drift)
 
-7. Package ZIP:
-   <project folder>/tmp/BUILD_PR_LEVEL_19_7_FIX_SAMPLE_PHASE_EXPECTATION.zip
+8. Package:
+   <project folder>/tmp/BUILD_PR_LEVEL_19_8_FIX_SHARED_EXTRACTION_GUARD_BASELINE.zip
 
 CONSTRAINTS:
-- Do not modify unrelated tests
-- Do not change engine/runtime code
-- Smallest scoped change only
+- Do not modify unrelated systems
+- Do not remove guard
+- Preserve intent of guard

docs/dev/COMMIT_COMMENT.txt

@@ -1,3 +1,3 @@
-Fix sample phase expectation mismatch (phase-16–19)
+Fix shared extraction guard baseline drift
 
-BUILD_PR_LEVEL_19_7_FIX_SAMPLE_PHASE_EXPECTATION
+BUILD_PR_LEVEL_19_8_FIX_SHARED_EXTRACTION_GUARD_BASELINE

docs/dev/reports/BUILD_PR_LEVEL_19_8_FIX_SHARED_EXTRACTION_GUARD_BASELINE_summary.md

@@ -0,0 +1,10 @@
+# Shared Extraction Guard Fix
+
+## Problem
+baseline_unexpected=288 indicates drift between expected and actual shared usage.
+
+## Resolution
+Baseline aligned or guard logic corrected.
+
+## Result
+Pretest passes → validation pipeline unblocked.

docs/dev/reports/launch_smoke_report.md

@@ -1,6 +1,6 @@
 # Launch Smoke Report
 
-Generated: 2026-04-17T15:22:34.189Z
+Generated: 2026-04-17T15:32:24.952Z
 
 Filters: games=true, samples=true, tools=true, sampleRange=all
 

docs/pr/BUILD_PR_LEVEL_19_8_FIX_SHARED_EXTRACTION_GUARD_BASELINE.md

@@ -0,0 +1,34 @@
+# BUILD_PR_LEVEL_19_8_FIX_SHARED_EXTRACTION_GUARD_BASELINE
+
+## Purpose
+Fix blocking validation failure:
+tools/dev/checkSharedExtractionGuard.mjs baseline drift (baseline_unexpected=288)
+
+## Scope
+- Single purpose PR
+- Align baseline to current repo state OR fix guard logic mismatch
+- No feature work
+
+## Required Change
+1. Run:
+   npm test (observe baseline failure)
+
+2. Run guard script directly:
+   node tools/dev/checkSharedExtractionGuard.mjs
+
+3. Identify:
+   - newly valid shared extractions OR
+   - false positives in guard logic
+
+4. Apply ONE of:
+   A. Update baseline file to match current valid state
+   OR
+   B. Fix guard logic to correctly classify entries
+
+## Validation
+- npm test passes pretest
+- baseline_unexpected = 0
+
+## Acceptance
+- Guard passes cleanly
+- No unintended shared leaks introduced