Skip to content

Commit b0ce341

Browse files
author
DavidQ
committed
Move curriculum validation artifact to test output path and include all 19 phases - PR 10.21. Relocate validation artifacts out of samples metadata to test/validation path - PR 10.22
1 parent 1be23d9 commit b0ce341

17 files changed

Lines changed: 350 additions & 20 deletions

‎docs/dev/codex_commands.md‎

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,12 @@
11
# CODEX COMMANDS
22

33
model: gpt-5.3-codex
4-
reasoning: medium
4+
reasoning: low
55

6-
Apply PR_10_20_TOOL_OWNED_JSON_ASSET_CATALOG_FIX.
6+
Apply PR_10_22_VALIDATION_ARTIFACT_RELOCATION.
77

8-
Required:
9-
- Fix samples 0204, 1413, and 1505 so Asset Browser / Import Hub reads and writes the JSON catalog directly.
10-
- Fix flash-then-blank behavior where entries briefly show then clear/truncate.
11-
- For 0204, stop using sample-local assetRegistry.js / AssetRegistryScene.js as a bridge or source for tool data.
12-
- Normalize each sample JSON so the full asset list is in the schema-compatible location the tool expects.
13-
- Preserve preset fields only as UI state, not asset source.
14-
- Do not add fallback/default/hidden sample data.
15-
- Do not scrape JS source.
16-
- Do not modify start_of_day folders.
17-
- Add validation report at docs/dev/reports/PR_10_20_TOOL_OWNED_JSON_ASSET_CATALOG_FIX_report.md.
18-
- Return ZIP artifact at tmp/PR_10_20_TOOL_OWNED_JSON_ASSET_CATALOG_FIX_delta.zip.
8+
- Move validation JSON files out of samples/metadata to tests/validation (or docs/dev/reports).
9+
- Update any generators to write to new location.
10+
- Ensure tools do not consume these files.
11+
- Add validation report.
12+
- Return ZIP at tmp/PR_10_22_VALIDATION_ARTIFACT_RELOCATION_delta.zip.

‎docs/dev/commit_comment.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Make Asset Browser and Import Hub own JSON catalog loading for samples 0204, 1413, and 1505 - PR 10.20
1+
Relocate validation artifacts out of samples metadata to test/validation path - PR 10.22

‎docs/dev/reports/PR_10_21_CURRICULUM_VALIDATION_ARTIFACT_LOCATION_AND_PHASE_ORDER_FIX_report.md‎

Lines changed: 68 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,68 @@
1+
# PR_10_21_CURRICULUM_VALIDATION_ARTIFACT_LOCATION_AND_PHASE_ORDER_FIX Report
2+
3+
## Scope
4+
Moved `samples.curriculum.validation.json` into an explicit test/validation artifact location, corrected `progression.phaseOrder` to phases `01` through `19`, and updated test/generation wiring to use the new location.
5+
6+
## Artifact Location
7+
- Old path: `samples/metadata/samples.curriculum.validation.json`
8+
- New path: `tests/validation/samples.curriculum.validation.json`
9+
10+
## Generator/Script Update
11+
- Added generator script: `scripts/generate-curriculum-validation-artifact.mjs`
12+
- Added npm script entry: `build:curriculum-validation-artifact`
13+
- Generator now writes curriculum validation artifact to `tests/validation/samples.curriculum.validation.json`.
14+
- Updated consumer test path in `tests/samples/SamplesProgramCombinedPass.test.mjs` to read from `tests/validation`.
15+
16+
## Phase Order Fix
17+
Final `progression.phaseOrder`:
18+
- `01`
19+
- `02`
20+
- `03`
21+
- `04`
22+
- `05`
23+
- `06`
24+
- `07`
25+
- `08`
26+
- `09`
27+
- `10`
28+
- `11`
29+
- `12`
30+
- `13`
31+
- `14`
32+
- `15`
33+
- `16`
34+
- `17`
35+
- `18`
36+
- `19`
37+
38+
## Runtime Separation Confirmation
39+
Search performed across runtime/sample/tool code paths:
40+
- command: `rg -n "samples\.curriculum\.validation\.json|curriculum\.validation" src tools samples scripts -S`
41+
- result: references exist only in the new generator script; no runtime sample/tool data flow depends on this file as source-of-truth.
42+
43+
## Additional Consistency Adjustment
44+
- Updated `progression.totalSamples` in the moved artifact to match `samples/metadata/samples.index.metadata.json` current count (`256`) so existing curriculum progression checks remain coherent.
45+
46+
## Validation Performed
47+
1. `node --check scripts/generate-curriculum-validation-artifact.mjs`
48+
2. `node --check tests/samples/SamplesProgramCombinedPass.test.mjs`
49+
3. `node ./scripts/generate-curriculum-validation-artifact.mjs`
50+
4. `node -` inline import run for `tests/samples/SamplesProgramCombinedPass.test.mjs`
51+
52+
## Validation Results
53+
- Syntax checks: PASS
54+
- Artifact generation to new path: PASS
55+
- `SamplesProgramCombinedPass`: PASS
56+
57+
## Changed Files
58+
- `tests/validation/samples.curriculum.validation.json` (new, relocated artifact)
59+
- `samples/metadata/samples.curriculum.validation.json` (removed)
60+
- `tests/samples/SamplesProgramCombinedPass.test.mjs`
61+
- `scripts/generate-curriculum-validation-artifact.mjs` (new)
62+
- `package.json`
63+
- `docs/pr/BUILD_PR_LEVEL_06_SAMPLES_PROGRAM_COMBINED_PASS.md`
64+
- `docs/dev/reports/PR_10_21_CURRICULUM_VALIDATION_ARTIFACT_LOCATION_AND_PHASE_ORDER_FIX_report.md`
65+
66+
## Guardrails
67+
- No sample implementation code changes.
68+
- No `start_of_day` folder changes.

‎docs/dev/reports/PR_10_22_VALIDATION_ARTIFACT_RELOCATION_report.md‎

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
# PR_10_22_VALIDATION_ARTIFACT_RELOCATION Report
2+
3+
## Scope
4+
Relocated validation artifact JSON files out of `samples/metadata` into `tests/validation`, updated validation consumer paths, and verified runtime/tool code does not consume these artifacts.
5+
6+
## Validation Artifact Relocation
7+
8+
Moved:
9+
- `samples/metadata/samples.runtime.validation.report.json` -> `tests/validation/samples.runtime.validation.report.json`
10+
- `samples/metadata/samples.shared.boundaries.report.json` -> `tests/validation/samples.shared.boundaries.report.json`
11+
12+
Already relocated previously and kept in `tests/validation`:
13+
- `tests/validation/samples.curriculum.validation.json`
14+
15+
Post-relocation `samples/metadata` now contains only runtime metadata SSoT:
16+
- `samples.index.metadata.json`
17+
18+
## Generators / Writers
19+
- Existing dedicated curriculum validation artifact writer already targets test artifacts:
20+
- `scripts/generate-curriculum-validation-artifact.mjs` -> `tests/validation/samples.curriculum.validation.json`
21+
- No repo generator script was found that writes `samples.runtime.validation.report.json` or `samples.shared.boundaries.report.json` directly.
22+
- Updated validation consumer path in `tests/samples/SamplesProgramCombinedPass.test.mjs` to read boundaries report from `tests/validation`.
23+
24+
## Tool/Runtime Consumption Check
25+
Command:
26+
- `rg -n "samples\.runtime\.validation\.report\.json|samples\.shared\.boundaries\.report\.json|samples\.curriculum\.validation\.json" src tools -S`
27+
28+
Result:
29+
- `NO_MATCH`
30+
31+
Conclusion:
32+
- Runtime/tool code does not consume these validation artifacts as source-of-truth.
33+
34+
## Validation Performed
35+
1. `node --check tests/samples/SamplesProgramCombinedPass.test.mjs`
36+
2. Targeted execution:
37+
- inline node import run of `tests/samples/SamplesProgramCombinedPass.test.mjs`
38+
39+
## Validation Results
40+
- Syntax check: PASS
41+
- `SamplesProgramCombinedPass`: PASS
42+
43+
## Changed Files
44+
- `tests/validation/samples.runtime.validation.report.json` (new location)
45+
- `tests/validation/samples.shared.boundaries.report.json` (new location)
46+
- `tests/samples/SamplesProgramCombinedPass.test.mjs`
47+
- `docs/pr/BUILD_PR_LEVEL_06_SAMPLES_PROGRAM_COMBINED_PASS.md`
48+
- `docs/dev/reports/PR_10_22_VALIDATION_ARTIFACT_RELOCATION_report.md`
49+
50+
Deleted from old location:
51+
- `samples/metadata/samples.runtime.validation.report.json`
52+
- `samples/metadata/samples.shared.boundaries.report.json`
53+
54+
## Guardrails
55+
- No runtime behavior changes.
56+
- No schema changes.
57+
- No sample implementation changes.
58+
- No `start_of_day` folder changes.

‎docs/dev/reports/REPORT_PR_10_21.md‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
# REPORT_PR_10_21_CURRICULUM_VALIDATION_ARTIFACT_LOCATION_AND_PHASE_ORDER_FIX
2+
3+
## Bundle Summary
4+
This PR fixes the validation artifact classification and stale phase order.
5+
6+
## Evidence Basis
7+
Uploaded `samples.curriculum.validation.json` has `progression.phaseOrder` ending at `15`, while the current project expectation is all 19 phases.
8+
9+
## Target Behavior
10+
- Validation artifact lives under test/validation output.
11+
- Phase order includes 01 through 19.
12+
- File is not treated as runtime SSoT.

‎docs/dev/reports/REPORT_PR_10_22.md‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# REPORT_PR_10_22_VALIDATION_ARTIFACT_RELOCATION
2+
3+
## Summary
4+
Moved validation artifacts out of runtime metadata location.
5+
6+
## Result
7+
- Clean separation of runtime data vs validation output
8+
- Prevents tools from misreading validation files

‎docs/pr/BUILD_PR_LEVEL_06_SAMPLES_PROGRAM_COMBINED_PASS.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ Complete the remaining Section-6 Samples Program lane in one coherent pass by fi
1313
## Boundary Decisions Applied
1414
- canonical shared sample surface: `samples/shared`
1515
- compatibility-only surface: `samples/_shared` (shims forwarding to `samples/shared`)
16-
- sample-to-engine rule source: `samples/metadata/samples.shared.boundaries.report.json` (`engineBoundaryViolations: 0`)
17-
- curriculum validation source: `samples/metadata/samples.curriculum.validation.json` + `samples/metadata/samples.index.metadata.json`
16+
- sample-to-engine rule source: `tests/validation/samples.shared.boundaries.report.json` (`engineBoundaryViolations: 0`)
17+
- curriculum validation source: `tests/validation/samples.curriculum.validation.json` + `samples/metadata/samples.index.metadata.json`
1818

1919
## Section-6 Status Outcome
2020
Closed in this PR:

‎docs/pr/PR_10_21_CURRICULUM_VALIDATION_ARTIFACT_LOCATION_AND_PHASE_ORDER_FIX/BUILD.md‎

Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
# BUILD_PR_10_21_CURRICULUM_VALIDATION_ARTIFACT_LOCATION_AND_PHASE_ORDER_FIX
2+
3+
## Required Codex Work
4+
5+
### 1. Locate artifact ownership
6+
Find where `samples.curriculum.validation.json` is stored and, if applicable, generated.
7+
8+
### 2. Move validation output
9+
Move the file to an explicit test/validation artifact location, such as:
10+
- `tests/validation/samples.curriculum.validation.json`
11+
or the existing repo test artifact folder if one already exists.
12+
13+
Do not leave a duplicate runtime copy unless required by an existing test harness. If a compatibility copy is unavoidable, document why.
14+
15+
### 3. Correct phaseOrder
16+
Update:
17+
`progression.phaseOrder`
18+
19+
It must contain all 19 phases:
20+
- `01`
21+
- `02`
22+
- `03`
23+
- `04`
24+
- `05`
25+
- `06`
26+
- `07`
27+
- `08`
28+
- `09`
29+
- `10`
30+
- `11`
31+
- `12`
32+
- `13`
33+
- `14`
34+
- `15`
35+
- `16`
36+
- `17`
37+
- `18`
38+
- `19`
39+
40+
### 4. Runtime separation
41+
Confirm no runtime sample/tool data flow treats this validation file as source-of-truth. It is a validation artifact only.
42+
43+
### 5. Validation report
44+
Create:
45+
docs/dev/reports/PR_10_21_CURRICULUM_VALIDATION_ARTIFACT_LOCATION_AND_PHASE_ORDER_FIX_report.md
46+
47+
Report must include:
48+
- old file path
49+
- new file path
50+
- whether a generator/script was updated
51+
- final phaseOrder list
52+
- confirmation the file is not runtime SSoT
53+
- confirmation no start_of_day changes
54+
55+
## Constraints
56+
- Smallest scoped valid change.
57+
- No unrelated sample index rebuild unless required by the validation generator.
58+
- No sample implementation changes.
59+
- No roadmap text rewrite.

‎docs/pr/PR_10_21_CURRICULUM_VALIDATION_ARTIFACT_LOCATION_AND_PHASE_ORDER_FIX/PLAN.md‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# PLAN_PR_10_21_CURRICULUM_VALIDATION_ARTIFACT_LOCATION_AND_PHASE_ORDER_FIX
2+
3+
## Purpose
4+
Move curriculum validation output into a test/validation directory and correct phase ordering to include all 19 phases.
5+
6+
## Problem
7+
`samples.curriculum.validation.json` is validation/test output, but it is not clearly located as a test artifact. Its `progression.phaseOrder` currently stops at phase `15`, while the repo curriculum now has 19 phases.
8+
9+
## Scope
10+
- Validation artifact location only.
11+
- Curriculum validation generation/output path only if a generator exists.
12+
- Correct `progression.phaseOrder` to include phases `01` through `19`.
13+
- Keep the file as validation evidence, not runtime sample data.
14+
- Do not modify sample implementation code.
15+
- Do not modify start_of_day folders.
16+
17+
## Acceptance
18+
- `samples.curriculum.validation.json` lives under an explicit test/validation artifact path.
19+
- Any generator/script writes the file to that test/validation path.
20+
- `progression.phaseOrder` includes `01` through `19`.
21+
- Runtime sample/tool code does not depend on this validation artifact as SSoT data.
22+
- Report confirms old path, new path, and phase list.

‎docs/pr/PR_10_22_VALIDATION_ARTIFACT_RELOCATION/BUILD.md‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# BUILD_PR_10_22_VALIDATION_ARTIFACT_RELOCATION
2+
3+
## Required Codex Work
4+
5+
1. Move files from:
6+
samples/metadata/
7+
8+
to:
9+
tests/validation/ (preferred)
10+
OR docs/dev/reports/ (if repo standard requires)
11+
12+
2. Update any scripts/generators to output to the new location.
13+
14+
3. Verify no runtime/tool code references these files.
15+
16+
4. Add validation report:
17+
docs/dev/reports/PR_10_22_VALIDATION_ARTIFACT_RELOCATION_report.md
18+
19+
## Constraints
20+
- No runtime behavior changes
21+
- No schema changes
22+
- No sample changes

0 commit comments

Comments
 (0)