Skip to content

Commit a174d26

Browse files
author
DavidQ
committed
Fix Asset Manager V2 history accordion and control spacing - PR_26126_099-asset-manager-v2-accordion-spacing-fix
1 parent 94e3692 commit a174d26

9 files changed

Lines changed: 287 additions & 671 deletions
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# PR_26126_099 Asset Manager V2 Accordion Spacing Notes
2+
3+
## History Accordion
4+
- History now uses the shared `accordion-v2` header/body markup with `assetHistoryContent`.
5+
- The History header is bound by the existing Asset Manager V2 accordion controller.
6+
- Collapsing History hides the body, updates `aria-expanded`, updates the icon state, and reduces the accordion section height.
7+
- History remains outside Asset Controls and directly under the Asset Controls accordion in the left panel.
8+
9+
## Spacing
10+
- Open accordions now size to content by default instead of flexing to fill all available panel height.
11+
- Output Summary and Status keep explicit fill behavior where their panel layout depends on it.
12+
- Asset Controls, Assets, and Selected Asset Detail no longer carry measurable trailing body gap after their final visible child.
13+
14+
## Scope Guard
15+
- No asset schema files were changed.
16+
- Import/export behavior was not changed.
17+
- Asset path handling was not changed.
18+
- Sample JSON files were not modified.
19+
20+
## Validation
21+
- `npm run test:workspace-v2` validates History collapse/expand behavior and trailing spacing for Asset Controls, Assets, and Selected Asset Detail.
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# PR_26126_099 Asset Manager V2 Manual Validation Notes
2+
3+
## Commands
4+
- `npm run test:workspace-v2`
5+
- `git diff --check`
6+
7+
## Results
8+
- Required workspace-v2 Playwright gate passed: 12 tests passed.
9+
- `docs/dev/reports/playwright_v8_coverage_report.txt` was regenerated by the required workspace-v2 validation run.
10+
- `git diff --check` passed with no whitespace errors.
11+
12+
## Manual Checks Covered By Tests
13+
- History renders as an Asset Manager V2 accordion with the `History` header.
14+
- History collapse/expand updates visibility, `aria-expanded`, icon state, and released vertical height.
15+
- History remains directly under Asset Controls and outside the Asset Controls body.
16+
- Asset Controls, Assets, and Selected Asset Detail do not leave extra bottom whitespace after their final visible body content.
17+
- Asset schema, import/export behavior, path handling, and sample JSON are unchanged by this PR.

docs/dev/reports/codex_changed_files.txt

Lines changed: 10 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -2,31 +2,19 @@
22
M docs/dev/reports/coverage_changed_js_guardrail.txt
33
M docs/dev/reports/playwright_v8_coverage_report.txt
44
M tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
5-
M tools/asset-manager-v2/README.md
65
M tools/asset-manager-v2/index.html
7-
M tools/asset-manager-v2/js/AssetManagerV2App.js
8-
M tools/asset-manager-v2/js/assetManagerMetadata.js
9-
M tools/asset-manager-v2/js/bootstrap.js
10-
M tools/asset-manager-v2/js/controls/ActionNavControl.js
116
M tools/asset-manager-v2/styles/assetManager.css
12-
?? docs/dev/reports/PR_26126_098_asset_manager_v2_manual_validation_notes.md
13-
?? docs/dev/reports/PR_26126_098_asset_manager_v2_nav_import_export_notes.md
14-
?? docs/dev/reports/PR_26126_098_asset_manager_v2_path_preservation_notes.md
7+
?? docs/dev/reports/PR_26126_099_asset_manager_v2_accordion_spacing_notes.md
8+
?? docs/dev/reports/PR_26126_099_asset_manager_v2_manual_validation_notes.md
159

1610
# git ls-files --others --exclude-standard
17-
docs/dev/reports/PR_26126_098_asset_manager_v2_manual_validation_notes.md
18-
docs/dev/reports/PR_26126_098_asset_manager_v2_nav_import_export_notes.md
19-
docs/dev/reports/PR_26126_098_asset_manager_v2_path_preservation_notes.md
11+
docs/dev/reports/PR_26126_099_asset_manager_v2_accordion_spacing_notes.md
12+
docs/dev/reports/PR_26126_099_asset_manager_v2_manual_validation_notes.md
2013

2114
# git diff --stat
22-
docs/dev/reports/coverage_changed_js_guardrail.txt | 7 +-
23-
docs/dev/reports/playwright_v8_coverage_report.txt | 22 ++--
24-
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 119 +++++++++++++++++++--
25-
tools/asset-manager-v2/README.md | 2 +-
26-
tools/asset-manager-v2/index.html | 16 +--
27-
tools/asset-manager-v2/js/AssetManagerV2App.js | 71 ++++++++++--
28-
tools/asset-manager-v2/js/assetManagerMetadata.js | 6 +-
29-
tools/asset-manager-v2/js/bootstrap.js | 6 +-
30-
.../js/controls/ActionNavControl.js | 32 +++---
31-
tools/asset-manager-v2/styles/assetManager.css | 5 +-
32-
10 files changed, 230 insertions(+), 56 deletions(-)
15+
docs/dev/reports/coverage_changed_js_guardrail.txt | 2 --
16+
docs/dev/reports/playwright_v8_coverage_report.txt | 4 ---
17+
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 38 +++++++++++++++++++---
18+
tools/asset-manager-v2/index.html | 17 +++++++---
19+
tools/asset-manager-v2/styles/assetManager.css | 18 ++++++----
20+
5 files changed, 57 insertions(+), 22 deletions(-)

0 commit comments

Comments
 (0)