Enable Workspace Manager tool buttons from embedded payload baseline - PR 11.27

Author: DavidQ

docs/dev/codex_commands.md

@@ -1,28 +1,52 @@
 MODEL: GPT-5.3-codex
-REASONING: medium
+REASONING: high
 
 TASK:
-Apply PR 11.24.
+Apply PR 11.27.
 
-Find the sample 1902 page/content that renders the visible "Tool Roundtrip Links" section and individual "Open <tool>" links.
+Reset the working recovery baseline to:
 
-Make the smallest targeted change so sample 1902 exposes only:
+4dc2b0f: Show Workspace Manager asset status from embedded tool payloads - PR 11.22
 
-Open with Workspace Manager
+Use that as the source of truth because it loaded the JSON and displayed the correct full Workspace Manager workspace.
 
-Do not modify tool implementation files unless the sample entry page delegates rendering there.
-Do not change payload schema.
-Do not change manifest data except where required to remove direct visible sample links.
-Do not add fallback links.
-Do not touch start_of_day folders.
+Then fix ONLY the remaining issue:
+- many Workspace Manager tool buttons are grayed out/disabled even though embedded payload data exists.
 
-VALIDATION:
-node --check <changed-js-files>
+Do NOT carry forward today's failed changes unless independently required and verified:
+- do not reapply PR 11.23 binding/cache behavior that caused palette-only
+- do not reapply PR 11.25 forward-fix behavior that still failed
+- do not remove payload fan-out
+- do not collapse visible tools to palette-only
+
+Do NOT restore or change PR 11.24 page cleanup unless it already exists after resetting. The priority is Workspace Manager correctness from 4dc2b0f.
+
+Implementation guidance:
+1. Inspect Workspace Manager/tool launch button disabled logic.
+2. Compare status-display rules from 4dc2b0f with button-enable rules.
+3. Make enablement consider embedded payload presence as valid launch data.
+4. Keep utility tools handled separately as N/A where appropriate.
+5. Avoid selectedAssetId/assetRegistry/external-file requirements for embedded-payload tools.
+6. Keep the fix surgical and localized.
+
+Validation:
+node --check tools/shared/platformShell.js
 node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --samples --sample-range=1902-1902 --tools
 
+Manual validation:
+Open sample 1902.
+Open Workspace Manager.
+Confirm:
+- full workspace is visible
+- not palette-only
+- payload-backed editor buttons are enabled/openable
+- asset/status labels are still visible
+
 REPORT:
-Write docs/dev/reports/PR_11_24_validation.txt with:
-- changed files
-- before behavior
-- after behavior
+Write docs/dev/reports/PR_11_27_validation.txt with:
+- baseline commit used
+- files changed
+- root cause of grayed-out buttons
+- why payload presence now enables launch
 - validation commands/results
+- manual validation notes

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Make sample 1902 launch only through Workspace Manager - PR 11.24
+Enable Workspace Manager tool buttons from embedded payload baseline - PR 11.27

docs/dev/reports/PR_11_27_validation.txt

@@ -0,0 +1,41 @@
+PR 11.27 Validation Report
+
+PASS/FAIL: PASS
+
+Baseline commit used:
+- 4dc2b0f1e5dda41c4220626910964c2c492aa7f6
+- Subject: Show Workspace Manager asset status from embedded tool payloads - PR 11.22
+- Baseline file reset: tools/shared/platformShell.js
+
+Files changed:
+- tools/shared/platformShell.js
+- docs/dev/reports/PR_11_27_validation.txt
+
+Root cause of grayed-out buttons:
+- Workspace-context tool disablement in tools/shared/platformShell.js used a global palette gate:
+  - non-palette tools were disabled whenever shared palette handoff was not ready.
+- This gate ignored whether a tool already had valid embedded payload state in manifest.tools[toolId].
+- Result: payload-backed tools appeared in Workspace Manager with embedded status labels, but links remained disabled/grayed out.
+
+Why payload presence now enables launch:
+- Tool-disable logic now checks in this order:
+  1) workspace readiness (still required)
+  2) palette-browser always enabled
+  3) if manifest.tools[toolId] exists, tool is enabled (payload = data present)
+  4) if no tool state and no palette handoff, tool remains disabled
+- This keeps utility/unsupported cases gated while allowing payload-backed tools to open without selectedAssetId/assetRegistry/external file requirements.
+
+Validation commands/results:
+- node --check tools/shared/platformShell.js -> PASS
+- node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --samples --sample-range=1902-1902 --tools -> PASS
+  - Summary: PASS=19 FAIL=0 TOTAL=19
+
+Manual validation notes:
+- Manual browser validation is required for final visual confirmation of enabled/openable payload-backed buttons.
+- Expected manual checks:
+  - Open sample 1902
+  - Open Workspace Manager
+  - Confirm full workspace is visible (not palette-only)
+  - Confirm payload-backed editor buttons are enabled/openable
+  - Confirm asset/status labels remain visible
+- In this CLI run, automated validation passed and the enablement logic now aligns with embedded payload presence.

docs/dev/reports/PR_11_27_validation_template.txt

@@ -0,0 +1,25 @@
+# PR 11.27 Validation
+
+Baseline:
+- 4dc2b0f: Show Workspace Manager asset status from embedded tool payloads - PR 11.22
+
+Files changed:
+-
+
+Root cause:
+-
+
+Before:
+- Full workspace displayed, but many payload-backed tool buttons were grayed out.
+
+After:
+- Full workspace displayed and payload-backed tool buttons are enabled/openable.
+
+Validation:
+- node --check tools/shared/platformShell.js
+- node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --samples --sample-range=1902-1902 --tools
+
+Manual:
+- sample 1902 -> Workspace Manager
+- full workspace visible
+- payload-backed buttons enabled

docs/pr/PR_11_27_BASELINE_4DC2B0F_ENABLE_WORKSPACE_TOOL_BUTTONS.md

@@ -0,0 +1,54 @@
+# PR 11.27 — Baseline 4dc2b0f and Enable Workspace Tool Buttons
+
+## Purpose
+Restart the recovery lane from the last known good Workspace Manager baseline:
+
+4dc2b0f: Show Workspace Manager asset status from embedded tool payloads - PR 11.22
+
+## Known Good at Baseline
+- Sample 1902 loads JSON.
+- Workspace Manager displays the correct full workspace.
+- Embedded payload status is visible.
+
+## Remaining Defect
+- Many Workspace Manager tool buttons are grayed out/disabled even though their embedded payload data exists.
+
+## Required Change
+Start from commit `4dc2b0f` and make the smallest targeted fix so workspace-supported tools with embedded payload data are enabled/openable.
+
+## Scope
+- Use `4dc2b0f` as the baseline.
+- Do not include today’s failed PR 11.23 / 11.24 / 11.25 forward-fix logic.
+- Do not collapse workspace display to palette-only.
+- Do not remove or rewrite JSON payload.
+- Do not change schema unless a local enablement defect is proven.
+- Do not add fallback sample data.
+- Do not use hidden defaults.
+- Do not touch start_of_day folders.
+- Keep sample 1902 focused on Workspace Manager behavior.
+
+## Key Rule
+payload = data present
+
+Enablement must not require:
+- selectedAssetId
+- assetRegistry
+- external file reference
+
+Those may be useful metadata, but they are not required for enabling a tool when embedded payload exists.
+
+## Investigation Targets
+Check button disabled logic in Workspace Manager/platform shell:
+- Does it require an external asset reference?
+- Does it require selectedAssetId?
+- Does it treat embedded payload-only tools as missing assets?
+- Does it mark true utility tools differently from payload-backed editor tools?
+- Does status display and open enablement use different rules?
+
+## Acceptance
+- Workspace Manager from sample 1902 still shows the full workspace, not palette-only.
+- Tools with embedded payload data are enabled/openable.
+- Buttons are not grayed out solely because data is embedded instead of external.
+- True unsupported/missing tools may remain disabled only with documented reason.
+- Asset/status labels continue to show from embedded payload.
+- Runtime smoke test passes.

tools/shared/platformShell.js

@@ -679,34 +679,6 @@ function summarizeEmbeddedToolPayloadDocument(toolId = "", scopedToolState = nul
   return null;
 }
 
-function resolveWorkspaceManifestToolStateForStatus(toolId = "") {
-  const normalizedToolId = normalizeTextValue(toolId).toLowerCase();
-  if (!normalizedToolId) {
-    return null;
-  }
-  const manifest = getManifest();
-  const tools = manifest && typeof manifest === "object" && manifest.tools && typeof manifest.tools === "object" && !Array.isArray(manifest.tools)
-    ? manifest.tools
-    : null;
-  if (!tools) {
-    return null;
-  }
-
-  const exactMatch = tools[normalizedToolId];
-  if (exactMatch && typeof exactMatch === "object" && !Array.isArray(exactMatch)) {
-    return exactMatch;
-  }
-
-  if (normalizedToolId === "palette-browser") {
-    const singularPalette = tools.palette;
-    if (singularPalette && typeof singularPalette === "object" && !Array.isArray(singularPalette)) {
-      return singularPalette;
-    }
-  }
-
-  return null;
-}
-
 function installWorkspaceScopedSamplePresetFetchShim(currentToolId, samplePresetPath) {
   if (typeof window === "undefined" || typeof window.fetch !== "function") {
     return;
@@ -729,7 +701,6 @@ function installWorkspaceScopedSamplePresetFetchShim(currentToolId, samplePreset
     const rawPreset = await response.clone().json().catch(() => null);
     const scopedPreset = selectWorkspaceScopedToolPreset(rawPreset, normalizedToolId);
     if (!scopedPreset) {
-      workspaceScopedToolPresetForStatus = null;
       return response;
     }
     workspaceScopedToolPresetForStatus = scopedPreset;
@@ -757,19 +728,16 @@ async function primeWorkspaceScopedToolPresetForStatus(toolId, samplePresetPath)
   try {
     const response = await window.fetch(normalizedSamplePresetPath, { cache: "no-store" });
     if (!response.ok) {
-      workspaceScopedToolPresetForStatus = null;
       return null;
     }
     const rawPreset = await response.json();
     const scopedPreset = selectWorkspaceScopedToolPreset(rawPreset, normalizedToolId);
     if (!scopedPreset) {
-      workspaceScopedToolPresetForStatus = null;
       return null;
     }
     workspaceScopedToolPresetForStatus = scopedPreset;
     return scopedPreset;
   } catch {
-    workspaceScopedToolPresetForStatus = null;
     return null;
   }
 }
@@ -1467,11 +1435,9 @@ function isAssetCompatibleWithTool(toolId = "", asset = null) {
 
 function renderToolAssetBadge(toolId = "") {
   const normalizedToolId = normalizeTextValue(toolId).toLowerCase();
-  const workspaceBoundToolState = resolveWorkspaceManifestToolStateForStatus(normalizedToolId);
-  const statusSourceToolState = workspaceBoundToolState || workspaceScopedToolPresetForStatus;
   const embeddedPayloadSummary = summarizeEmbeddedToolPayloadDocument(
     normalizedToolId,
-    statusSourceToolState
+    workspaceScopedToolPresetForStatus
   );
   const acceptedKinds = resolveAcceptedAssetKindsForTool(normalizedToolId);
   if (normalizedToolId === "palette-browser") {
@@ -1572,7 +1538,13 @@ function renderToolLinks(currentToolId) {
     if (!lockState.workspaceReady) {
       return true;
     }
-    if (!lockState.paletteReady && toolId !== "palette-browser") {
+    if (toolId === "palette-browser") {
+      return false;
+    }
+    if (lockState.hasToolState(toolId)) {
+      return false;
+    }
+    if (!lockState.paletteReady) {
       return true;
     }
     return false;
@@ -2262,7 +2234,6 @@ function ensureRuntimeMonitoring() {
 }
 
 async function initPlatformShell() {
-  workspaceScopedToolPresetForStatus = null;
   ensureRuntimeMonitoring();
 
   const currentToolId = document.body.dataset.toolId || "";