Skip to content

Commit 9579c22

Browse files
author
DavidQ
committed
Fix Asset Manager V2 form controls status logging and coverage labels - PR_26126_089-asset-manager-v2-form-status-and-controls
1 parent b97104f commit 9579c22

15 files changed

Lines changed: 756 additions & 1144 deletions

‎docs/dev/reports/PR_26126_089_asset_manager_v2_manual_validation_notes.md‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
# PR_26126_089 Asset Manager V2 Manual Validation Notes
2+
3+
Date: 2026-05-06
4+
5+
## Validation Performed
6+
7+
- Ran `npm run test:workspace-v2`.
8+
- Ran a focused Asset Manager V2 Playwright check during implementation.
9+
- Ran JS syntax checks on touched Asset Manager V2 modules, the Playwright baseline, and the coverage reporter helper.
10+
- Ran `git diff --check`.
11+
- Confirmed no JSON files changed.
12+
13+
## Results
14+
15+
- `npm run test:workspace-v2`: passed, 10 tests.
16+
- Asset Manager V2 controls: passed. ID and Path are read-only, Role has a current-kind allowed-role tooltip, and Undo/Redo have a dedicated History section.
17+
- Status-only messaging: passed. Validation, picker, add, delete, undo, and redo messages are routed only to Status.
18+
- Tile X delete behavior: passed. Asset tiles use an inline X delete control left of `type:role` and no separate Delete button.
19+
- Removed validation UI: passed. `assetValidationMessage` is no longer rendered.
20+
- Playwright/V8 coverage naming: passed. Coverage report labels `Palette Manager V2`.
21+
- PR validation gate: passed. The full workspace-v2 validation suite ran with Asset Manager V2 coverage included; no Palette Manager-only gate was used.
22+
- Sample JSON: passed. No JSON files were modified.
23+
24+
## Reports
25+
26+
- `docs/dev/reports/playwright_v8_coverage_report.txt`
27+
- `docs/dev/reports/coverage_changed_js_guardrail.txt`
28+
- `docs/dev/reports/PR_26126_089_asset_manager_v2_ui_control_notes.md`
29+
- `docs/dev/reports/PR_26126_089_asset_manager_v2_status_log_notes.md`
30+
- `docs/dev/reports/PR_26126_089_asset_manager_v2_manual_validation_notes.md`

‎docs/dev/reports/PR_26126_089_asset_manager_v2_status_log_notes.md‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# PR_26126_089 Asset Manager V2 Status Log Notes
2+
3+
Date: 2026-05-06
4+
5+
## Status Routing
6+
7+
- Picker validation messages route to the Status log only.
8+
- Add Asset success and rejection messages route to the Status log only.
9+
- Delete messages route to the Status log only.
10+
- Undo and Redo messages route to the Status log only.
11+
- Schema validation failures route to the Status log only.
12+
- Duplicate ID and missing-role validation messages route to the Status log only.
13+
14+
## Removed Visible Message Surfaces
15+
16+
- `#assetValidationMessage` was removed from the Asset Controls UI.
17+
- `#assetSelectedFileText` was removed from the Asset Controls UI.
18+
- Output Summary continues to render only the current schema payload.
19+
- Asset tiles continue to show compact asset identity only: X delete control, `type:role`, and ID.
20+
21+
## Validation
22+
23+
- `npm run test:workspace-v2`: passed, 10 tests.
24+
- Playwright validates that validation, picker, add, delete, undo, and redo activity is reported through Status without echoing transient messages into Asset Controls, Output Summary, or asset tiles.

‎docs/dev/reports/PR_26126_089_asset_manager_v2_ui_control_notes.md‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# PR_26126_089 Asset Manager V2 UI Control Notes
2+
3+
Date: 2026-05-06
4+
5+
## Control Changes
6+
7+
- Asset Manager V2 ID is read-only and cannot be edited directly.
8+
- Asset Manager V2 Path is read-only and cannot be edited directly.
9+
- Asset state changes continue through Pick Asset File, Add Asset, tile selection, tile delete, Undo, and Redo.
10+
- Undo and Redo moved into a dedicated Asset history control section.
11+
- The Role dropdown keeps its allowed options based on the selected kind.
12+
- The Role dropdown exposes a tooltip listing allowed roles for the currently selected kind.
13+
- Asset tiles no longer render a separate Delete button below the tile content.
14+
- Each asset tile renders one tile button with an inline X delete control positioned to the left of the `type:role` display.
15+
- `assetValidationMessage` and selected-file picker message text were removed from the visible Asset Controls UI.
16+
17+
## Coverage Naming
18+
19+
- Playwright/V8 coverage display naming now reports `Palette Manager V2`.
20+
- The PR validation gate remains the workspace-v2 suite with Asset Manager V2 coverage included.
21+
- No Palette Manager-only validation was used as the PR gate.
22+
23+
## Validation
24+
25+
- `npm run test:workspace-v2`: passed, 10 tests.
26+
- Playwright validates read-only ID/Path controls, Role tooltip contents, dedicated Undo/Redo section, inline tile X delete placement, and removed validation/picker message controls.
27+
- `docs/dev/reports/playwright_v8_coverage_report.txt` shows `Palette Manager V2` and `Asset Manager V2` coverage entries.

‎docs/dev/reports/codex_changed_files.txt‎

Lines changed: 18 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,32 @@
11
# git status --short
22
M docs/dev/reports/coverage_changed_js_guardrail.txt
33
M docs/dev/reports/playwright_v8_coverage_report.txt
4+
M tests/helpers/playwrightV8CoverageReporter.mjs
45
M tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
5-
M tools/asset-manager-v2/README.md
66
M tools/asset-manager-v2/index.html
77
M tools/asset-manager-v2/js/AssetManagerV2App.js
88
M tools/asset-manager-v2/js/bootstrap.js
99
M tools/asset-manager-v2/js/controls/AssetCatalogControl.js
1010
M tools/asset-manager-v2/js/controls/AssetFormControl.js
11-
M tools/asset-manager-v2/js/services/AssetSchemaValidator.js
1211
M tools/asset-manager-v2/styles/assetManager.css
13-
M tools/index.html
14-
?? docs/dev/reports/PR_26126_088_asset_manager_v2_manual_validation_notes.md
15-
?? docs/dev/reports/PR_26126_088_asset_manager_v2_schema_consistency_notes.md
16-
?? docs/dev/reports/PR_26126_088_asset_manager_v2_ui_layout_notes.md
17-
?? docs/dev/reports/PR_26126_088_asset_manager_v2_undo_redo_behavior_notes.md
12+
?? docs/dev/reports/PR_26126_089_asset_manager_v2_manual_validation_notes.md
13+
?? docs/dev/reports/PR_26126_089_asset_manager_v2_status_log_notes.md
14+
?? docs/dev/reports/PR_26126_089_asset_manager_v2_ui_control_notes.md
1815

1916
# git ls-files --others --exclude-standard
20-
docs/dev/reports/PR_26126_088_asset_manager_v2_manual_validation_notes.md
21-
docs/dev/reports/PR_26126_088_asset_manager_v2_schema_consistency_notes.md
22-
docs/dev/reports/PR_26126_088_asset_manager_v2_ui_layout_notes.md
23-
docs/dev/reports/PR_26126_088_asset_manager_v2_undo_redo_behavior_notes.md
17+
docs/dev/reports/PR_26126_089_asset_manager_v2_manual_validation_notes.md
18+
docs/dev/reports/PR_26126_089_asset_manager_v2_status_log_notes.md
19+
docs/dev/reports/PR_26126_089_asset_manager_v2_ui_control_notes.md
2420

2521
# git diff --stat
26-
docs/dev/reports/coverage_changed_js_guardrail.txt | 10 +-
27-
docs/dev/reports/playwright_v8_coverage_report.txt | 26 +--
28-
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 155 ++++++++++++++++--
29-
tools/asset-manager-v2/README.md | 4 +-
30-
tools/asset-manager-v2/index.html | 23 +--
31-
tools/asset-manager-v2/js/AssetManagerV2App.js | 181 +++++++++++++++++++--
32-
tools/asset-manager-v2/js/bootstrap.js | 3 +
33-
.../js/controls/AssetCatalogControl.js | 28 ++--
34-
.../js/controls/AssetFormControl.js | 54 +++++-
35-
.../js/services/AssetSchemaValidator.js | 14 +-
36-
tools/asset-manager-v2/styles/assetManager.css | 112 ++++++++++++-
37-
tools/index.html | 2 +-
38-
12 files changed, 525 insertions(+), 87 deletions(-)
22+
docs/dev/reports/coverage_changed_js_guardrail.txt | 9 ++--
23+
docs/dev/reports/playwright_v8_coverage_report.txt | 25 +++++-----
24+
tests/helpers/playwrightV8CoverageReporter.mjs | 2 +-
25+
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 56 ++++++++++++++--------
26+
tools/asset-manager-v2/index.html | 15 +++---
27+
tools/asset-manager-v2/js/AssetManagerV2App.js | 29 ++++++-----
28+
tools/asset-manager-v2/js/bootstrap.js | 2 -
29+
.../js/controls/AssetCatalogControl.js | 16 ++++---
30+
.../js/controls/AssetFormControl.js | 24 +++-------
31+
tools/asset-manager-v2/styles/assetManager.css | 51 ++++++++++++++++----
32+
10 files changed, 134 insertions(+), 95 deletions(-)

0 commit comments

Comments
 (0)