|
| 1 | +# PR_26124_071-palette-manager-remove-tools-shared-shell Report |
| 2 | + |
| 3 | +## Summary |
| 4 | +Palette Manager V2 no longer loads or depends on `tools/shared/platformShell.css` or `tools/shared/platformShell.js`. |
| 5 | + |
| 6 | +## Changes |
| 7 | +- Removed direct shared platform shell CSS/JS imports from Palette Manager V2. |
| 8 | +- Added `paletteManagerShell.js` as a local shell owner for: |
| 9 | + - header frame rendering, |
| 10 | + - status bar rendering, |
| 11 | + - Hide Header and Details / Show Header and Details summary state, |
| 12 | + - fullscreen state class/attribute synchronization. |
| 13 | +- Added local CSS for the shell frame/status/app bounds/resize/fullscreen/control styles that Palette Manager still requires. |
| 14 | +- Kept existing asserted layout class names such as `tools-platform-layout-grid` and `tools-platform-resize-panel`, but the behavior is now supplied by Palette Manager-local CSS/JS. |
| 15 | + |
| 16 | +## Preserved |
| 17 | +- Current palette behavior. |
| 18 | +- menuSample layout and actions. |
| 19 | +- accordionV2 behavior. |
| 20 | +- User/source grid scrolling. |
| 21 | +- Right-column spacing and sizing behavior. |
| 22 | +- Fullscreen/header state behavior. |
| 23 | +- EOF pin-button override and pin size/styling. |
| 24 | +- Manual CSS comments were preserved. |
| 25 | + |
| 26 | +## Validation |
| 27 | +- `node --check tools/palette-manager-v2/paletteManagerShell.js`: PASS. |
| 28 | +- `node --check tools/palette-manager-v2/main.js`: PASS. |
| 29 | +- Palette Manager tools/shared shell dependency validation: PASS. |
| 30 | +- Palette Manager CSS structural validation: PASS. |
| 31 | +- Targeted Palette Manager local shell Playwright validation: PASS. |
| 32 | +- `node tests/tools/ToolLayoutDockingControlNormalization.test.mjs`: PASS. |
| 33 | +- `node tests/tools/ToolEntryLaunchContract.test.mjs`: PASS. |
| 34 | +- `git diff --check -- tools/palette-manager-v2/index.html tools/palette-manager-v2/paletteManagerV2.css tools/palette-manager-v2/paletteManagerShell.js`: PASS with Git LF-to-CRLF warnings for changed HTML/CSS. |
| 35 | +- `npm run test:workspace-v2`: FAIL, `package.json` does not define `test:workspace-v2`. |
| 36 | +- Full samples smoke test: skipped because this PR is Palette Manager V2-only and full samples were explicitly out of scope. |
| 37 | + |
| 38 | +## Manual Test Notes |
| 39 | +1. Open Palette Manager V2. |
| 40 | +2. Confirm the header/details area renders on load and the summary says `Hide Header and Details`. |
| 41 | +3. Click Hide Header and Details and confirm the header collapses and the app remains usable in the wide/fullscreen layout. |
| 42 | +4. Exit fullscreen or show details and confirm the header returns. |
| 43 | +5. Confirm menuSample, accordions, tile grids, right column, pin buttons, import/export, and palette editing behavior are unchanged. |
0 commit comments