Skip to content

Commit 94edc91

Browse files
author
DavidQ
committed
Remove Palette Manager V2 dependency on tools shared platform shell - PR_26124_071-palette-manager-remove-tools-shared-shell
1 parent 8b00c8a commit 94edc91

11 files changed

Lines changed: 1171 additions & 169 deletions

File tree

docs/dev/codex_commands.md

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,28 @@
1-
# Codex Commands - PR_26124_070-palette-manager-css-dead-override-cleanup
1+
# Codex Commands - PR_26124_071-palette-manager-remove-tools-shared-shell
22

33
```bash
4-
npx @openai/codex run --model gpt-5.5 --reasoning high "Run full workflow for PR_26124_070-palette-manager-css-dead-override-cleanup. Follow PROJECT_INSTRUCTIONS.md exactly."
4+
npx @openai/codex run --model gpt-5.5 --reasoning high "Run full workflow for PR_26124_071-palette-manager-remove-tools-shared-shell. Follow PROJECT_INSTRUCTIONS.md exactly."
55
```
66

77
## Validation Commands
88

99
```bash
10-
node --input-type=module <css structural cleanup validation>
11-
git diff --check -- tools/palette-manager-v2/paletteManagerV2.css
10+
node --check tools/palette-manager-v2/paletteManagerShell.js
11+
node --check tools/palette-manager-v2/main.js
12+
node --input-type=module <tools/shared shell dependency validation>
13+
node --input-type=module <css structural validation>
14+
node --input-type=module <targeted Palette Manager local shell Playwright validation>
15+
node tests/tools/ToolLayoutDockingControlNormalization.test.mjs
16+
node tests/tools/ToolEntryLaunchContract.test.mjs
17+
git diff --check -- tools/palette-manager-v2/index.html tools/palette-manager-v2/paletteManagerV2.css tools/palette-manager-v2/paletteManagerShell.js
1218
npm run test:workspace-v2
1319
```
1420

1521
## Playwright
1622

17-
`npm run test:workspace-v2` was requested as the Playwright validation gate. It failed because `package.json` does not define the `test:workspace-v2` script.
23+
Targeted Palette Manager V2 local shell Playwright validation passed. It confirmed the page no longer loads `platformShell` assets, local header/status render, hide/show summary behavior works, Palette Manager controls render, and menuSample actions remain centered.
24+
25+
`npm run test:workspace-v2` was also requested as the default gate. It failed because `package.json` does not define the `test:workspace-v2` script.
1826

1927
## Full Samples
2028

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Remove dead Palette Manager CSS overrides - PR_26124_070-palette-manager-css-dead-override-cleanup
1+
Remove Palette Manager dependency on tools shared shell - PR_26124_071-palette-manager-remove-tools-shared-shell
Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
# PR_26124_071-palette-manager-remove-tools-shared-shell Report
2+
3+
## Summary
4+
Palette Manager V2 no longer loads or depends on `tools/shared/platformShell.css` or `tools/shared/platformShell.js`.
5+
6+
## Changes
7+
- Removed direct shared platform shell CSS/JS imports from Palette Manager V2.
8+
- Added `paletteManagerShell.js` as a local shell owner for:
9+
- header frame rendering,
10+
- status bar rendering,
11+
- Hide Header and Details / Show Header and Details summary state,
12+
- fullscreen state class/attribute synchronization.
13+
- Added local CSS for the shell frame/status/app bounds/resize/fullscreen/control styles that Palette Manager still requires.
14+
- Kept existing asserted layout class names such as `tools-platform-layout-grid` and `tools-platform-resize-panel`, but the behavior is now supplied by Palette Manager-local CSS/JS.
15+
16+
## Preserved
17+
- Current palette behavior.
18+
- menuSample layout and actions.
19+
- accordionV2 behavior.
20+
- User/source grid scrolling.
21+
- Right-column spacing and sizing behavior.
22+
- Fullscreen/header state behavior.
23+
- EOF pin-button override and pin size/styling.
24+
- Manual CSS comments were preserved.
25+
26+
## Validation
27+
- `node --check tools/palette-manager-v2/paletteManagerShell.js`: PASS.
28+
- `node --check tools/palette-manager-v2/main.js`: PASS.
29+
- Palette Manager tools/shared shell dependency validation: PASS.
30+
- Palette Manager CSS structural validation: PASS.
31+
- Targeted Palette Manager local shell Playwright validation: PASS.
32+
- `node tests/tools/ToolLayoutDockingControlNormalization.test.mjs`: PASS.
33+
- `node tests/tools/ToolEntryLaunchContract.test.mjs`: PASS.
34+
- `git diff --check -- tools/palette-manager-v2/index.html tools/palette-manager-v2/paletteManagerV2.css tools/palette-manager-v2/paletteManagerShell.js`: PASS with Git LF-to-CRLF warnings for changed HTML/CSS.
35+
- `npm run test:workspace-v2`: FAIL, `package.json` does not define `test:workspace-v2`.
36+
- Full samples smoke test: skipped because this PR is Palette Manager V2-only and full samples were explicitly out of scope.
37+
38+
## Manual Test Notes
39+
1. Open Palette Manager V2.
40+
2. Confirm the header/details area renders on load and the summary says `Hide Header and Details`.
41+
3. Click Hide Header and Details and confirm the header collapses and the app remains usable in the wide/fullscreen layout.
42+
4. Exit fullscreen or show details and confirm the header returns.
43+
5. Confirm menuSample, accordions, tile grids, right column, pin buttons, import/export, and palette editing behavior are unchanged.
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
# git status --short
22
M docs/dev/codex_commands.md
33
M docs/dev/commit_comment.txt
4-
A docs/dev/reports/PR_26124_070_report.md
5-
A docs/pr/PR_26124_070-palette-manager-css-dead-override-cleanup/APPLY_PR.md
6-
A docs/pr/PR_26124_070-palette-manager-css-dead-override-cleanup/BUILD_PR.md
7-
A docs/pr/PR_26124_070-palette-manager-css-dead-override-cleanup/PLAN_PR.md
4+
A docs/dev/reports/PR_26124_071_report.md
5+
A docs/pr/PR_26124_071-palette-manager-remove-tools-shared-shell/APPLY_PR.md
6+
A docs/pr/PR_26124_071-palette-manager-remove-tools-shared-shell/BUILD_PR.md
7+
A docs/pr/PR_26124_071-palette-manager-remove-tools-shared-shell/PLAN_PR.md
8+
M tools/palette-manager-v2/index.html
9+
A tools/palette-manager-v2/paletteManagerShell.js
810
M tools/palette-manager-v2/paletteManagerV2.css
9-
?? tools/common.zip
10-
?? tools/palette-manager-v2.zip
1111

1212
# git diff --stat
1313
(no output)

0 commit comments

Comments
 (0)