Skip to content

Commit 8d2c646

Browse files
author
DavidQ
committed
Remove legacy tool references from game manifests after V2 validation - PR_26139_020-remove-legacy-tool-references-from-game-manifests
1 parent e42cc95 commit 8d2c646

10 files changed

Lines changed: 45 additions & 931 deletions

File tree

‎docs/dev/reports/PR_26139_020-remove-legacy-tool-references-from-game-manifests_report.md‎

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
# PR_26139_020 Remove Legacy Tool References From Game Manifests
2+
3+
## Summary
4+
- Removed legacy `asset-browser`, `primitive-skin-editor`, and `palette-browser` entries from game manifests that still carried them.
5+
- Preserved active V2/current tooling payloads, including each manifest's `asset-manager-v2` preview asset data.
6+
- Added the required Workspace Manager V2 schema preload for `asset-manager-v2` so current game manifests validate through the browser Workspace Manager path.
7+
8+
## Manifest Cleanup
9+
- `games/AITargetDummy/game.manifest.json`: removed `asset-browser`, `primitive-skin-editor`, `palette-browser`.
10+
- `games/bouncing-ball/game.manifest.json`: removed `primitive-skin-editor`, `palette-browser`.
11+
- `games/breakout/game.manifest.json`: removed `primitive-skin-editor`, `palette-browser`.
12+
- `games/Pacman/game.manifest.json`: removed `asset-browser`, `primitive-skin-editor`, `palette-browser`.
13+
- `games/SolarSystem/game.manifest.json`: removed `primitive-skin-editor`, `palette-browser`.
14+
- `games/SpaceDuel/game.manifest.json`: removed `primitive-skin-editor`, `asset-browser`, `palette-browser`.
15+
- `games/SpaceInvaders/game.manifest.json`: removed `primitive-skin-editor`, `asset-browser`, `palette-browser`.
16+
- `games/vector-arcade-sample/game.manifest.json`: removed `primitive-skin-editor`, `asset-browser`, `palette-browser`.
17+
18+
## Active Replacements Preserved
19+
- All 11 game manifests retain `tools.asset-manager-v2`.
20+
- Existing active V2/current tool entries such as `palette-manager-v2`, `object-vector-studio-v2`, `sprite-editor`, `tile-map-editor`, `parallax-editor`, `svg-asset-studio`, and `preview-generator-tool` were left intact.
21+
- Preview asset paths remain manifest-owned; no HTML/runtime preview fallback was added.
22+
23+
## Validation
24+
- PASS: `npm run build:manifest`
25+
- PASS: `node scripts/validate-json-contracts.mjs --mode=games --details`
26+
- `game_manifest_schema_validation: total=11 invalid=0`
27+
- PASS: `rg -n '"(asset-browser|primitive-skin-editor|palette-browser)"' games -g 'game.manifest.json'`
28+
- No remaining matches in game manifests.
29+
- PASS: `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list --grep "discovers Active Game options from selected repo manifests"`
30+
- PASS: `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list --grep "uses header lifecycle controls and launches tools from fixed Workspace Manager V2 tiles"`
31+
32+
## Notes
33+
- Workspace Manager V2 browser validation previously failed current game manifests with `root.tools.asset-manager-v2: unresolved schema reference tools/asset-manager-v2.schema.json`. The manifest schema requires `asset-manager-v2`, so Workspace Manager now preloads and registers that schema alongside the other referenced tool schemas.

‎games/AITargetDummy/game.manifest.json‎

Lines changed: 0 additions & 84 deletions
Original file line numberDiff line numberDiff line change
@@ -28,90 +28,6 @@
2828
"source": "manifest"
2929
}
3030
}
31-
},
32-
"asset-browser": {
33-
"assets": {
34-
"image.ai-target-dummy.preview": {
35-
"path": "games/AITargetDummy/assets/images/preview.svg",
36-
"kind": "image",
37-
"source": "workspace-manager"
38-
}
39-
},
40-
"schema": "html-js-gaming.tool.asset-browser",
41-
"version": 1,
42-
"name": "Asset Browser",
43-
"source": "manifest"
44-
},
45-
"primitive-skin-editor": {
46-
"skins": [],
47-
"schema": "html-js-gaming.tool.primitive-skin-editor",
48-
"version": 1,
49-
"name": "Primitive Skin Editor",
50-
"source": "manifest"
51-
},
52-
"palette-browser": {
53-
"schema": "html-js-gaming.tool.palette-browser",
54-
"version": 1,
55-
"name": "Palette Browser",
56-
"source": "manifest",
57-
"palette": {
58-
"schema": "html-js-gaming.palette",
59-
"version": 1,
60-
"name": "AI Target Dummy Palette",
61-
"source": "manifest-and-runtime-color-scan",
62-
"swatches": [
63-
{
64-
"symbol": "0",
65-
"hex": "#FACC15",
66-
"name": "Color 1"
67-
},
68-
{
69-
"symbol": "1",
70-
"hex": "#93C5FD",
71-
"name": "Color 2"
72-
},
73-
{
74-
"symbol": "2",
75-
"hex": "#334155",
76-
"name": "Color 3"
77-
},
78-
{
79-
"symbol": "3",
80-
"hex": "#E2E8F0",
81-
"name": "Color 4"
82-
},
83-
{
84-
"symbol": "4",
85-
"hex": "#94A3B8",
86-
"name": "Color 5"
87-
},
88-
{
89-
"symbol": "5",
90-
"hex": "#070B14",
91-
"name": "Color 6"
92-
},
93-
{
94-
"symbol": "6",
95-
"hex": "#0F172A",
96-
"name": "Color 7"
97-
},
98-
{
99-
"symbol": "7",
100-
"hex": "#38BDF8",
101-
"name": "Color 8"
102-
},
103-
{
104-
"symbol": "8",
105-
"hex": "#22C55E",
106-
"name": "Color 9"
107-
},
108-
{
109-
"symbol": "9",
110-
"hex": "#EF4444",
111-
"name": "Color 10"
112-
}
113-
]
114-
}
11531
}
11632
}
11733
}

‎games/Pacman/game.manifest.json‎

Lines changed: 0 additions & 89 deletions
Original file line numberDiff line numberDiff line change
@@ -28,95 +28,6 @@
2828
"source": "manifest"
2929
}
3030
}
31-
},
32-
"asset-browser": {
33-
"assets": {
34-
"image.pacman.preview-svg": {
35-
"path": "games/Pacman/assets/images/preview.svg",
36-
"kind": "image",
37-
"source": "workspace-manager"
38-
},
39-
"image.pacman.preview-png": {
40-
"path": "games/Pacman/assets/images/preview.png",
41-
"kind": "image",
42-
"source": "workspace-manager"
43-
}
44-
},
45-
"schema": "html-js-gaming.tool.asset-browser",
46-
"version": 1,
47-
"name": "Asset Browser",
48-
"source": "manifest"
49-
},
50-
"primitive-skin-editor": {
51-
"skins": [],
52-
"schema": "html-js-gaming.tool.primitive-skin-editor",
53-
"version": 1,
54-
"name": "Primitive Skin Editor",
55-
"source": "manifest"
56-
},
57-
"palette-browser": {
58-
"schema": "html-js-gaming.tool.palette-browser",
59-
"version": 1,
60-
"name": "Palette Browser",
61-
"source": "manifest",
62-
"palette": {
63-
"schema": "html-js-gaming.palette",
64-
"version": 1,
65-
"name": "Pacman Palette",
66-
"source": "manifest-and-runtime-color-scan",
67-
"swatches": [
68-
{
69-
"symbol": "0",
70-
"hex": "#020617",
71-
"name": "Color 1"
72-
},
73-
{
74-
"symbol": "1",
75-
"hex": "#0B1329",
76-
"name": "Color 2"
77-
},
78-
{
79-
"symbol": "2",
80-
"hex": "#020B1E",
81-
"name": "Color 3"
82-
},
83-
{
84-
"symbol": "3",
85-
"hex": "#1E3A8A",
86-
"name": "Color 4"
87-
},
88-
{
89-
"symbol": "4",
90-
"hex": "#1D4ED8",
91-
"name": "Color 5"
92-
},
93-
{
94-
"symbol": "5",
95-
"hex": "#38BDF8",
96-
"name": "Color 6"
97-
},
98-
{
99-
"symbol": "6",
100-
"hex": "#FACC15",
101-
"name": "Color 7"
102-
},
103-
{
104-
"symbol": "7",
105-
"hex": "#EF4444",
106-
"name": "Color 8"
107-
},
108-
{
109-
"symbol": "8",
110-
"hex": "#F472B6",
111-
"name": "Color 9"
112-
},
113-
{
114-
"symbol": "9",
115-
"hex": "#22D3EE",
116-
"name": "Color 10"
117-
}
118-
]
119-
}
12031
}
12132
}
12233
}

0 commit comments

Comments
 (0)