BUILD PR: centralize asStringArray across exact preset/group-registry batch.

Author: DavidQ

docs/dev/CODEX_COMMANDS.md

@@ -1,10 +1,10 @@
 MODEL: GPT-5.3-codex
 REASONING: high
 COMMAND:
-Execute docs/pr/BUILD_PR_SHARED_EXTRACTION_40_CLONE_SNAPSHOT_NETWORK_SAMPLE_C_BATCH.md exactly.
+Execute docs/pr/BUILD_PR_SHARED_EXTRACTION_41_AS_STRING_ARRAY_PRESET_BATCH.md exactly.
 Edit only these files:
-- src/shared/utils/snapshotCloneUtils.js (new file)
-- games/network_sample_c/game/ReconciliationLayerAdapter.js
-- games/network_sample_c/game/StateTimelineBuffer.js
+- src/shared/utils/arrayUtils.js (only to add/export asStringArray if missing, or minimum export fix if present)
+- tools/dev/advanced/debugPanelGroupRegistry.js
+- tools/dev/presets/debugPresetRegistry.js
 Do not expand scope.
-Package the delta output to <project folder>/tmp/BUILD_PR_SHARED_EXTRACTION_40_CLONE_SNAPSHOT_NETWORK_SAMPLE_C_BATCH_delta.zip
+Package the delta output to <project folder>/tmp/BUILD_PR_SHARED_EXTRACTION_41_AS_STRING_ARRAY_PRESET_BATCH_delta.zip

docs/dev/COMMIT_COMMENT.txt

@@ -1 +1 @@
-BUILD PR: centralize cloneSnapshot across exact network_sample_c batch.
+BUILD PR: centralize asStringArray across exact preset/group-registry batch.

docs/dev/NEXT_COMMAND.txt

@@ -1 +1 @@
-Next: continue duplicate-family extraction from the provided duplicate report.
+Next: run BUILD_PR_SHARED_EXTRACTION_42_CREATE_RESULT_COMMANDPACK_BATCH after this batch.

docs/dev/reports/change_summary.txt

@@ -1 +1 @@
-Rebuilt 40 as an execution-grade batch using the exact duplicate-report file list for cloneSnapshot(snapshot).
+Execution-grade batch for asStringArray using the exact duplicate-report file list.

docs/pr/BUILD_PR_SHARED_EXTRACTION_41_AS_STRING_ARRAY_PRESET_BATCH.md

@@ -0,0 +1,87 @@
+# BUILD_PR_SHARED_EXTRACTION_41_AS_STRING_ARRAY_PRESET_BATCH
+
+## Purpose
+Centralize duplicated `asStringArray(value)` implementations across the exact preset/group-registry batch identified in the duplicate report.
+
+## Single PR Purpose
+Normalize ONLY this helper:
+
+- `asStringArray(value)`
+
+## Exact Files Allowed
+
+### Shared source
+1. `src/shared/utils/arrayUtils.js`
+
+### Consumer files
+2. `tools/dev/advanced/debugPanelGroupRegistry.js`
+3. `tools/dev/presets/debugPresetRegistry.js`
+
+Do not edit any other file.
+
+## Source of Truth
+This exact scope comes from the provided duplicate report entry for:
+
+`function asStringArray(value)`
+
+Only the 2 listed consumer files are in scope.
+
+## Shared Helper Assumption
+Use the existing shared utility:
+
+`src/shared/utils/arrayUtils.js`
+
+Fail fast unless that file exists and exports:
+
+- `asStringArray`
+
+If the file exists and contains `asStringArray` but does not export it correctly, the only allowed shared-file change is the minimum export-only fix.
+
+If the helper does not exist in the shared file, add ONLY this helper to `src/shared/utils/arrayUtils.js` by copying one existing local implementation exactly, with no behavior change and no unrelated edits.
+
+## Exact Consumer Changes
+For each of the 2 listed consumer files:
+
+If the file contains a local function definition matching:
+```js
+function asStringArray(value)
+```
+then:
+- remove the local `asStringArray(value)` function definition
+- import `asStringArray` from the correct relative path to:
+  - `src/shared/utils/arrayUtils.js`
+- if the file already imports from that module, add `asStringArray` with the minimum safe edit
+- do not duplicate imports
+- do not touch unrelated helpers
+- do not change logic
+
+If a listed file already imports and uses shared `asStringArray`, leave it unchanged.
+
+## Relative Import Rule
+Use the correct relative path from each consumer file to:
+
+`src/shared/utils/arrayUtils.js`
+
+Do not use aliases.
+Do not change `.js` extension usage.
+
+## Hard Constraints
+- no engine changes outside `src/shared/utils/arrayUtils.js`
+- no files outside the 2 listed consumers
+- no repo-wide array helper cleanup
+- no behavior changes
+- keep one PR purpose only
+
+## Validation Checklist
+1. Confirm no more than the 3 listed files changed
+2. Confirm `src/shared/utils/arrayUtils.js` exports `asStringArray`
+3. Confirm local `function asStringArray(value)` definitions no longer exist in changed listed consumer files
+4. Confirm changed consumer files import `asStringArray` from the correct relative path to `src/shared/utils/arrayUtils.js`
+5. Confirm no unrelated files changed
+6. Confirm no behavior changes were made
+
+## Non-Goals
+- no cleanup of `ensureArray`
+- no cleanup of `asArray`
+- no cleanup outside the 2 listed consumer files
+- no refactor beyond this exact duplicate-removal batch

src/shared/utils/arrayUtils.js

@@ -1,3 +1,19 @@
+import { sanitizeText } from "../../engine/debug/inspectors/shared/inspectorUtils.js";
+
 export function ensureArray(value) {
   return Array.isArray(value) ? value : [];
 }
+
+export function asStringArray(value) {
+  if (!Array.isArray(value)) {
+    return [];
+  }
+  const unique = new Set();
+  value.forEach((item) => {
+    const token = sanitizeText(String(item));
+    if (token) {
+      unique.add(token);
+    }
+  });
+  return Array.from(unique.values());
+}

tools/dev/advanced/debugPanelGroupRegistry.js

@@ -6,22 +6,9 @@ debugPanelGroupRegistry.js
 */
 
 import { sanitizeText } from "../../../src/engine/debug/inspectors/shared/inspectorUtils.js";
+import { asStringArray } from "../../../src/shared/utils/arrayUtils.js";
 import { cloneJson } from "../../../src/shared/utils/jsonUtils.js";
 
-function asStringArray(value) {
-  if (!Array.isArray(value)) {
-    return [];
-  }
-  const unique = new Set();
-  value.forEach((item) => {
-    const token = sanitizeText(String(item));
-    if (token) {
-      unique.add(token);
-    }
-  });
-  return Array.from(unique.values());
-}
-
 function normalizeGroupDescriptor(descriptor = {}) {
   const groupId = sanitizeText(descriptor.groupId);
   const title = sanitizeText(descriptor.title) || groupId;

tools/dev/presets/debugPresetRegistry.js

@@ -6,23 +6,10 @@ debugPresetRegistry.js
 */
 
 import { sanitizeText } from "../../../src/engine/debug/inspectors/shared/inspectorUtils.js";
+import { asStringArray } from "../../../src/shared/utils/arrayUtils.js";
 import { isObject } from "../../../src/shared/utils/objectUtils.js";
 import { cloneJson } from "../../../src/shared/utils/jsonUtils.js";
 
-function asStringArray(value) {
-  if (!Array.isArray(value)) {
-    return [];
-  }
-  const unique = new Set();
-  value.forEach((item) => {
-    const token = sanitizeText(String(item));
-    if (token) {
-      unique.add(token);
-    }
-  });
-  return Array.from(unique.values());
-}
-
 function normalizePresetDescriptor(descriptor = {}) {
   const presetId = sanitizeText(descriptor.presetId);
   const title = sanitizeText(descriptor.title) || presetId;