Re-engineer Vector Map Editor V2 with session-only data and shared header compliance - PR 11.191

Author: DavidQ

docs/dev/codex_commands.md

@@ -1,40 +1,22 @@
-# Codex Commands — PR_11_190
+# Codex Commands — PR_11_191 Vector Map Editor V2
 
 ## Model
+GPT-5.4-codex
 
-Use GPT-5.4 or GPT-5.3-codex.
-
-Reasoning: high.
-
-## Execute
+## Reasoning
+High
 
+## Command
 ```powershell
-cd C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming
+codex --model gpt-5.4-codex --reasoning high "Apply PR_11_191 exactly as documented in docs/pr/PR_11_191_VECTOR_MAP_EDITOR_V2_REENGINEER_PLAN.md. Re-engineer Vector Map Editor V2 only. Do not copy/paste legacy tool code. Do not modify schemas, samples, games, Workspace Manager v1, platformShell, assetUsageIntegration, or tools/shared. Use session-backed data only. Visible tool name must end with V2. Header must use the /index.html shared theme header mount: <div id="shared-theme-header"></div>. Keep implementation to a single tool file and single class unless the existing repo entry file requires only wiring to that one class. No helper classes, no alias variables, no abstraction layers, no fallback/default data. Add targeted validation and write findings to docs/dev/reports/PR_11_191_VECTOR_MAP_EDITOR_V2_VALIDATION.md. Do not run full samples smoke test."
 ```
 
+## Targeted Validation
 ```powershell
-codex --model gpt-5.4 --reasoning high "Apply docs/pr/PR_11_190_V2_REENGINEER_NAMING_HEADER_GUARD.md exactly. This is a re-engineer guard, not copy/paste. Update only the V2 tool lane needed for Palette Manager V2 and SVG Asset Studio V2 naming/header compliance. Do not change schemas, samples, games, Workspace Manager v1, platformShell, tools/shared, or legacy tools. Ensure every visible V2 tool name ends with V2. Ensure the V2 tools use the /index.html shared theme header mount <div id='shared-theme-header'></div>. Do not add fallback/default data. Do not introduce helper classes, abstraction layers, alias variables, or pass-through variables. Run targeted syntax checks only. Write validation notes to docs/dev/reports/PR_11_190_validation.md. Place the finished repo-structured ZIP at tmp/PR_11_190_20260501_01.zip."
-```
-
-## Required Output From Codex
-
-Codex must create:
-
-```text
-tmp/PR_11_190_20260501_01.zip
-docs/dev/reports/PR_11_190_validation.md
+node --check tools/vector-map-editor-v2/index.js
 ```
 
-## Expected Evidence
+If the exact file name differs after Codex creates the V2 lane structure, run `node --check` on the created Vector Map Editor V2 entry file only.
 
-The validation report must include:
-
-```text
-[REENGINEER_NOT_COPY_PASTE]
-[V2_NAME_SUFFIX_ENFORCED]
-[SHARED_THEME_HEADER_MOUNT]
-[NO_PLATFORM_SHELL]
-[NO_TOOLS_SHARED]
-[NO_FALLBACK_DATA]
-[TARGETED_VALIDATION_ONLY]
-```
+## Full Samples Smoke Test
+Skipped by default. Reason: this PR is limited to one V2 tool and does not modify shared sample loader/framework.

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Enforce V2 re-engineer naming and shared header guard for Palette/SVG tools - PR 11.190
+Re-engineer Vector Map Editor V2 with session-only data and shared header compliance - PR 11.191

docs/dev/reports/PR_11_191_VECTOR_MAP_EDITOR_V2_VALIDATION.md

@@ -0,0 +1,86 @@
+# PR_11_191 Vector Map Editor V2 Validation Report
+
+## Purpose
+Re-engineer Vector Map Editor V2 only as an isolated Tool V2 lane entry.
+
+## Changed Files
+- `tools/vector-map-editor-v2/index.js`
+- `docs/dev/reports/PR_11_191_VECTOR_MAP_EDITOR_V2_VALIDATION.md`
+
+Existing PR source doc was present in the worktree and included in the ZIP:
+- `docs/pr/PR_11_191_VECTOR_MAP_EDITOR_V2_REENGINEER_PLAN.md`
+
+## Implementation Evidence
+- `[VECTOR_MAP_V2_ENTRY]` is logged at entry.
+- `[SESSION_CONTEXT_READ]` is logged before session contract resolution.
+- `[VECTOR_MAP_V2_CONTRACT_LOADED]` is logged when the session contract loader runs.
+- The visible tool name is `Vector Map Editor V2`.
+- The page mounts the shared `/index.html` theme header with `<div id="shared-theme-header"></div>`.
+- The implementation is a single file with a single class: `VectorMapEditorV2`.
+- Session data is read from `toolboxaid.toolHost.context.<hostContextId>`.
+- URL `payloadJson` is written to session first, then re-read through `hostContextId`.
+- The only accepted vector map contract is `payloadJson.vectorMapDocument`.
+- Vector map rendering uses the session-backed document objects and points.
+- Empty and error states are explicit and actionable.
+
+## Required Checks
+- [x] Vector Map Editor V2 visible name ends with V2.
+- [x] Header uses `<div id="shared-theme-header"></div>`.
+- [x] No platformShell dependency.
+- [x] No assetUsageIntegration dependency.
+- [x] No `tools/shared/*` dependency.
+- [x] No fallback/default data.
+- [x] No schema changes.
+- [x] No sample changes.
+- [x] No game changes.
+- [x] Full samples smoke test skipped with reason.
+
+## Targeted Validation
+Command:
+
+```powershell
+node --check tools/vector-map-editor-v2/index.js
+```
+
+Result: passed.
+
+## Guard Scans
+Command:
+
+```powershell
+rg -n "platformShell|assetUsageIntegration|tools/shared|Workspace Manager|handoff|fallback|default|demo data|^import |^export " -- tools/vector-map-editor-v2/index.js
+```
+
+Result: passed. No matches.
+
+Command:
+
+```powershell
+rg -n "Vector Map Editor(?! V2)|shared-theme-header|VECTOR_MAP_V2_ENTRY|SESSION_CONTEXT_READ|VECTOR_MAP_V2_CONTRACT_LOADED" --pcre2 -- tools/vector-map-editor-v2/index.js
+```
+
+Result: passed. Evidence found for the required header/log markers and no unsuffixed visible tool name.
+
+## Scope Guard
+No changes were made to:
+
+- schemas
+- samples
+- games
+- `start_of_day/**`
+- Workspace Manager v1
+- `platformShell`
+- `assetUsageIntegration`
+- `tools/shared/**`
+- legacy Vector Map Editor
+
+## Full Samples Smoke Decision
+Full samples smoke test skipped.
+
+Reason: this PR is limited to one isolated V2 tool entry and does not modify shared sample loader/framework behavior.
+
+## ZIP Artifact
+
+```text
+tmp/PR_11_191_VECTOR_MAP_EDITOR_V2_delta.zip
+```

docs/pr/PR_11_191_VECTOR_MAP_EDITOR_V2_REENGINEER_PLAN.md

@@ -0,0 +1,43 @@
+# PR_11_191 — Vector Map Editor V2 Re-Engineer
+
+## Purpose
+Re-engineer Vector Map Editor V2 as the next tool in the V2 lane. This is not a copy/paste of legacy Vector Map Editor code.
+
+## Scope
+- Tool: Vector Map Editor V2 only.
+- Single-file, single-class implementation target.
+- Session-backed data only.
+- Must use the shared `/index.html` theme header mount: `<div id="shared-theme-header"></div>`.
+- Must keep V2 suffix in visible tool naming and tool identity.
+
+## Out of Scope
+- No schema changes.
+- No sample changes.
+- No game changes.
+- No Workspace Manager v1 work.
+- No platformShell usage.
+- No assetUsageIntegration usage.
+- No `tools/shared/*` dependency.
+- No legacy helper copy/paste.
+
+## Required Architecture
+Data entry paths:
+1. Workspace writes session, tool reads session.
+2. Tool URL writes session, tool reads session.
+3. Tool direct reads session via hostContextId.
+
+Tool never fetches, guesses, defaults, or falls back.
+
+## Required Logs
+- `[VECTOR_MAP_V2_ENTRY]`
+- `[SESSION_CONTEXT_READ]`
+- `[VECTOR_MAP_V2_CONTRACT_LOADED]`
+
+## Acceptance
+- Vector Map Editor V2 loads from session.
+- Vector map renders from session-backed contract.
+- Empty and invalid states are explicit and actionable.
+- Header uses `/index.html` shared header image/theme mount.
+- No legacy v1 coupling.
+- No fallback/default data.
+- No schema/sample/game changes.