Add asset add/remove functionality with strict validation and persistence in Asset Manager V2 - PR_11_315

Author: DavidQ

docs/dev/codex_commands.md

@@ -145,3 +145,10 @@ PR_11_314
 ```bash
 npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_314: persist valid Asset Manager V2 payloadJson.assetCatalog into Workspace V2 active session/export path and block invalid writes."
 ```
+
+---
+PR_11_315
+
+```bash
+npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_315: Enable core asset management actions in Asset Manager V2 (add/remove entries) with strict required-field validation and workspace persistence."
+```

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Persist valid Asset Manager V2 assetCatalog into Workspace V2 activeSession export path and block invalid write-back - PR 11.314
+Enable Asset Manager V2 add/remove asset entries with strict validation and workspace persistence - PR 11.315

docs/dev/reports/PR_11_315_report.md

@@ -0,0 +1,37 @@
+# PR_11_315 Report
+
+## Purpose
+Enable core add/remove asset actions in Asset Manager V2 with strict entry validation and persistence through the Workspace export path.
+
+## Files Changed
+- `tools/asset-manager-v2/index.html`
+- `tools/asset-manager-v2/index.js`
+- `docs/pr/PR_11_315_ASSET_MANAGER_CORE_ADD_REMOVE/PLAN_PR.md`
+- `docs/pr/PR_11_315_ASSET_MANAGER_CORE_ADD_REMOVE/BUILD_PR.md`
+- `docs/dev/reports/PR_11_315_report.md`
+- `docs/dev/codex_commands.md`
+- `docs/dev/commit_comment.txt`
+
+## Implementation Summary
+- Added add form UI with required fields (`id`, `label`, `kind`, `path`).
+- Added strict add validation:
+  - all fields required
+  - no duplicate `id`
+  - no add when session is invalid/missing
+- Added remove action per asset row:
+  - removes by `id`
+  - blocks with clear status when id is missing/not found
+- After add/remove:
+  - updated catalog is revalidated
+  - valid session payload is re-persisted for Workspace V2 export path
+
+## Validation Commands
+- `node --check tools/asset-manager-v2/index.js` -> **PASS**
+- legacy-id content search -> **PASS** (zero matches)
+- legacy-id path search -> **PASS** (zero matches)
+
+## Notes
+- No schema updates.
+- No fallback/default asset injection.
+- No alias support added.
+- Full samples smoke test was **skipped** because this PR only changes one tool (`asset-manager-v2`) and is fully covered by targeted syntax validation.

docs/pr/PR_11_315_ASSET_MANAGER_CORE_ADD_REMOVE/BUILD_PR.md

@@ -0,0 +1,24 @@
+# BUILD_PR_11_315
+
+## Implementation
+- Added minimal Asset Manager V2 add form in `menuTool`:
+  - `id`
+  - `label`
+  - `kind`
+  - `path`
+  - `Add Asset` button
+  - action status readout
+- Implemented strict add validation in `tools/asset-manager-v2/index.js`:
+  - requires non-empty `id`, `label`, `kind`, `path`
+  - rejects duplicate `id`
+  - rejects add when no valid session is loaded
+- Implemented remove action per asset row:
+  - remove by `id`
+  - blocks when id not found or session is invalid
+- Add/remove operations update `payloadJson.assetCatalog.entries` and re-run contract validation/render path.
+- Updated valid state to keep Workspace persistence through existing write-back path so exports reflect add/remove updates.
+
+## Validation
+- `node --check tools/asset-manager-v2/index.js`
+- legacy-id content audit -> zero matches
+- legacy-id path audit -> zero matches

docs/pr/PR_11_315_ASSET_MANAGER_CORE_ADD_REMOVE/PLAN_PR.md

@@ -0,0 +1,19 @@
+# PLAN_PR_11_315
+
+## Purpose
+Enable core asset management actions in Asset Manager V2 by adding/removing entries in `payloadJson.assetCatalog.entries`.
+
+## Scope
+- `tools/asset-manager-v2/index.html`
+- `tools/asset-manager-v2/index.js`
+- `docs/dev/reports/PR_11_315_report.md`
+- `docs/dev/codex_commands.md`
+- `docs/dev/commit_comment.txt`
+
+## Steps
+1. Add minimal add-asset form UI (`id`, `label`, `kind`, `path`) in Asset Manager V2.
+2. Validate add inputs strictly (all required fields; no guessed values).
+3. Add remove-by-id action per asset row.
+4. Persist updated valid catalog through existing Workspace V2 session write-back path.
+5. Keep invalid payloads blocked from write-back.
+6. Run targeted syntax and legacy-id zero-occurrence checks.

tools/asset-manager-v2/index.html

@@ -24,6 +24,19 @@
               <h3>menuTool</h3>
               <p id="assetBrowserV2ContractReadout">payloadJson.assetCatalog not loaded.</p>
               <button id="assetBrowserV2OpenSvgAssetStudioV2Button" type="button">Open in SVG Asset Studio V2</button>
+              <div>
+                <h4>Add Asset</h4>
+                <label for="assetManagerV2AddId">id</label>
+                <input id="assetManagerV2AddId" type="text" />
+                <label for="assetManagerV2AddLabel">label</label>
+                <input id="assetManagerV2AddLabel" type="text" />
+                <label for="assetManagerV2AddKind">kind</label>
+                <input id="assetManagerV2AddKind" type="text" />
+                <label for="assetManagerV2AddPath">path</label>
+                <input id="assetManagerV2AddPath" type="text" />
+                <button id="assetManagerV2AddButton" type="button">Add Asset</button>
+                <p id="assetManagerV2ActionStatus">No asset action yet.</p>
+              </div>
               <div id="assetBrowserV2List" aria-label="Asset Manager V2 asset list"></div>
             </aside>
             <section class="asset-manager-v2-panel" aria-live="polite">

tools/asset-manager-v2/index.js

@@ -7,11 +7,14 @@ class AssetBrowserV2 {
     this.urlState = this.readUrlState();
     this.goBack = this.goBack.bind(this);
     this.openSvgAssetStudioV2 = this.openSvgAssetStudioV2.bind(this);
+    this.addAssetEntry = this.addAssetEntry.bind(this);
+    this.currentSessionContext = null;
     this.handleNavigationState = this.handleNavigationState.bind(this);
     window.addEventListener("popstate", this.handleNavigationState);
     window.addEventListener("pageshow", this.handleNavigationState);
     document.getElementById("assetBrowserV2BackButton").addEventListener("click", this.goBack);
     document.getElementById("assetBrowserV2OpenSvgAssetStudioV2Button").addEventListener("click", this.openSvgAssetStudioV2);
+    document.getElementById("assetManagerV2AddButton").addEventListener("click", this.addAssetEntry);
     this.renderNavigation();
     this.registerSnapshotHook();
     this.readSession();
@@ -116,6 +119,97 @@ class AssetBrowserV2 {
     window.__v2RuntimeSnapshot = () => this.buildRuntimeSnapshot();
   }
 
+  cloneSessionValue(value) {
+    return JSON.parse(JSON.stringify(value));
+  }
+
+  setActionStatus(message) {
+    document.getElementById("assetManagerV2ActionStatus").textContent = message;
+  }
+
+  normalizedAssetEntryFromForm() {
+    const id = typeof document.getElementById("assetManagerV2AddId").value === "string" ? document.getElementById("assetManagerV2AddId").value.trim() : "";
+    const label = typeof document.getElementById("assetManagerV2AddLabel").value === "string" ? document.getElementById("assetManagerV2AddLabel").value.trim() : "";
+    const kind = typeof document.getElementById("assetManagerV2AddKind").value === "string" ? document.getElementById("assetManagerV2AddKind").value.trim() : "";
+    const path = typeof document.getElementById("assetManagerV2AddPath").value === "string" ? document.getElementById("assetManagerV2AddPath").value.trim() : "";
+    if (!id || !label || !kind || !path) {
+      return { ok: false, message: "Add blocked. id, label, kind, and path are required.", entry: null };
+    }
+    return { ok: true, message: "", entry: { id, label, kind, path } };
+  }
+
+  clearAddAssetForm() {
+    document.getElementById("assetManagerV2AddId").value = "";
+    document.getElementById("assetManagerV2AddLabel").value = "";
+    document.getElementById("assetManagerV2AddKind").value = "";
+    document.getElementById("assetManagerV2AddPath").value = "";
+  }
+
+  addAssetEntry() {
+    if (!this.currentSessionContext || typeof this.currentSessionContext !== "object" || Array.isArray(this.currentSessionContext)) {
+      this.setActionStatus("Add blocked. No valid Asset Manager V2 session is loaded.");
+      return;
+    }
+    if (!this.currentSessionContext.payloadJson || typeof this.currentSessionContext.payloadJson !== "object" || Array.isArray(this.currentSessionContext.payloadJson)) {
+      this.setActionStatus("Add blocked. payloadJson is missing.");
+      return;
+    }
+    if (!this.currentSessionContext.payloadJson.assetCatalog || typeof this.currentSessionContext.payloadJson.assetCatalog !== "object" || Array.isArray(this.currentSessionContext.payloadJson.assetCatalog)) {
+      this.setActionStatus("Add blocked. payloadJson.assetCatalog is missing.");
+      return;
+    }
+    if (!Array.isArray(this.currentSessionContext.payloadJson.assetCatalog.entries)) {
+      this.setActionStatus("Add blocked. payloadJson.assetCatalog.entries must be an array.");
+      return;
+    }
+    const newEntry = this.normalizedAssetEntryFromForm();
+    if (!newEntry.ok) {
+      this.setActionStatus(newEntry.message);
+      return;
+    }
+    if (this.currentSessionContext.payloadJson.assetCatalog.entries.some((entry) => entry && typeof entry === "object" && !Array.isArray(entry) && typeof entry.id === "string" && entry.id.trim() === newEntry.entry.id)) {
+      this.setActionStatus(`Add blocked. Asset id '${newEntry.entry.id}' already exists.`);
+      return;
+    }
+    const nextSessionContext = this.cloneSessionValue(this.currentSessionContext);
+    nextSessionContext.payloadJson.assetCatalog.entries.push(newEntry.entry);
+    this.loadContract(nextSessionContext);
+    this.clearAddAssetForm();
+    this.setActionStatus(`Asset '${newEntry.entry.id}' added.`);
+  }
+
+  removeAssetEntryById(assetId) {
+    if (!this.currentSessionContext || typeof this.currentSessionContext !== "object" || Array.isArray(this.currentSessionContext)) {
+      this.setActionStatus("Remove blocked. No valid Asset Manager V2 session is loaded.");
+      return;
+    }
+    if (!this.currentSessionContext.payloadJson || typeof this.currentSessionContext.payloadJson !== "object" || Array.isArray(this.currentSessionContext.payloadJson)) {
+      this.setActionStatus("Remove blocked. payloadJson is missing.");
+      return;
+    }
+    if (!this.currentSessionContext.payloadJson.assetCatalog || typeof this.currentSessionContext.payloadJson.assetCatalog !== "object" || Array.isArray(this.currentSessionContext.payloadJson.assetCatalog)) {
+      this.setActionStatus("Remove blocked. payloadJson.assetCatalog is missing.");
+      return;
+    }
+    if (!Array.isArray(this.currentSessionContext.payloadJson.assetCatalog.entries)) {
+      this.setActionStatus("Remove blocked. payloadJson.assetCatalog.entries must be an array.");
+      return;
+    }
+    if (typeof assetId !== "string" || !assetId.trim()) {
+      this.setActionStatus("Remove blocked. Asset id is required.");
+      return;
+    }
+    const nextSessionContext = this.cloneSessionValue(this.currentSessionContext);
+    const startLength = nextSessionContext.payloadJson.assetCatalog.entries.length;
+    nextSessionContext.payloadJson.assetCatalog.entries = nextSessionContext.payloadJson.assetCatalog.entries.filter((entry) => !entry || typeof entry !== "object" || Array.isArray(entry) || typeof entry.id !== "string" || entry.id.trim() !== assetId.trim());
+    if (nextSessionContext.payloadJson.assetCatalog.entries.length === startLength) {
+      this.setActionStatus(`Remove blocked. Asset id '${assetId.trim()}' was not found.`);
+      return;
+    }
+    this.loadContract(nextSessionContext);
+    this.setActionStatus(`Asset '${assetId.trim()}' removed.`);
+  }
+
   logStructuredError(type, message, details) {
     console.error({
       tool: "asset-manager-v2",
@@ -270,16 +364,21 @@ class AssetBrowserV2 {
     }
     document.getElementById("assetBrowserV2InvalidState").hidden = true;
     document.getElementById("assetBrowserV2ValidState").hidden = false;
+    this.currentSessionContext = this.cloneSessionValue(sessionContext);
 
     document.getElementById("assetBrowserV2List").replaceChildren();
     assetCatalog.entries.forEach((entry) => {
+      const assetRow = document.createElement("div");
       const assetItem = document.createElement("button");
       const assetName = document.createElement("strong");
       const assetMeta = document.createElement("div");
+      const removeButton = document.createElement("button");
       assetItem.type = "button";
+      removeButton.type = "button";
       assetName.textContent = entry.label.trim();
       assetMeta.textContent = `${entry.kind.trim()} | ${entry.path.trim()}`;
       assetItem.append(assetName, assetMeta);
+      removeButton.textContent = `Remove ${entry.id.trim()}`;
       assetItem.addEventListener("click", () => {
         document.getElementById("assetBrowserV2Preview").textContent = JSON.stringify(
           {
@@ -292,7 +391,11 @@ class AssetBrowserV2 {
           2
         );
       });
-      document.getElementById("assetBrowserV2List").appendChild(assetItem);
+      removeButton.addEventListener("click", () => {
+        this.removeAssetEntryById(entry.id.trim());
+      });
+      assetRow.append(assetItem, removeButton);
+      document.getElementById("assetBrowserV2List").appendChild(assetRow);
     });
 
     document.getElementById("assetBrowserV2Preview").textContent = assetCatalog.entries.length === 0
@@ -313,6 +416,8 @@ class AssetBrowserV2 {
     document.getElementById("assetBrowserV2ValidState").hidden = true;
     document.getElementById("assetBrowserV2List").replaceChildren();
     document.getElementById("assetBrowserV2Preview").textContent = "";
+    this.currentSessionContext = null;
+    this.setActionStatus("No asset action yet.");
   }
 
   renderError(message) {
@@ -328,6 +433,8 @@ class AssetBrowserV2 {
     document.getElementById("assetBrowserV2ValidState").hidden = true;
     document.getElementById("assetBrowserV2List").replaceChildren();
     document.getElementById("assetBrowserV2Preview").textContent = "";
+    this.currentSessionContext = null;
+    this.setActionStatus("No asset action yet.");
   }
 }