Skip to content

Commit 85f6140

Browse files
author
DavidQ
committed
Remove legacy import/export paths and duplicate handlers to stabilize Workspace V2 runtime - PR_11_310
1 parent 604cb78 commit 85f6140

6 files changed

Lines changed: 143 additions & 293 deletions

File tree

docs/dev/codex_commands.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,3 +92,11 @@ After validation, Codex must create:
9292
```
9393

9494
The ZIP must preserve repo-relative structure and include the final changed files plus docs/dev evidence.
95+
96+
97+
---
98+
PR_11_310
99+
100+
```bash
101+
npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_310 ..."
102+
```

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Complete Tilemap Studio V2 with HTML-first shell and session-only behavior - PR 11.198
1+
Remove Workspace V2 legacy diagnostics and duplicate session handlers; enforce single import/export/session activation paths - PR 11.310
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# PR_11_310 Report - Workspace V2 Legacy/Conflicting Logic Cleanup
2+
3+
## Files Changed
4+
- `tools/workspace-v2/index.js`
5+
- `docs/pr/PR_11_310_WORKSPACE_V2_STATE_CLEANUP/PLAN_PR.md`
6+
- `docs/pr/PR_11_310_WORKSPACE_V2_STATE_CLEANUP/BUILD_PR.md`
7+
- `docs/dev/codex_commands.md`
8+
- `docs/dev/commit_comment.txt`
9+
- `docs/dev/reports/PR_11_310_report.md`
10+
11+
## Summary
12+
- Removed diagnostics panel runtime logic and its event wiring.
13+
- Removed dead import/export handlers (`importSessionJson`, `exportCurrentSessionJson`) to keep one import path and one export path.
14+
- Consolidated active session writes through a single activation method (`activateWorkspaceSession`).
15+
- Removed legacy unused nav-mode helper methods.
16+
- Kept workspace import/export centered on `tools.*` structure and retained existing schema/data shapes.
17+
18+
## Validation Commands
19+
- `node --check tools/workspace-v2/index.js`
20+
21+
## Validation Results
22+
- PASS: syntax check succeeded.
23+
24+
## Full Samples Smoke
25+
- Skipped.
26+
- Reason: change is isolated to Workspace V2 UI/controller logic in one file and does not touch shared sample infrastructure.
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# BUILD_PR_11_310
2+
3+
## Implementation
4+
- Removed diagnostics panel logic and runtime hooks from Workspace V2.
5+
- Removed dead `importSessionJson` and `exportCurrentSessionJson` code paths.
6+
- Added `activateWorkspaceSession(...)` and routed active import/export/session flows through this single activation path.
7+
- Removed legacy nav-mode helper methods that were no longer used.
8+
9+
## Constraints Followed
10+
- No schema contract changes
11+
- No runtime data shape changes
12+
- No new features
13+
- Palette ownership logic left intact
14+
15+
## Validation
16+
- `node --check tools/workspace-v2/index.js`
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# PLAN_PR_11_310
2+
3+
## Purpose
4+
Remove conflicting and legacy Workspace V2 state paths so import/export/session activation each use one active flow.
5+
6+
## Scope
7+
- `tools/workspace-v2/index.js`
8+
- Remove dead import/export code paths
9+
- Remove diagnostics panel UI + logic
10+
- Consolidate session activation path
11+
12+
## Steps
13+
1. Remove diagnostics bindings/logic and panel render path.
14+
2. Remove dead tool-mode import/export handlers.
15+
3. Consolidate session activation through one helper path.
16+
4. Verify no legacy workspace shape references remain in runtime logic.
17+
5. Run targeted syntax validation and package artifacts.

0 commit comments

Comments
 (0)