Use native viewport sizing for Preview Generator V2 fullscreen capture - PR_26126_029-preview-generator-v2-fullscreen-native-size

Author: DavidQ

docs/dev/codex_commands.md

@@ -1,34 +1,30 @@
-# Codex Commands - PR_26126_028-sample-local-readme-and-fullscreen-capture-fix
+# Codex Commands - PR_26126_029-preview-generator-v2-fullscreen-native-size
 
 ```bash
-codex run "Create PR_26126_028-sample-local-readme-and-fullscreen-capture-fix. Fix Preview Generator V2 documentation and capture behavior. Add a README.md template under existing sample folders using the pattern samples/phase-xx/XXXX/README.md. The README must explain where the sample implementation actually lives, how the sample folder/index.html launches or bypasses into that code, and how Preview Generator V2 should discover/launch the sample without assuming numeric folders. Do not add a root samples README. Do not modify sample JSON. Also fix Full Screen (1600x900 HTML Page) capture so it does not silently fall back to non-fullscreen capture when html-to-image/html2canvas fails on unsupported CSS color functions such as color(...). For fullscreen mode, capture must either use the intended 1600x900 viewport/full-page path or fail clearly with an actionable error; do not mark OK when fallback was used for fullscreen. Preserve Canvas Only behavior. Produce review artifacts."
+codex run "Create PR_26126_029-preview-generator-v2-fullscreen-native-size. Fix Preview Generator V2 fullscreen capture wording and behavior only. Preserve existing generation behavior. Full Screen capture must not require 1600x900; use the actual available fullscreen/browser viewport size. Update Capture mode label from \"Full Screen (1600x900 HTML Page)\" to \"Full Screen\". Remove hardcoded 1600x900 wording from UI, logs, errors, and tests. If fullscreen capture fails, report \"Full Screen capture failed\" with the underlying error, not \"failed at 1600x900\". Preserve Canvas Only behavior. Do not modify samples. Do not add schema. Produce review artifacts."
 ```
 
 ## Validation Commands
 
 ```bash
-$sampleDirs = Get-ChildItem samples -Directory -Filter 'phase-*' | Sort-Object Name | ForEach-Object { Get-ChildItem $_.FullName -Directory | Where-Object { $_.Name -match '^\d{4}$' } | Sort-Object FullName }
-$missingReadmes = $sampleDirs | Where-Object { !(Test-Path (Join-Path $_.FullName 'README.md')) }
-if ($missingReadmes) { $missingReadmes.FullName; throw "Missing sample README files." }
-if (Test-Path samples/README.md) { throw "Unexpected root samples/README.md" }
-$sampleReadmes = $sampleDirs | ForEach-Object { Join-Path $_.FullName 'README.md' }
-rg -n "SAMPLE_LOCAL_CONTRACT_README|Preview Generator V2 discovers samples|SKIP|FAIL|games/<gamename>|index.html is the only discovery" $sampleReadmes
-rg -n "Full Screen capture failed|html2canvas may not support CSS color functions|extractBestToolFallbackSvg|using fallback" tools/preview-generator-v2/index.html
+rg -n "1600|900|1600x900|fullscreen1600|Full Screen \\(|failed at" tools/preview-generator-v2/index.html
+rg -n "Full Screen capture failed|Full Screen|Canvas Only|fullscreen|getAvailableFullScreenCaptureSize|extractFullPageSvg" tools/preview-generator-v2/index.html
+node -e "const fs=require('fs');const html=fs.readFileSync('tools/preview-generator-v2/index.html','utf8');const scripts=[...html.matchAll(/<script(?![^>]*\\bsrc=)[^>]*>([\\s\\S]*?)<\\/script>/gi)].map(m=>m[1]);scripts.forEach((script,i)=>{new Function(script);console.log('inline script '+(i+1)+' syntax ok');});"
 git diff --check
-git diff --cached --name-only -- '*.json' start_of_day tools/shared tools/schemas
+git diff --name-only -- tools/preview-generator-v2/index.html docs/dev/codex_commands.md docs/dev/commit_comment.txt docs/dev/reports/codex_changed_files.txt docs/dev/reports/codex_review.diff
+git diff --name-only -- '*.json' tools/shared tools/schemas start_of_day
 npm run test:workspace-v2
 npm test
-npm run codex:review-artifacts
 ```
 
 ## Playwright
 
-No Playwright test was added. This PR changes documentation and Preview Generator V2 fullscreen capture error handling only. `npm run test:workspace-v2` was attempted but is not defined in the current `package.json`.
+No Playwright test was added. This PR changes Preview Generator V2 fullscreen capture wording and capture sizing only. `npm run test:workspace-v2` is attempted as the standard command if available.
 
 ## Test Notes
 
-`npm test` was attempted as the available default test gate and failed in the existing shared extraction guard baseline before this PR's changed Preview Generator V2 code or README files were involved. The reported violations are outside this PR scope.
+`npm run test:workspace-v2` is not defined in the current `package.json`. `npm test` was attempted and still fails in the existing shared extraction guard baseline, outside this PR scope.
 
 ## Manual Test
 
-Use Preview Generator V2 with Canvas Only to confirm existing canvas capture still works. Use Full Screen (1600x900 HTML Page) on a target with unsupported CSS color functions and confirm it logs a clear `FAIL` instead of silently falling back to a non-fullscreen capture.
+Use Preview Generator V2 with Canvas Only to confirm existing canvas capture still works. Use Full Screen on a target with unsupported fullscreen capture CSS and confirm it logs `Full Screen capture failed: <underlying error>` without fallback or fixed-size wording.

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Document sample-local contracts and harden fullscreen preview capture - PR_26126_028-sample-local-readme-and-fullscreen-capture-fix
+Use native viewport sizing for Preview Generator V2 fullscreen capture - PR_26126_029-preview-generator-v2-fullscreen-native-size

docs/dev/reports/codex_changed_files.txt

@@ -1,282 +1,19 @@
-# git status --short
-M  docs/dev/codex_commands.md
-M  docs/dev/commit_comment.txt
-A  samples/phase-01/0101/README.md
-A  samples/phase-01/0102/README.md
-A  samples/phase-01/0103/README.md
-A  samples/phase-01/0104/README.md
-A  samples/phase-01/0105/README.md
-A  samples/phase-01/0106/README.md
-A  samples/phase-01/0107/README.md
-A  samples/phase-01/0108/README.md
-M  samples/phase-01/0109/README.md
-M  samples/phase-01/0110/README.md
-M  samples/phase-01/0111/README.md
-M  samples/phase-01/0112/README.md
-M  samples/phase-01/0113/README.md
-M  samples/phase-01/0114/README.md
-M  samples/phase-01/0115/README.md
-M  samples/phase-01/0116/README.md
-M  samples/phase-01/0117/README.md
-M  samples/phase-01/0118/README.md
-M  samples/phase-01/0119/README.md
-M  samples/phase-01/0120/README.md
-M  samples/phase-01/0121/README.md
-M  samples/phase-01/0122/README.md
-M  samples/phase-01/0123/README.md
-M  samples/phase-01/0124/README.md
-M  samples/phase-02/0201/README.md
-M  samples/phase-02/0202/README.md
-M  samples/phase-02/0203/README.md
-M  samples/phase-02/0204/README.md
-M  samples/phase-02/0205/README.md
-M  samples/phase-02/0206/README.md
-M  samples/phase-02/0207/README.md
-M  samples/phase-02/0208/README.md
-M  samples/phase-02/0209/README.md
-M  samples/phase-02/0210/README.md
-M  samples/phase-02/0211/README.md
-M  samples/phase-02/0212/README.md
-M  samples/phase-02/0213/README.md
-M  samples/phase-02/0214/README.md
-M  samples/phase-02/0215/README.md
-M  samples/phase-02/0216/README.md
-M  samples/phase-02/0217/README.md
-M  samples/phase-02/0218/README.md
-M  samples/phase-02/0219/README.md
-M  samples/phase-02/0220/README.md
-M  samples/phase-02/0221/README.md
-M  samples/phase-02/0222/README.md
-M  samples/phase-02/0223/README.md
-M  samples/phase-02/0224/README.md
-A  samples/phase-02/0225/README.md
-M  samples/phase-02/0226/README.md
-M  samples/phase-02/0227/README.md
-M  samples/phase-03/0301/README.md
-M  samples/phase-03/0302/README.md
-M  samples/phase-03/0303/README.md
-M  samples/phase-03/0304/README.md
-M  samples/phase-03/0305/README.md
-M  samples/phase-03/0306/README.md
-M  samples/phase-03/0307/README.md
-M  samples/phase-03/0308/README.md
-M  samples/phase-03/0309/README.md
-M  samples/phase-03/0310/README.md
-M  samples/phase-03/0311/README.md
-M  samples/phase-03/0312/README.md
-M  samples/phase-03/0313/README.md
-M  samples/phase-03/0314/README.md
-M  samples/phase-03/0315/README.md
-M  samples/phase-03/0316/README.md
-M  samples/phase-03/0317/README.md
-M  samples/phase-03/0318/README.md
-M  samples/phase-03/0319/README.md
-M  samples/phase-03/0320/README.md
-M  samples/phase-03/0321/README.md
-M  samples/phase-03/0322/README.md
-M  samples/phase-03/0323/README.md
-M  samples/phase-03/0324/README.md
-A  samples/phase-03/0325/README.md
-A  samples/phase-03/0326/README.md
-A  samples/phase-03/0327/README.md
-M  samples/phase-04/0401/README.md
-M  samples/phase-04/0402/README.md
-M  samples/phase-04/0403/README.md
-M  samples/phase-04/0404/README.md
-M  samples/phase-04/0405/README.md
-M  samples/phase-04/0406/README.md
-M  samples/phase-04/0407/README.md
-M  samples/phase-04/0408/README.md
-M  samples/phase-04/0409/README.md
-M  samples/phase-04/0410/README.md
-M  samples/phase-04/0411/README.md
-M  samples/phase-04/0412/README.md
-A  samples/phase-04/0413/README.md
-A  samples/phase-05/0501/README.md
-A  samples/phase-05/0502/README.md
-A  samples/phase-05/0503/README.md
-A  samples/phase-05/0504/README.md
-A  samples/phase-05/0505/README.md
-A  samples/phase-05/0506/README.md
-A  samples/phase-05/0507/README.md
-A  samples/phase-05/0508/README.md
-A  samples/phase-05/0509/README.md
-A  samples/phase-05/0510/README.md
-A  samples/phase-05/0511/README.md
-A  samples/phase-05/0512/README.md
-A  samples/phase-06/0601/README.md
-A  samples/phase-06/0602/README.md
-A  samples/phase-06/0603/README.md
-A  samples/phase-06/0604/README.md
-A  samples/phase-06/0605/README.md
-A  samples/phase-06/0606/README.md
-A  samples/phase-06/0607/README.md
-A  samples/phase-06/0608/README.md
-A  samples/phase-06/0609/README.md
-A  samples/phase-06/0610/README.md
-A  samples/phase-06/0611/README.md
-A  samples/phase-06/0612/README.md
-A  samples/phase-06/0613/README.md
-A  samples/phase-06/0614/README.md
-A  samples/phase-07/0701/README.md
-A  samples/phase-07/0702/README.md
-A  samples/phase-07/0703/README.md
-A  samples/phase-07/0704/README.md
-A  samples/phase-07/0705/README.md
-A  samples/phase-07/0706/README.md
-A  samples/phase-07/0707/README.md
-A  samples/phase-07/0708/README.md
-A  samples/phase-07/0709/README.md
-A  samples/phase-07/0710/README.md
-A  samples/phase-07/0711/README.md
-A  samples/phase-07/0712/README.md
-A  samples/phase-07/0713/README.md
-A  samples/phase-08/0801/README.md
-A  samples/phase-08/0802/README.md
-A  samples/phase-08/0803/README.md
-A  samples/phase-08/0804/README.md
-A  samples/phase-08/0805/README.md
-A  samples/phase-08/0806/README.md
-A  samples/phase-08/0807/README.md
-A  samples/phase-08/0808/README.md
-A  samples/phase-08/0809/README.md
-A  samples/phase-08/0810/README.md
-A  samples/phase-09/0901/README.md
-A  samples/phase-09/0902/README.md
-A  samples/phase-09/0903/README.md
-A  samples/phase-09/0904/README.md
-A  samples/phase-09/0905/README.md
-A  samples/phase-09/0906/README.md
-A  samples/phase-10/1001/README.md
-A  samples/phase-10/1002/README.md
-A  samples/phase-10/1003/README.md
-A  samples/phase-11/1101/README.md
-A  samples/phase-11/1102/README.md
-A  samples/phase-11/1103/README.md
-A  samples/phase-11/1104/README.md
-A  samples/phase-11/1105/README.md
-A  samples/phase-11/1106/README.md
-M  samples/phase-12/1201/README.md
-M  samples/phase-12/1202/README.md
-M  samples/phase-12/1203/README.md
-M  samples/phase-12/1204/README.md
-M  samples/phase-12/1205/README.md
-M  samples/phase-12/1206/README.md
-M  samples/phase-12/1207/README.md
-M  samples/phase-12/1208/README.md
-A  samples/phase-12/1209/README.md
-A  samples/phase-12/1210/README.md
-A  samples/phase-12/1211/README.md
-A  samples/phase-12/1212/README.md
- M samples/phase-12/1212/assets/images/preview.svg
-A  samples/phase-12/1213/README.md
- M samples/phase-12/1213/assets/images/preview.svg
-A  samples/phase-12/1214/README.md
- M samples/phase-12/1214/assets/images/preview.svg
-A  samples/phase-12/1215/README.md
- M samples/phase-12/1215/assets/images/preview.svg
-A  samples/phase-12/1216/README.md
- M samples/phase-12/1216/assets/images/preview.svg
-A  samples/phase-12/1217/README.md
- M samples/phase-12/1217/assets/images/preview.svg
-A  samples/phase-12/1218/README.md
- M samples/phase-12/1218/assets/images/preview.svg
-A  samples/phase-12/1219/README.md
- M samples/phase-12/1219/assets/images/preview.svg
-A  samples/phase-12/1220/README.md
- M samples/phase-12/1220/assets/images/preview.svg
-A  samples/phase-13/1301/README.md
-A  samples/phase-13/1302/README.md
-A  samples/phase-13/1303/README.md
-A  samples/phase-13/1304/README.md
-A  samples/phase-13/1305/README.md
-A  samples/phase-13/1306/README.md
-A  samples/phase-13/1307/README.md
-A  samples/phase-13/1308/README.md
-A  samples/phase-13/1309/README.md
-A  samples/phase-13/1310/README.md
-A  samples/phase-13/1311/README.md
-A  samples/phase-13/1312/README.md
-A  samples/phase-13/1313/README.md
-A  samples/phase-13/1314/README.md
-A  samples/phase-13/1315/README.md
-A  samples/phase-13/1316/README.md
-A  samples/phase-13/1317/README.md
-A  samples/phase-13/1318/README.md
-A  samples/phase-13/1319/README.md
-A  samples/phase-13/1320/README.md
-A  samples/phase-14/1401/README.md
-A  samples/phase-14/1402/README.md
-A  samples/phase-14/1403/README.md
-A  samples/phase-14/1404/README.md
-A  samples/phase-14/1405/README.md
-A  samples/phase-14/1406/README.md
-A  samples/phase-14/1407/README.md
-A  samples/phase-14/1408/README.md
-A  samples/phase-14/1409/README.md
-A  samples/phase-14/1410/README.md
-A  samples/phase-14/1411/README.md
-A  samples/phase-14/1412/README.md
-A  samples/phase-14/1413/README.md
-A  samples/phase-14/1414/README.md
-A  samples/phase-14/1415/README.md
-A  samples/phase-14/1416/README.md
-A  samples/phase-14/1417/README.md
-A  samples/phase-14/1418/README.md
-A  samples/phase-15/1501/README.md
-A  samples/phase-15/1502/README.md
-A  samples/phase-15/1503/README.md
-A  samples/phase-15/1504/README.md
-A  samples/phase-15/1505/README.md
-A  samples/phase-15/1506/README.md
-A  samples/phase-16/1601/README.md
-A  samples/phase-16/1602/README.md
-A  samples/phase-16/1603/README.md
-A  samples/phase-16/1604/README.md
-A  samples/phase-16/1605/README.md
-A  samples/phase-16/1606/README.md
-A  samples/phase-16/1607/README.md
-A  samples/phase-16/1608/README.md
-A  samples/phase-16/1609/README.md
-A  samples/phase-16/1610/README.md
-A  samples/phase-16/1611/README.md
-A  samples/phase-16/1612/README.md
-A  samples/phase-16/1613/README.md
-A  samples/phase-16/1614/README.md
-A  samples/phase-16/1615/README.md
-A  samples/phase-16/1616/README.md
-A  samples/phase-16/1617/README.md
-A  samples/phase-16/1618/README.md
-A  samples/phase-16/1619/README.md
-A  samples/phase-16/1620/README.md
-A  samples/phase-16/1621/README.md
-A  samples/phase-16/1622/README.md
-A  samples/phase-17/1701/README.md
-A  samples/phase-17/1702/README.md
-A  samples/phase-17/1703/README.md
-A  samples/phase-17/1704/README.md
-A  samples/phase-17/1705/README.md
-A  samples/phase-17/1706/README.md
-A  samples/phase-17/1707/README.md
-A  samples/phase-17/1708/README.md
-A  samples/phase-17/1709/README.md
-A  samples/phase-17/1710/README.md
-A  samples/phase-17/1711/README.md
-A  samples/phase-17/1712/README.md
-A  samples/phase-17/1713/README.md
-A  samples/phase-18/1801/README.md
-A  samples/phase-19/1901/README.md
-A  samples/phase-19/1902/README.md
-M  tools/preview-generator-v2/index.html
+# PR_26126_029-preview-generator-v2-fullscreen-native-size
 
-# git diff --stat
-samples/phase-12/1212/assets/images/preview.svg | 17 ++---------
- samples/phase-12/1213/assets/images/preview.svg | 17 ++---------
- samples/phase-12/1214/assets/images/preview.svg | 17 ++---------
- samples/phase-12/1215/assets/images/preview.svg | 40 ++++++++++++++++---------
- samples/phase-12/1216/assets/images/preview.svg | 40 ++++++++++++++++---------
- samples/phase-12/1217/assets/images/preview.svg | 40 ++++++++++++++++---------
- samples/phase-12/1218/assets/images/preview.svg | 17 ++---------
- samples/phase-12/1219/assets/images/preview.svg | 17 ++---------
- samples/phase-12/1220/assets/images/preview.svg | 17 ++---------
- 9 files changed, 96 insertions(+), 126 deletions(-)
+PR_029 files:
+- docs/dev/codex_commands.md
+- docs/dev/commit_comment.txt
+- docs/dev/reports/codex_changed_files.txt
+- docs/dev/reports/codex_review.diff
+- tools/preview-generator-v2/index.html
+
+Validation notes:
+- Preview Generator V2 no longer contains `1600`, `900`, `1600x900`, `fullscreen1600`, `Full Screen (` or `failed at` in the active tool file.
+- Inline scripts in `tools/preview-generator-v2/index.html` parse successfully with `new Function`.
+- `git diff --check` passed for the PR_029 target files.
+- `npm run test:workspace-v2` is unavailable because the script is not defined in the current `package.json`.
+- `npm test` still fails in the existing shared extraction guard baseline outside this PR scope.
+
+Existing workspace changes excluded from this PR_029 ZIP:
+- Staged PR_028 sample-local README changes.
+- Unstaged `samples/phase-12/*/assets/images/preview.svg` changes.