PR_03_04_FINAL_CLEANUP_SWEEP

Author: DavidQ

docs/dev/CODEX_COMMANDS.md

@@ -1,47 +1,21 @@
-PR Naming Rule:
-ALL PRs MUST follow:
-PR_<SECTION>_<STEP>_<SHORT_NAME>
-
-Reject any PR name that does not follow this format.
-
 MODEL: GPT-5.4
 REASONING: high
 
 COMMAND:
-Implement PR_03_03_SHARED_SELECTORS_CONTRACTS.
+Implement PR_03_04_FINAL_CLEANUP_SWEEP.
 
 Goal:
-Standardize selector usage and contract boundaries onto shared state/public reader surfaces with no behavior or API changes.
-
-Target areas:
-- src/shared/state/
-- public selector/read boundary surfaces
-
-Focus:
-- getState
-- getSimulationState
-- getReplayState
-- getEditorState
-- public selector/read boundaries
-
-Required steps:
-1. Produce docs/dev/reports/selector_usage_scan.txt for selector variants and consumers in scope.
-2. Produce docs/dev/reports/contract_map.txt with exact source -> standardized target mapping.
-3. Standardize consumers in scope onto shared selector/contract surfaces.
-4. Remove only obsolete duplicate selector/contract implementations within this PR scope.
-5. Keep changes surgical.
+Final cleanup of shared extraction with no behavior changes.
 
-Rules:
-- selector/contract work only
-- no number/string/id helper extraction
-- no broad cleanup
-- no API changes
-- no behavior changes
+Steps:
+1. Scan for duplicate helpers/selectors.
+2. Remove or consolidate safely.
+3. Fix imports to canonical shared locations.
 
 Validation:
-- impacted imports resolve
-- duplicate selector variants in scope removed or redirected
-- impacted tests/smoke pass
+- no duplicates remain
+- imports resolve
+- tests pass
 
 Return ZIP:
-<project folder>/tmp/PR_03_03_SHARED_SELECTORS_CONTRACTS.zip
+<project folder>/tmp/PR_03_04_FINAL_CLEANUP_SWEEP.zip

docs/dev/COMMIT_COMMENT.txt

@@ -1 +1 @@
-PR_03_03_SHARED_SELECTORS_CONTRACTS
+PR_03_04_FINAL_CLEANUP_SWEEP

docs/dev/reports/validation_checklist.txt

@@ -1,7 +1,4 @@
-[ ] selector_usage_scan.txt generated
-[ ] contract_map.txt generated
-[ ] selectors/contracts standardized to shared surfaces
-[ ] no API changes
-[ ] no behavior changes
-[ ] impacted imports resolve
-[ ] impacted tests/smoke pass
+[ ] final cleanup scan complete
+[ ] no duplicates remain
+[ ] imports resolved
+[ ] tests pass

docs/pr/PR_03_04_FINAL_CLEANUP_SWEEP.md

@@ -0,0 +1,26 @@
+# PR_03_04_FINAL_CLEANUP_SWEEP
+
+## Purpose
+Final cleanup sweep for shared extraction ensuring no residual duplicates or inconsistencies remain.
+
+## Scope
+- cleanup only
+- no behavior changes
+- no API changes
+
+## Tasks
+1. Identify any remaining duplicate helpers/selectors in shared scope.
+2. Remove or consolidate safely.
+3. Ensure imports point to canonical shared locations.
+
+## Deliverables
+- docs/dev/reports/final_cleanup_scan.txt
+- docs/dev/reports/validation_checklist.txt
+
+## Validation
+- no duplicate helpers/selectors remain in scope
+- all imports resolve
+- tests pass
+
+## Output
+<project folder>/tmp/PR_03_04_FINAL_CLEANUP_SWEEP.zip

src/shared/utils/arrayUtils.js

@@ -1,4 +1,4 @@
-import { sanitizeText } from "/src/engine/debug/inspectors/shared/inspectorUtils.js";
+import { sanitizeText } from "./stringUtils.js";
 
 export function ensureArray(value) {
   return Array.isArray(value) ? value : [];
@@ -17,3 +17,4 @@ export function asStringArray(value) {
   });
   return Array.from(unique.values());
 }
+