Fix Object Vector Studio V2 canvas origin/palette behavior and restore game audio playback - PR_26132_011-object-vector-view-and-audio-fixes

Author: DavidQ

docs/dev/reports/playwright_v8_coverage.txt

@@ -20,10 +20,10 @@ Exercised tool entry points detected:
 (0%) Workspace Manager - not exercised by this Playwright run
 
 Changed runtime JS files covered:
+(84%) src/engine/audio/GaplessLoopPlayer.js - executed lines 187/187; executed functions 16/19
 (86%) tools/workspace-manager-v2/js/WorkspaceManagerV2App.js - executed lines 963/963; executed functions 42/49
 (91%) tools/workspace-manager-v2/js/services/WorkspaceManagerV2ContextService.js - executed lines 1598/1598; executed functions 145/159
-(92%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 286/286; executed functions 33/36
-(92%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 1595/1595; executed functions 174/189
+(92%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 1618/1618; executed functions 176/191
 (93%) tools/workspace-manager-v2/js/controls/ToolTilesControl.js - executed lines 137/137; executed functions 14/15
 
 Files with executed line/function counts where available:
@@ -47,7 +47,6 @@ Files with executed line/function counts where available:
 (14%) src/engine/runtime/BrowserDownloadService.js - executed lines 38/38; executed functions 1/7
 (14%) src/engine/scene/TransitionScene.js - executed lines 58/58; executed functions 1/7
 (15%) games/Asteroids/game/AsteroidsAttractAdapter.js - executed lines 229/229; executed functions 3/20
-(15%) src/engine/audio/MediaTrackService.js - executed lines 139/139; executed functions 2/13
 (16%) src/engine/audio/AudioService.js - executed lines 258/258; executed functions 4/25
 (17%) src/engine/camera/Camera2D.js - executed lines 44/44; executed functions 1/6
 (17%) src/engine/collision/polygon.js - executed lines 73/73; executed functions 1/6
@@ -68,7 +67,6 @@ Files with executed line/function counts where available:
 (20%) src/shared/math/numberNormalization.js - executed lines 35/35; executed functions 2/10
 (20%) src/shared/utils/objectUtils.js - executed lines 20/20; executed functions 1/5
 (20%) tools/shared/toolBootContract.js - executed lines 34/34; executed functions 1/5
-(25%) src/engine/audio/GaplessLoopPlayer.js - executed lines 165/165; executed functions 3/12
 (25%) src/engine/release/ReleaseValidationChecklist.js - executed lines 43/43; executed functions 1/4
 (25%) src/engine/release/SettingsSystem.js - executed lines 94/94; executed functions 3/12
 (25%) src/engine/rendering/ResolutionScaler.js - executed lines 22/22; executed functions 1/4
@@ -81,7 +79,6 @@ Files with executed line/function counts where available:
 (29%) src/engine/audio/WebAudioToneBackend.js - executed lines 65/65; executed functions 2/7
 (32%) tools/shared/assetUsageIntegration.js - executed lines 301/301; executed functions 8/25
 (32%) tools/shared/platformShell.js - executed lines 2159/2159; executed functions 38/120
-(33%) games/Asteroids/systems/AsteroidsAudio.js - executed lines 106/106; executed functions 3/9
 (33%) src/engine/audio/FrequencyPlayer.js - executed lines 25/25; executed functions 1/3
 (33%) src/engine/audio/Synthesizer.js - executed lines 24/24; executed functions 1/3
 (33%) src/engine/camera/CameraSystem.js - executed lines 21/21; executed functions 1/3
@@ -103,7 +100,6 @@ Files with executed line/function counts where available:
 (37%) tools/asset-manager-v2/js/assetManagerMetadata.js - executed lines 331/331; executed functions 10/27
 (38%) src/engine/camera/Camera3D.js - executed lines 48/48; executed functions 3/8
 (39%) games/Asteroids/game/AsteroidsWorld.js - executed lines 756/756; executed functions 19/49
-(40%) src/engine/audio/HtmlAudioMediaBackend.js - executed lines 22/22; executed functions 2/5
 (40%) src/engine/input/MouseState.js - executed lines 57/57; executed functions 4/10
 (40%) src/shared/utils/mathUtils.js - executed lines 29/29; executed functions 2/5
 (41%) games/Asteroids/game/AsteroidsGameScene.js - executed lines 788/788; executed functions 18/44
@@ -129,6 +125,7 @@ Files with executed line/function counts where available:
 (50%) src/shared/utils/stringifyValueUtils.js - executed lines 8/8; executed functions 1/2
 (50%) tools/common/PaletteUsageService.js - executed lines 5/5; executed functions 1/2
 (50%) tools/world-vector-studio-v2/js/ToolStarterApp.js - executed lines 98/98; executed functions 8/16
+(54%) src/engine/audio/MediaTrackService.js - executed lines 139/139; executed functions 7/13
 (54%) tools/preview-generator-v2/PreviewGeneratorV2Capture.js - executed lines 497/497; executed functions 14/26
 (55%) tools/palette-manager-v2/modules/PaletteManagerApp.js - executed lines 975/975; executed functions 63/115
 (56%) src/engine/logging/Logger.js - executed lines 56/56; executed functions 5/9
@@ -142,6 +139,7 @@ Files with executed line/function counts where available:
 (62%) tools/palette-manager-v2/modules/SwatchRow.js - executed lines 115/115; executed functions 8/13
 (63%) src/shared/string/stringHelpers.js - executed lines 26/26; executed functions 5/8
 (63%) tools/asset-manager-v2/js/AssetManagerV2App.js - executed lines 643/643; executed functions 36/57
+(64%) games/Asteroids/systems/AsteroidsAudio.js - executed lines 134/134; executed functions 9/14
 (64%) games/Pong/game/PongScene.js - executed lines 521/521; executed functions 21/33
 (65%) tools/palette-manager-v2/controls/SourcePaletteBrowserControl.js - executed lines 121/121; executed functions 15/23
 (67%) games/Asteroids/utils/math.js - executed lines 14/14; executed functions 2/3
@@ -186,12 +184,13 @@ Files with executed line/function counts where available:
 (82%) tools/session-inspector-v2/js/controls/EntryListControl.js - executed lines 59/59; executed functions 9/11
 (83%) tools/palette-manager-v2/main.js - executed lines 227/227; executed functions 15/18
 (83%) tools/session-inspector-v2/js/controls/AccordionSection.js - executed lines 41/41; executed functions 5/6
+(84%) src/engine/audio/GaplessLoopPlayer.js - executed lines 187/187; executed functions 16/19
 (86%) games/shared/gameSkinLoader.js - executed lines 352/352; executed functions 18/21
-(86%) games/shared/workspaceGameAssetCatalog.js - executed lines 253/253; executed functions 18/21
 (86%) tools/asset-manager-v2/js/controls/AssetCatalogControl.js - executed lines 134/134; executed functions 12/14
 (86%) tools/workspace-manager-v2/js/controls/RepoDestinationControl.js - executed lines 25/25; executed functions 6/7
 (86%) tools/workspace-manager-v2/js/WorkspaceManagerV2App.js - executed lines 963/963; executed functions 42/49
 (88%) games/Pong/game/PongInputController.js - executed lines 77/77; executed functions 7/8
+(88%) games/shared/workspaceGameAssetCatalog.js - executed lines 311/311; executed functions 23/26
 (88%) tools/preview-generator-v2/PreviewGeneratorV2App.js - executed lines 1498/1498; executed functions 107/121
 (88%) tools/shared/toolLaunchSSoTData.js - executed lines 112/112; executed functions 14/16
 (88%) tools/text2speech-V2/js/controls/TextInputControl.js - executed lines 24/24; executed functions 7/8
@@ -207,7 +206,7 @@ Files with executed line/function counts where available:
 (91%) tools/workspace-manager-v2/js/services/WorkspaceManagerV2ContextService.js - executed lines 1598/1598; executed functions 145/159
 (92%) tools/object-vector-studio-v2/js/controls/ToolStarterShellControl.js - executed lines 112/112; executed functions 11/12
 (92%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 286/286; executed functions 33/36
-(92%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 1595/1595; executed functions 174/189
+(92%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 1618/1618; executed functions 176/191
 (93%) tools/asset-manager-v2/js/services/WorkspaceBridge.js - executed lines 305/305; executed functions 25/27
 (93%) tools/session-inspector-v2/js/SessionInspectorV2App.js - executed lines 337/337; executed functions 42/45
 (93%) tools/text2speech-V2/js/controls/QueueControl.js - executed lines 122/122; executed functions 26/28
@@ -224,6 +223,7 @@ Files with executed line/function counts where available:
 (100%) games/shared/workspaceGameBoot.js - executed lines 15/15; executed functions 3/3
 (100%) samples/phase-19/1903/main.js - executed lines 33/33; executed functions 5/5
 (100%) samples/shared/numberUtils.js - executed lines 7/7; executed functions 1/1
+(100%) src/engine/audio/HtmlAudioMediaBackend.js - executed lines 22/22; executed functions 5/5
 (100%) src/engine/audio/index.js - executed lines 17/17; executed functions 1/1
 (100%) src/engine/audio/TextToSpeechDefaults.js - executed lines 108/108; executed functions 1/1
 (100%) src/engine/camera/index.js - executed lines 10/10; executed functions 1/1
@@ -295,9 +295,10 @@ Uncovered or low-coverage changed JS files:
 
 Changed JS files considered:
 (0%) tests/playwright/tools/WorkspaceManagerV2.spec.mjs - changed JS file not collected as browser runtime coverage
-(0%) tools/object-vector-studio-v2/tests/playwright/FirstClassToolStarter.spec.mjs - changed JS file not collected as browser runtime coverage
+(64%) games/Asteroids/systems/AsteroidsAudio.js - changed JS file with browser V8 coverage
+(84%) src/engine/audio/GaplessLoopPlayer.js - changed JS file with browser V8 coverage
 (86%) tools/workspace-manager-v2/js/WorkspaceManagerV2App.js - changed JS file with browser V8 coverage
+(88%) games/shared/workspaceGameAssetCatalog.js - changed JS file with browser V8 coverage
 (91%) tools/workspace-manager-v2/js/services/WorkspaceManagerV2ContextService.js - changed JS file with browser V8 coverage
-(92%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - changed JS file with browser V8 coverage
 (92%) tools/object-vector-studio-v2/js/ToolStarterApp.js - changed JS file with browser V8 coverage
 (93%) tools/workspace-manager-v2/js/controls/ToolTilesControl.js - changed JS file with browser V8 coverage

docs/pr/PR_26132_011-object-vector-view-and-audio-fixes.md

@@ -0,0 +1,64 @@
+# PR_26132_011-object-vector-view-and-audio-fixes
+
+## Scope
+
+Fixes Object Vector Studio V2 centered viewport behavior, palette swatch rendering, Asteroids object-vector manifest validation, and the shared game audio path/playback regression.
+
+## Changes
+
+- Object Vector Studio V2 now treats canvas origin `0,0` as the center of the SVG work surface.
+- Reset View restores the viewport origin to `0,0` and logs the exact reset state.
+- A visible center-origin dot is drawn at `0,0` in loaded, empty, and palette-blocked render states.
+- Primitive default geometry now lands inside the centered viewport.
+- Palette colors render as square swatches only, with hover/title and aria details for the color label/value.
+- The Object Vector work-area row sizing was tightened so render summary text does not overlap or intercept SVG shape clicks.
+- Asteroids audio now resolves current `asset-manager-v2` manifest IDs directly.
+- Shared game asset catalog loading now reads `game.workspace.tools.asset-manager-v2.assets` and resolves `assets/...` paths against `game.workspace.assetsPath`.
+- Gapless loop playback now records actionable load/play errors instead of failing silently.
+
+## Asteroids Object Assets
+
+Reviewed `games/Asteroids/game.manifest.json` Object Vector Studio V2 payload:
+
+- `object.asteroids.ship`
+- `object.asteroids.asteroid.large`
+- `object.asteroids.asteroid.medium`
+- `object.asteroids.asteroid.small`
+- `object.asteroids.ufo.large`
+- `object.asteroids.ufo.small`
+
+Schema check passed against `tools/schemas/tools/object-vector-studio-v2.schema.json` with 6 objects and no validation errors.
+
+## Validation
+
+Playwright impacted: Yes.
+
+Commands run:
+
+- `node --check games/shared/workspaceGameAssetCatalog.js`
+- `node --check games/Asteroids/systems/AsteroidsAudio.js`
+- `node --check src/engine/audio/GaplessLoopPlayer.js`
+- `node --check tools/object-vector-studio-v2/js/ToolStarterApp.js`
+- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list -g "resolves asset-manager-v2 audio catalog paths"`
+- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list -g "shows Object Vector Studio V2 layout shell and schema-only palette gate"`
+- `npm run test:workspace-v2`
+- Object Vector Studio V2 Asteroids manifest schema validation via `ObjectVectorStudioV2SchemaService`
+
+Result:
+
+- `npm run test:workspace-v2`: 40 passed.
+- Targeted audio/game validation passed for wav playback and wav/mp3 manifest path resolution.
+- Full samples smoke test skipped because this PR is scoped to Workspace Manager V2/Object Vector Studio V2 and affected Asteroids audio path validation; broad sample-loader behavior was not changed.
+
+## Manual Validation
+
+1. Open Object Vector Studio V2, load a valid object payload and runtime palette, and confirm Reset View returns the work surface to centered origin `0,0`.
+2. Confirm the center dot remains visible and shape clicks work near the center of the surface.
+3. Hover palette swatches and confirm color details are visible.
+4. Launch Asteroids and verify fire/loop sounds play from `game.manifest.json` asset-manager-v2 audio entries.
+
+## Out Of Scope
+
+- No unrelated gameplay changes.
+- No full samples smoke test.
+- No `start_of_day` changes.