Gate Workspace Manager game selection and tools until repo and active game are explicitly selected - PR_26128_009-workspace-selection-gates

Author: DavidQ

docs/dev/reports/playwright_workspace_selection_gates.md

@@ -0,0 +1,23 @@
+# Playwright Workspace Selection Gates
+
+## Command
+`npm run test:workspace-v2`
+
+## Result
+PASS: 12 passed
+
+## Targeted Coverage
+- Verified initial Workspace Manager V2 load has an empty disabled Active Game dropdown.
+- Verified stale sessionStorage does not preselect Asteroids on direct initial load.
+- Verified workspace tools are disabled before repo selection.
+- Verified repo selection discovers and validates `game.manifest.json` files.
+- Verified Active Game enables after valid games are found.
+- Verified no game is auto-selected after discovery.
+- Verified workspace tools remain disabled until the user manually selects a valid game.
+- Verified workspace tools enable after a valid game selection.
+- Verified failed repo load clears and disables Active Game and keeps tools disabled.
+- Verified no-valid-games discovery keeps Active Game disabled and tools disabled.
+- Verified invalid manifests are skipped and logged with exact path and validation reason.
+
+## Skipped
+- Full samples smoke test was skipped as requested. The targeted Workspace Manager V2 Playwright suite covers the changed selection gates, repo discovery, invalid-manifest logging, and affected launch gating behavior.

docs/dev/reports/workspace_selection_gates.md

@@ -0,0 +1,30 @@
+# PR_26128_009 Workspace Selection Gates
+
+## Summary
+- Workspace Manager V2 now ignores stale stored workspace context on plain initial load.
+- Explicit `hostContextId` URLs still restore workspace context for the existing return-from-tool flow.
+- Active Game remains empty and disabled on initial load.
+- Tools remain disabled before repo selection, after repo discovery, after failed repo load, and when no valid games are found.
+- Tools enable only after the user manually selects a valid discovered game.
+
+## Selection Flow
+- User selects a repo folder.
+- Workspace Manager V2 recursively scans `games/` for `game.manifest.json`.
+- Each discovered game manifest validates against the dedicated game manifest schema.
+- Invalid manifests are skipped and logged with exact path and reason.
+- Active Game enables only when one or more valid games are found.
+- No game is auto-selected after discovery.
+- The user manually selects a game before workspace tools become enabled.
+
+## Scope Notes
+- `game.manifest.json` remains the only required game project manifest.
+- No separate `workspace.manifest.json` was introduced.
+- No sample JSON was modified.
+- No roadmap content was modified.
+- No cross-tool communication was added.
+- Full samples smoke test was skipped because this BUILD requested targeted Workspace Manager V2 validation and explicitly said to skip full samples smoke.
+
+## Validation
+- PASS: `node --check tools/workspace-manager-v2/js/services/WorkspaceManagerV2ContextService.js`
+- PASS: `node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs`
+- PASS: `npm run test:workspace-v2` - 12 passed

tests/playwright/tools/WorkspaceManagerV2.spec.mjs

@@ -132,6 +132,12 @@ async function selectMockRepo(page, { repoName = "HTML-JavaScript-Gaming" } = {}
     "Gravity Well",
     "Pong"
   ]);
+  await expectWorkspaceToolsDisabled(page);
+}
+
+async function expectWorkspaceToolsDisabled(page) {
+  await expect(page.locator("#workspaceToolTiles [data-workspace-tool-id]")).toHaveCount(4);
+  expect(await page.locator("#workspaceToolTiles [data-workspace-tool-id]").evaluateAll((tiles) => tiles.every((tile) => tile.disabled))).toBe(true);
 }
 
 test.describe("Workspace Manager V2 bootstrap", () => {
@@ -263,6 +269,33 @@ test.describe("Workspace Manager V2 bootstrap", () => {
     }
   });
 
+  test("starts with no active game even when stale session state exists", async ({ page }) => {
+    const staleGameManifest = JSON.parse(await readFile("games/Asteroids/game.manifest.json", "utf8"));
+    const pageErrors = [];
+    await page.addInitScript((manifest) => {
+      window.sessionStorage.setItem("workspace-manager-v2-stale-context", JSON.stringify(manifest));
+      window.sessionStorage.setItem("workspace-manager-v2-active-host-context-id", "workspace-manager-v2-stale-context");
+    }, staleGameManifest.game.workspace);
+    const server = await openWorkspaceManagerV2(page);
+
+    page.on("pageerror", (error) => {
+      pageErrors.push(error.message);
+    });
+
+    try {
+      await expect(page.locator("#repoSelectedValue")).toHaveText("not selected");
+      await expect(page.locator("#activeGameSelect")).toBeDisabled();
+      await expect(page.locator("#activeGameSelect option")).toHaveCount(0);
+      await expect(page.locator("#workspaceContextOutput")).toHaveValue("{}");
+      await expectWorkspaceToolsDisabled(page);
+      await expect(page.locator("#statusLog")).not.toHaveValue(/Restored Asteroids workspace/);
+      expect(pageErrors).toEqual([]);
+    } finally {
+      await coverageReporter.stop(page);
+      await server.close();
+    }
+  });
+
   test("discovers Active Game options from selected repo manifests", async ({ page }) => {
     const server = await openWorkspaceManagerV2(page);
     const pageErrors = [];
@@ -275,6 +308,7 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#activeGameSelect")).toBeDisabled();
       await expect(page.locator("#activeGameSelect option")).toHaveCount(0);
       await expect(page.locator("#activeGameSummary")).toHaveText("Pick a repo folder to discover schema-valid game manifests.");
+      await expectWorkspaceToolsDisabled(page);
 
       await selectMockRepo(page);
       await expect(page.locator("#activeGameSummary")).toHaveText("Discovered 3 schema-valid game manifests from HTML-JavaScript-Gaming.");
@@ -322,9 +356,25 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#repoSelectedValue")).toHaveText("not selected");
       await expect(page.locator("#activeGameSelect")).toBeDisabled();
       await expect(page.locator("#activeGameSelect option")).toHaveCount(0);
+      await expectWorkspaceToolsDisabled(page);
       await expect(page.locator("#activeGameSummary")).toHaveText(/Selected repo is missing games\//);
       await expect(page.locator("#statusLog")).toHaveValue(/FAIL Repo load failed: Selected repo is missing games\//);
 
+      await page.evaluate(() => {
+        window.__workspaceManagerV2MockRepoConfig = {
+          manifestPaths: [],
+          repoName: "NoValidGamesRepo"
+        };
+      });
+      await page.locator("#pickRepoBtn").click();
+      await expect(page.locator("#repoSelectedValue")).toHaveText("NoValidGamesRepo");
+      await expect(page.locator("#activeGameSelect")).toBeDisabled();
+      await expect(page.locator("#activeGameSelect option")).toHaveCount(0);
+      await expectWorkspaceToolsDisabled(page);
+      await expect(page.locator("#activeGameSummary")).toHaveText("No schema-valid game manifests were found in NoValidGamesRepo.");
+      await expect(page.locator("#statusLog")).toHaveValue(/INFO SKIP games\/InvalidWorkspace\/game\.manifest\.json: Game manifest failed schema validation: root\.game is required/);
+      await expect(page.locator("#statusLog")).toHaveValue(/FAIL Repo load failed: No schema-valid game\.manifest\.json files were found in NoValidGamesRepo\./);
+
       await selectMockRepo(page, { repoName: "SecondRepo" });
       await expect(page.locator("#activeGameSummary")).toHaveText("Discovered 3 schema-valid game manifests from SecondRepo.");
       await expect(page.locator("#workspaceContextOutput")).toHaveValue("{}");

tools/schemas.zip

@@ -349,7 +349,7 @@ export class WorkspaceManagerV2ContextService {
 
   async restorePersistedContext() {
     const params = new URLSearchParams(this.location.search || "");
-    const hostContextId = params.get("hostContextId") || this.sessionStorage.getItem(HOST_CONTEXT_STORAGE_KEY) || "";
+    const hostContextId = params.get("hostContextId") || "";
     return this.restorePersistedContextById(hostContextId);
   }