BUILD PR: remove remaining advanced-local asPositiveInteger duplicates and use shared number utils.

Author: DavidQ

docs/dev/CODEX_COMMANDS.md

@@ -1,13 +1,9 @@
 MODEL: GPT-5.3-codex
 REASONING: high
 COMMAND:
-Execute docs/pr/BUILD_PR_SHARED_EXTRACTION_06_PROMOTION_SNAPSHOT_IMPORT_NORMALIZATION.md exactly.
-
-Edit ONLY:
+Execute docs/pr/BUILD_PR_SHARED_EXTRACTION_07_AS_POSITIVE_INTEGER_ADVANCED_ONLY.md exactly.
+Edit only these files:
 - src/advanced/promotion/createPromotionGate.js
 - src/advanced/state/createWorldGameStateSystem.js
-
 Do not expand scope.
-
-Package output to:
-<project folder>/tmp/BUILD_PR_SHARED_EXTRACTION_06_PROMOTION_SNAPSHOT_IMPORT_NORMALIZATION_delta.zip
+Package the delta output to <project folder>/tmp/BUILD_PR_SHARED_EXTRACTION_07_AS_POSITIVE_INTEGER_ADVANCED_ONLY_delta.zip

docs/dev/COMMIT_COMMENT.txt

@@ -1 +1 @@
-BUILD PR: normalize createPromotionStateSnapshot imports in promotion/state modules only.
+BUILD PR: remove remaining advanced-local asPositiveInteger duplicates and use shared number utils.

docs/dev/NEXT_COMMAND.txt

@@ -1 +1 @@
-Next: continue with next executable BUILD (no APPLY).
+Next: if clean, continue with the next executable BUILD. If blocked, capture the exact blocker and narrow further without changing PR purpose.

docs/dev/reports/change_summary.txt

@@ -1 +1 @@
-Normalized import paths for shared promotion snapshot helper to prevent path drift.
+Built the next executable shared-extraction step by narrowing to the two remaining advanced modules that still carried local asPositiveInteger definitions in the repo snapshot used for this workflow.

docs/dev/reports/file_tree.txt

@@ -1 +1,11 @@
-docs/pr + docs/dev
+docs/
+  pr/
+    BUILD_PR_SHARED_EXTRACTION_07_AS_POSITIVE_INTEGER_ADVANCED_ONLY.md
+  dev/
+    codex_commands.md
+    commit_comment.txt
+    next_command.txt
+    reports/
+      change_summary.txt
+      validation_checklist.txt
+      file_tree.txt

docs/dev/reports/validation_checklist.txt

@@ -1,5 +1,9 @@
 SESSION VALIDATION GATE
-- BUILD executable: yes
-- Exact files listed: yes
-- No guessing: yes
-- Scope minimal: yes
+- Bundle type: BUILD
+- One PR purpose only: yes
+- Exact target files listed: yes
+- Exact import target listed: yes
+- No guessing beyond established shared helper path: yes
+- Repo-wide scan/refactor language avoided: yes
+- Scope minimized: yes
+- ZIP repo-structured and execution-ready: yes

docs/pr/BUILD_PR_SHARED_EXTRACTION_07_AS_POSITIVE_INTEGER_ADVANCED_ONLY.md

@@ -0,0 +1,81 @@
+# BUILD_PR_SHARED_EXTRACTION_07_AS_POSITIVE_INTEGER_ADVANCED_ONLY
+
+## Purpose
+Remove the remaining duplicated local `asPositiveInteger` helpers from the two advanced promotion/state modules and switch them to the existing shared number helper.
+
+## Single PR Purpose
+Centralize `asPositiveInteger` usage in:
+
+- `src/advanced/promotion/createPromotionGate.js`
+- `src/advanced/state/createWorldGameStateSystem.js`
+
+This BUILD does **not** change any other helper or file.
+
+## Exact Files Allowed
+Edit only these 2 files:
+
+1. `src/advanced/promotion/createPromotionGate.js`
+2. `src/advanced/state/createWorldGameStateSystem.js`
+
+Do not edit any other file.
+
+## Shared Dependency Assumption
+Use the existing shared helper already established earlier in this workflow:
+
+- `src/shared/utils/numberUtils.js`
+
+This BUILD assumes `numberUtils.js` already exports `asPositiveInteger`.
+
+Do **not** modify `src/shared/utils/numberUtils.js` in this PR.
+
+## Exact Source Changes
+
+### 1) `src/advanced/promotion/createPromotionGate.js`
+- remove the local `asPositiveInteger` function definition
+- keep all other local helpers exactly as they are
+- add exactly one import for `asPositiveInteger` from:
+
+```js
+import { asPositiveInteger } from '../../shared/utils/numberUtils.js';
+```
+
+If an import for `asPositiveInteger` already exists, do not duplicate it.
+
+### 2) `src/advanced/state/createWorldGameStateSystem.js`
+- remove the local `asPositiveInteger` function definition
+- keep all other local helpers exactly as they are
+- add exactly one import for `asPositiveInteger` from:
+
+```js
+import { asPositiveInteger } from '../../shared/utils/numberUtils.js';
+```
+
+If an import for `asPositiveInteger` already exists, do not duplicate it.
+
+## Hard Constraints
+- do not edit any file other than the 2 listed above
+- do not change `asFiniteNumber`
+- do not change `isPlainObject`
+- do not change `getState`
+- do not change promotion snapshot imports
+- do not modify logic or behavior
+- do not perform repo-wide helper cleanup
+- do not create any new file
+- do not modify `src/shared/utils/numberUtils.js`
+
+## Validation Checklist
+1. Confirm only the 2 listed files changed
+2. Confirm local `asPositiveInteger` function definitions no longer exist in:
+   - `src/advanced/promotion/createPromotionGate.js`
+   - `src/advanced/state/createWorldGameStateSystem.js`
+3. Confirm both files import `asPositiveInteger` from exactly:
+   - `../../shared/utils/numberUtils.js`
+4. Confirm there is only one `asPositiveInteger` import per file
+5. Confirm no other helper definitions or logic changed
+
+## Non-Goals
+- no changes to any debug inspector files
+- no changes to `src/shared/utils/numberUtils.js`
+- no broader number helper normalization
+- no repo-wide import cleanup
+- no refactor beyond this exact duplicate-removal step

src/advanced/promotion/createPromotionGate.js

@@ -5,15 +5,10 @@ David Quesenberry
 createPromotionGate.js
 */
 
-import { asFiniteNumber } from '../../shared/utils/numberUtils.js';
+import { asFiniteNumber, asPositiveInteger } from '../../shared/utils/numberUtils.js';
 import { isPlainObject } from '../../shared/utils/objectUtils.js';
 import { createPromotionStateSnapshot } from '../shared/state/createPromotionStateSnapshot.js';
 
-function asPositiveInteger(value, fallback = 1) {
-  const numeric = Math.floor(asFiniteNumber(value, fallback));
-  return numeric >= 1 ? numeric : fallback;
-}
-
 function normalizeCriteriaMap(input, requiredCriteria = []) {
   const normalized = {};
   if (isPlainObject(input)) {

src/advanced/state/createWorldGameStateSystem.js

@@ -19,7 +19,7 @@ import {
   createTransitionRejectedEvent
 } from './events.js';
 import { createPromotionStateSnapshot } from '../../shared/state/createPromotionStateSnapshot.js';
-import { asFiniteNumber } from '../../shared/utils/numberUtils.js';
+import { asFiniteNumber, asPositiveInteger } from '../../shared/utils/numberUtils.js';
 import {
   cloneDeep,
   createReadonlyClone,
@@ -78,11 +78,6 @@ function resolveFrameFromMeta(meta, payload) {
   return null;
 }
 
-function asPositiveInteger(value, fallback = 1) {
-  const numeric = Math.floor(asFiniteNumber(value, fallback));
-  return numeric >= 1 ? numeric : fallback;
-}
-
 function normalizeRequiredCriteria(requiredCriteria) {
   if (!Array.isArray(requiredCriteria)) return [];
   const seen = new Set();