Skip to content

Commit 61f73ca

Browse files
author
DavidQ
committed
Clarify active palette ownership and Session Library behavior in Workspace V2 - PR_11_307
1 parent 60fe0c0 commit 61f73ca

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

tools/workspace-v2/index.js

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -533,6 +533,10 @@ class WorkspaceV2SessionProducer {
533533
return "Workspace already has an active palette. Only one active palette is allowed.";
534534
}
535535

536+
singleActivePaletteLibraryMessage() {
537+
return "Palette is already the active workspace palette at tools.palette-browser. It is not saved as a Session Library entry.";
538+
}
539+
536540
isBlockedAlternatePaletteSession(sessionId, sessionPayload) {
537541
if (!this.hasWorkspaceActivePalette()) {
538542
return false;
@@ -722,7 +726,7 @@ class WorkspaceV2SessionProducer {
722726
updateSessionLibraryActionState() {
723727
const model = this.refreshWorkspaceSessionUiStateModel("refresh_load");
724728
if (model.libraryPaletteLocked) {
725-
this.libraryStatusNode.textContent = "Workspace already has an active palette. Only one active palette is allowed.";
729+
this.libraryStatusNode.textContent = this.singleActivePaletteLibraryMessage();
726730
return;
727731
}
728732
if (!model.libraryHasSessionInput) {
@@ -1683,7 +1687,7 @@ class WorkspaceV2SessionProducer {
16831687
return;
16841688
}
16851689
if (this.isBlockedAlternatePaletteSession(sessionId.trim(), library[sessionId.trim()])) {
1686-
this.setLibraryStatus(this.singleActivePaletteBlockedMessage());
1690+
this.setLibraryStatus(this.singleActivePaletteLibraryMessage());
16871691
return;
16881692
}
16891693
this.sessionNameNode.value = sessionId.trim();
@@ -1712,11 +1716,11 @@ class WorkspaceV2SessionProducer {
17121716
return;
17131717
}
17141718
if (this.isBlockedAlternatePaletteSession(sessionId.trim(), library[sessionId.trim()])) {
1715-
this.setLibraryStatus(this.singleActivePaletteBlockedMessage());
1719+
this.setLibraryStatus(this.singleActivePaletteLibraryMessage());
17161720
return;
17171721
}
17181722
if (this.isBlockedAlternatePaletteSession(sessionId.trim(), activePayload)) {
1719-
this.setLibraryStatus(this.singleActivePaletteBlockedMessage());
1723+
this.setLibraryStatus(this.singleActivePaletteLibraryMessage());
17201724
return;
17211725
}
17221726
library[sessionId.trim()] = activePayload;
@@ -4017,7 +4021,7 @@ class WorkspaceV2SessionProducer {
40174021
return;
40184022
}
40194023
if (this.isBlockedAlternatePaletteSession(sessionName, payloadForWrite)) {
4020-
this.setLibraryStatus(this.singleActivePaletteBlockedMessage());
4024+
this.setLibraryStatus(this.singleActivePaletteLibraryMessage());
40214025
return;
40224026
}
40234027
library[sessionName] = payloadForWrite;
@@ -4044,7 +4048,7 @@ class WorkspaceV2SessionProducer {
40444048
}
40454049
const payload = library[sessionName];
40464050
if (this.isBlockedAlternatePaletteSession(sessionName, payload)) {
4047-
this.setLibraryStatus(this.singleActivePaletteBlockedMessage());
4051+
this.setLibraryStatus(this.singleActivePaletteLibraryMessage());
40484052
return;
40494053
}
40504054
if (!this.applySessionPayload(payload, `library:${sessionName}`)) {

0 commit comments

Comments
 (0)