Begin Phase 1 extraction of duplicated helpers into shared utility modules - PR_26140_032-shared-utils-phase-1

Author: DavidQ

docs/dev/reports/PR_26140_032-shared-utils-phase-1_report.md

@@ -0,0 +1,47 @@
+# PR_26140_032 Shared Utils Phase 1 Report
+
+## Scope
+
+- Used `tmp/dupes_called.txt` as the extraction candidate source list.
+- Ignored `node_modules`, `tests/results`, `docs/dev/reports` snapshots, archived tools, generated/vendor bundles, and unrelated sample noise.
+- Kept Phase 1 limited to Object Vector runtime/rendering helpers covered by the requested validation path.
+
+## Extracted
+
+- Reused shared `isPlainObject` from `src/shared/utils/objectUtils.js` in:
+  - `src/engine/rendering/ObjectVectorRuntimeAssetService.js`
+- Reused shared `deepClone` from `src/shared/utils/jsonUtils.js` as exact JSON clone in:
+  - `src/engine/rendering/ObjectVectorRuntimeAssetService.js`
+- Reused shared `isRecord` from `src/shared/types/typeGuards.js` in:
+  - `src/engine/rendering/ObjectVectorTransformService.js`
+
+## Skipped Candidates
+
+- `normalizePath`: skipped because current candidates differ on trimming, slash collapsing, leading/trailing slash removal, and fallback behavior.
+- `toFiniteNumber`: skipped gameplay/game-world candidates to avoid changing unrelated gameplay behavior without broader game validation.
+- `normalizePoints`: skipped Object Vector collision/vector-contract candidates because one preserves non-finite point entries through fallback conversion while the shared Asteroids helper filters non-finite points.
+- `clamp`, `normalizeText`, `asArray`: left for a later focused pass where each call site can be grouped by exact semantics and validated through the owning feature.
+- `clone` / `deepClone`: only changed exact JSON clone call sites in the Object Vector runtime asset service.
+
+## Validation
+
+- PASS `npm run build:manifest`
+- PASS `node tests/games/AsteroidsValidation.test.mjs`
+- PASS `node tests/games/AsteroidsPresentation.test.mjs`
+- PASS `node tests/tools/ObjectVectorStudioV2DeleteCleanup.test.mjs`
+- PASS `npx playwright test tests/playwright/tools/AsteroidsGameSceneCleanup.spec.mjs tests/playwright/tools/ObjectVectorStudioV2FirstClassToolStarter.spec.mjs tests/playwright/tools/CollisionInspectorV2.spec.mjs --project=playwright --workers=1 --reporter=list`
+- PASS `git diff --check`
+- PASS vendor/generated modification check: no `node_modules`, vendor, generated, bundled, archived, report snapshot, or test-result paths were modified.
+
+## Coverage
+
+- Playwright V8 coverage refreshed by the targeted Playwright run.
+- `docs/dev/reports/coverage_changed_js_guardrail.txt` reports:
+  - `(80%) src/engine/rendering/ObjectVectorTransformService.js`
+  - `(81%) src/engine/rendering/ObjectVectorRuntimeAssetService.js`
+  - no changed runtime JS coverage warnings.
+
+## Notes
+
+- `docs/build/sample-manifest.json` was generated by `npm run build:manifest` and removed after validation.
+- Full samples smoke test skipped; this PR is scoped shared utility extraction with targeted runtime/tool validation.

src/engine/rendering/ObjectVectorRuntimeAssetService.js

@@ -8,18 +8,12 @@ import {
   objectVectorSvgTransformAttribute
 } from "./OrientationTransform.js";
 import { createWorldScreenTransform } from "./WorldScreenTransform.js";
+import { isPlainObject } from "../../shared/utils/objectUtils.js";
+import { deepClone as clone } from "../../shared/utils/jsonUtils.js";
 
 const DEFAULT_SCHEMA_URL = new URL("../../../tools/schemas/tools/object-vector-studio-v2.schema.json", import.meta.url);
 const OBJECT_VECTOR_TOOL_ID = "object-vector-studio-v2";
 
-function isPlainObject(value) {
-  return Boolean(value) && typeof value === "object" && !Array.isArray(value);
-}
-
-function clone(value) {
-  return JSON.parse(JSON.stringify(value));
-}
-
 function isObjectIdentityId(value) {
   return /^object\.[a-z0-9-]+\.[a-z0-9][a-z0-9-]*$/.test(String(value || ""));
 }

src/engine/rendering/ObjectVectorTransformService.js

@@ -1,11 +1,9 @@
+import { isRecord } from "../../shared/types/typeGuards.js";
+
 const DEGREES_PER_RADIAN = 180 / Math.PI;
 const RADIANS_PER_DEGREE = Math.PI / 180;
 const DEFAULT_OBJECT_VECTOR_BOUNDS = Object.freeze({ height: 80, width: 120, x: -60, y: -40 });
 
-function isRecord(value) {
-  return Boolean(value) && typeof value === "object" && !Array.isArray(value);
-}
-
 function numberValue(value, fallback = 0) {
   const parsed = Number(value);
   return Number.isFinite(parsed) ? parsed : fallback;