Skip to content

Commit 5e519ed

Browse files
author
DavidQ
committed
Expand Palette Manager V2 layout when header details are hidden - PR_26124_045-palette-manager-hidden-header-wide-layout
1 parent 7b07675 commit 5e519ed

9 files changed

Lines changed: 438 additions & 454 deletions

File tree

docs/dev/codex_commands.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
# PR_26124_044-accordionv2-theme-extract
1+
# PR_26124_045-palette-manager-hidden-header-wide-layout
22

33
```bash
4-
npx @openai/codex run --model gpt-5.5 --reasoning high "Run full workflow for PR_26124_044-accordionv2-theme-extract. Follow PROJECT_INSTRUCTIONS.md exactly. Move the working accordionV2 implementation from palette-manager-v2 into src/engine/theme/accordionV2 and update palette-manager-v2 to use the shared accordionV2 without behavior changes."
4+
npx @openai/codex run --model gpt-5.5 --reasoning high "Run full workflow for PR_26124_045-palette-manager-hidden-header-wide-layout. Follow PROJECT_INSTRUCTIONS.md exactly. Update only palette-manager-v2 layout behavior when the shared platform header/details area is hidden."
55
```
66

77
## Validation Commands
@@ -15,7 +15,8 @@ npm run test:workspace-v2
1515
## Manual Validation
1616

1717
- Open `tools/palette-manager-v2/index.html`.
18-
- Confirm User Palette and Add User Swatch use shared `.accordion-v2` classes.
19-
- Confirm both open panels share center height.
20-
- Collapse either panel and confirm the other fills available center height.
21-
- Confirm source select, search, sort, size, pin, and unpin still work.
18+
- Confirm normal layout is unchanged.
19+
- Click `Hide Header and Details`.
20+
- Confirm left/right panels anchor to the viewport sides.
21+
- Confirm center fills the space between them and uses available height.
22+
- Confirm accordionV2 behavior remains unchanged.

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Extract accordionV2 into shared theme component and reuse it in Palette Manager - PR_26124_044-accordionv2-theme-extract
1+
Expand Palette Manager layout when platform header is hidden - PR_26124_045-palette-manager-hidden-header-wide-layout
Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
# PR_26124_045 Report
2+
3+
## Purpose
4+
Update Palette Manager V2 layout only when the shared platform header/details area is hidden.
5+
6+
## Changes
7+
- Added CSS overrides scoped to the existing platform hidden-header/fullscreen state.
8+
- Expanded Palette Manager to full available width only when hidden-header state is active.
9+
- Anchored left and right panels to their grid edges in hidden-header state.
10+
- Let the center panel fill the horizontal space and available viewport height in hidden-header state.
11+
- Preserved normal non-hidden-header layout.
12+
13+
## Boundaries Confirmed
14+
- No workspace/toolState/session changes.
15+
- No sample JSON changes.
16+
- No `tools/shared` changes.
17+
- No shared accordionV2 changes.
18+
- No dependencies added.
19+
20+
## Validation
21+
- No PR045 JS files changed.
22+
- `node --check src/engine/theme/accordionV2/accordionV2.js` -> PASS
23+
- `node --check tools/palette-manager-v2/modules/PaletteManagerApp.js` -> PASS
24+
- `git diff --check` -> PASS with existing Git LF/CRLF warning
25+
- Browser/manual layout validation at 1920x1000 -> PASS
26+
- `npm run test:workspace-v2` -> FAIL: missing npm script
27+
28+
## Playwright
29+
- Required command was executed but failed before tests ran because `test:workspace-v2` is not defined in `package.json`.
30+
- Expected pass behavior after script restoration: Workspace V2 validation should pass with Palette Manager hidden-header layout overrides.
31+
- Expected fail behavior: Workspace V2 failures should identify a lifecycle or tool validation regression.
32+
33+
## Manual Validation Details
34+
- Normal layout remained capped at `1600px`.
35+
- Clicking `Hide Header and Details` entered existing platform fullscreen state.
36+
- Hidden-header layout expanded to full viewport width.
37+
- Left panel anchored near the left edge.
38+
- Right panel anchored near the right edge.
39+
- Center panel filled the space between left and right panels.
40+
- Center panel used available viewport height.
41+
- accordionV2 panel count and open state remained unchanged.
42+
- No horizontal page overflow was detected.
43+
44+
## Full Samples Smoke
45+
- Skipped by explicit instruction.
46+
- Sample JSON remains out of scope until the sample alignment phase.
47+
48+
## Roadmap
49+
- No roadmap status change was made because this PR is a focused Palette Manager layout correction without a matching pending roadmap status item.
Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,12 @@
11
M docs/dev/codex_commands.md
22
M docs/dev/commit_comment.txt
33
M docs/dev/reports/codex_review.diff
4-
M tools/palette-manager-v2/index.html
5-
M tools/palette-manager-v2/modules/PaletteManagerApp.js
64
M tools/palette-manager-v2/paletteManagerV2.css
7-
?? docs/dev/reports/PR_26124_044_report.md
8-
?? docs/pr/PR_26124_044-accordionv2-theme-extract/
9-
?? src/engine/theme/accordionV2/
5+
?? docs/dev/reports/PR_26124_045_report.md
6+
?? docs/pr/PR_26124_045-palette-manager-hidden-header-wide-layout/
107

11-
docs/dev/codex_commands.md | 7 +-
12-
docs/dev/commit_comment.txt | 2 +-
13-
docs/dev/reports/codex_review.diff | 1027 +++++++-------------
14-
tools/palette-manager-v2/index.html | 20 +-
15-
.../modules/PaletteManagerApp.js | 28 -
16-
tools/palette-manager-v2/paletteManagerV2.css | 78 +-
17-
6 files changed, 391 insertions(+), 771 deletions(-)
8+
docs/dev/codex_commands.md | 13 +-
9+
docs/dev/commit_comment.txt | 2 +-
10+
docs/dev/reports/codex_review.diff | 625 ++++++++------------------
11+
tools/palette-manager-v2/paletteManagerV2.css | 57 +++
12+
4 files changed, 255 insertions(+), 442 deletions(-)

0 commit comments

Comments
 (0)