Skip to content

Commit 57f986e

Browse files
author
DavidQ
committed
Add Palette Manager V2 tag deletion guard and tag sort UI - PR_26124_053-palette-manager-tag-delete-and-sort-ui
1 parent e175788 commit 57f986e

13 files changed

Lines changed: 590 additions & 351 deletions

File tree

docs/dev/codex_commands.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,28 @@
1-
# Codex Commands - PR_26124_052-palette-manager-tag-normalization-and-duplicate-guards
1+
# Codex Commands - PR_26124_053-palette-manager-tag-delete-and-sort-ui
22

33
## Workflow
44
- Read `docs/dev/PROJECT_INSTRUCTIONS.md`.
55
- Used `.codex/skills/repo-build/SKILL.md`.
6-
- Created `docs/pr/PR_26124_052-palette-manager-tag-normalization-and-duplicate-guards/PLAN_PR.md`.
7-
- Created `docs/pr/PR_26124_052-palette-manager-tag-normalization-and-duplicate-guards/BUILD_PR.md`.
6+
- Created `docs/pr/PR_26124_053-palette-manager-tag-delete-and-sort-ui/PLAN_PR.md`.
7+
- Created `docs/pr/PR_26124_053-palette-manager-tag-delete-and-sort-ui/BUILD_PR.md`.
88
- Updated Palette Manager V2 only.
9-
- Created `docs/pr/PR_26124_052-palette-manager-tag-normalization-and-duplicate-guards/APPLY_PR.md`.
9+
- Created `docs/pr/PR_26124_053-palette-manager-tag-delete-and-sort-ui/APPLY_PR.md`.
1010

1111
## Validation Commands
1212
- `node --check tools/palette-manager-v2/controls/PaletteEditorControl.js`
13+
- `node --check tools/palette-manager-v2/controls/UserPaletteControl.js`
1314
- `node --check tools/palette-manager-v2/modules/PaletteManagerApp.js`
14-
- `node --check tools/palette-manager-v2/modules/paletteUtils.js`
15-
- Targeted served-browser Palette Manager V2 tag normalization, duplicate guard, and selected-tag removal check using Playwright from Node.
15+
- Targeted served-browser Palette Manager V2 tag delete, Tag sort, and compact source-control check using Playwright from Node.
1616
- `git diff --check`
1717
- `git diff --cached --check`
1818
- `npm run test:workspace-v2`
1919
- `npm run codex:review-artifacts`
20-
- Python `zipfile` packaging for `tmp/PR_26124_052-palette-manager-tag-normalization-and-duplicate-guards_delta.zip`
20+
- Python `zipfile` packaging for `tmp/PR_26124_053-palette-manager-tag-delete-and-sort-ui_delta.zip`
2121

2222
## Validation Outcome
2323
- JavaScript syntax checks: PASS.
2424
- Targeted served-browser Palette Manager V2 behavior check: PASS.
25-
- `git diff --check`: PASS.
25+
- `git diff --check`: PASS with Git LF-to-CRLF warnings for changed HTML/CSS files.
2626
- `git diff --cached --check`: PASS.
2727
- `npm run test:workspace-v2`: FAILED because the script is missing from `package.json`.
2828
- Review artifacts: generated.

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Normalize Palette Manager tags and guard duplicate swatches - PR_26124_052-palette-manager-tag-normalization-and-duplicate-guards
1+
Add Palette Manager tag delete and Tag sort UI - PR_26124_053-palette-manager-tag-delete-and-sort-ui
Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
# PR_26124_053 Report - Palette Manager Tag Delete and Sort UI
2+
3+
## Scope
4+
- Updated Palette Manager V2 only.
5+
- Added PR workflow docs and review artifacts.
6+
- Did not modify workspace/toolState/session behavior.
7+
- Did not modify sample JSON.
8+
- Did not modify `tools/shared`.
9+
- Did not modify shared accordionV2.
10+
- Did not add dependencies.
11+
12+
## Implementation
13+
- Restored the Add accordion title to `User Defined Swatch`.
14+
- Kept the Add button label as `User Defined Swatch`.
15+
- Added available-tag delete buttons in the Tags accordion.
16+
- Preserved available-tag toggle behavior for selected swatches.
17+
- Added delete blocking when a tag is still used by any User Palette swatch.
18+
- Added local User Palette `Tag` sort mode without changing shared sort services.
19+
- Kept Source Palette sort modes at Hue, Saturation, Brightness, and Name.
20+
- Compacted Source palette and Search source swatches controls into two-column rows.
21+
22+
## Validation
23+
- `node --check tools/palette-manager-v2/controls/PaletteEditorControl.js`: PASS.
24+
- `node --check tools/palette-manager-v2/controls/UserPaletteControl.js`: PASS.
25+
- `node --check tools/palette-manager-v2/modules/PaletteManagerApp.js`: PASS.
26+
- Targeted served-browser Palette Manager V2 validation: PASS.
27+
- `git diff --check`: PASS with Git LF-to-CRLF warnings for changed HTML/CSS files.
28+
- `npm run test:workspace-v2`: FAIL. The repository `package.json` has no `test:workspace-v2` script.
29+
- Full samples smoke test: skipped by instruction.
30+
31+
## Targeted Browser Coverage
32+
- Confirmed Add accordion title and Add button label.
33+
- Confirmed User Palette sort includes `Tag`.
34+
- Confirmed Source Palette sort does not include `Tag`.
35+
- Confirmed used tag delete is blocked with a validation/error message.
36+
- Confirmed unused tag delete removes the tag from the available tag list.
37+
- Confirmed Tag sort places tagged swatches before untagged swatches.
38+
- Confirmed Source palette and Search source swatches controls use compact source-control rows.
Lines changed: 20 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,30 @@
11
# git status --short
22
M docs/dev/codex_commands.md
33
M docs/dev/commit_comment.txt
4-
A docs/dev/reports/PR_26124_052_report.md
4+
A docs/dev/reports/PR_26124_053_report.md
55
M docs/dev/reports/codex_changed_files.txt
6-
M docs/dev/reports/codex_review.diff
7-
A docs/pr/PR_26124_052-palette-manager-tag-normalization-and-duplicate-guards/APPLY_PR.md
8-
A docs/pr/PR_26124_052-palette-manager-tag-normalization-and-duplicate-guards/BUILD_PR.md
9-
A docs/pr/PR_26124_052-palette-manager-tag-normalization-and-duplicate-guards/PLAN_PR.md
10-
M tools/palette-manager-v2/README.md
6+
MM docs/dev/reports/codex_review.diff
7+
A docs/pr/PR_26124_053-palette-manager-tag-delete-and-sort-ui/APPLY_PR.md
8+
A docs/pr/PR_26124_053-palette-manager-tag-delete-and-sort-ui/BUILD_PR.md
9+
A docs/pr/PR_26124_053-palette-manager-tag-delete-and-sort-ui/PLAN_PR.md
1110
M tools/palette-manager-v2/controls/PaletteEditorControl.js
12-
M tools/palette-manager-v2/how_to_use.html
11+
M tools/palette-manager-v2/controls/UserPaletteControl.js
1312
M tools/palette-manager-v2/index.html
1413
M tools/palette-manager-v2/modules/PaletteManagerApp.js
1514
M tools/palette-manager-v2/paletteManagerV2.css
1615

1716
# git diff --cached --stat
18-
docs/dev/codex_commands.md | 15 +-
19-
docs/dev/commit_comment.txt | 2 +-
20-
docs/dev/reports/PR_26124_052_report.md | 32 +
21-
docs/dev/reports/codex_changed_files.txt | 32 +-
22-
docs/dev/reports/codex_review.diff | 1033 +++++++-------------
23-
.../APPLY_PR.md | 27 +
24-
.../BUILD_PR.md | 35 +
25-
.../PLAN_PR.md | 40 +
26-
tools/palette-manager-v2/README.md | 6 +-
27-
.../controls/PaletteEditorControl.js | 36 +-
28-
tools/palette-manager-v2/how_to_use.html | 6 +-
29-
tools/palette-manager-v2/index.html | 10 +-
30-
.../modules/PaletteManagerApp.js | 46 +-
31-
tools/palette-manager-v2/paletteManagerV2.css | 4 +
32-
14 files changed, 598 insertions(+), 726 deletions(-)
17+
docs/dev/codex_commands.md | 16 +-
18+
docs/dev/commit_comment.txt | 2 +-
19+
docs/dev/reports/PR_26124_053_report.md | 38 ++
20+
docs/dev/reports/codex_changed_files.txt | 31 +-
21+
docs/dev/reports/codex_review.diff | 635 ++++++++++-----------
22+
.../APPLY_PR.md | 29 +
23+
.../BUILD_PR.md | 35 ++
24+
.../PLAN_PR.md | 45 ++
25+
.../controls/PaletteEditorControl.js | 17 +-
26+
.../controls/UserPaletteControl.js | 2 +-
27+
tools/palette-manager-v2/index.html | 6 +-
28+
.../modules/PaletteManagerApp.js | 64 ++-
29+
tools/palette-manager-v2/paletteManagerV2.css | 28 +
30+
13 files changed, 586 insertions(+), 362 deletions(-)

0 commit comments

Comments
 (0)