Skip to content

Commit 57f16ab

Browse files
author
DavidQ
committed
Restore the real data-driven samples index rendering.
Bring back phase descriptions, full per-phase sample lists, per-sample details, and sample pinning behavior on /samples/index.html while preserving the shared style/header consistency work. PR: BUILD_PR_STYLE_SAMPLES_INDEX_DATA_DRIVEN_LIST_RESTORE
1 parent c8025a4 commit 57f16ab

7 files changed

Lines changed: 1176 additions & 301 deletions

File tree

‎docs/dev/reports/samples_index_data_restore_strategy.txt‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
Samples index data-driven restore strategy
2+
3+
The regression is not just missing UI.
4+
The page is rendering the wrong model:
5+
- phase shell only
6+
- one xx01 launch entry
7+
instead of:
8+
- phase description
9+
- full sample list
10+
- per-sample details
11+
- pinning
12+
13+
Fix priority:
14+
1. restore the true data source
15+
2. restore full iteration/rendering
16+
3. restore pinning state/UI
17+
4. preserve shared style/header consistency

‎docs/operations/dev/codex_commands.md‎

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,26 @@ MODEL: GPT-5.4-codex
22
REASONING: high
33

44
COMMAND:
5-
Create BUILD_PR_STYLE_SAMPLES_INDEX_FILTER_AND_PHASE_LIST_RESTORE
5+
Create BUILD_PR_STYLE_SAMPLES_INDEX_DATA_DRIVEN_LIST_RESTORE
66

77
Rules:
88
- output ONLY the final zip to:
9-
<project folder>/tmp/BUILD_PR_STYLE_SAMPLES_INDEX_FILTER_AND_PHASE_LIST_RESTORE.zip
9+
<project folder>/tmp/BUILD_PR_STYLE_SAMPLES_INDEX_DATA_DRIVEN_LIST_RESTORE.zip
1010
- do NOT create staging folders in <project folder>/tmp
1111
- do NOT modify roadmap in the PR bundle
1212
- Codex updates roadmap during execution only if execution-backed status changes are earned
1313
- no embedded <style> blocks
1414
- no inline style=""
1515
- no JS-generated styling
16-
- keep scope limited to /samples/index.html and directly related shared dependencies only
16+
- keep scope limited to /samples/index.html and directly related sample-index data/rendering dependencies
1717

1818
Required work:
19-
1. Restore the filter UI on /samples/index.html if missing or hidden.
20-
2. Restore rendering of all phases on /samples/index.html.
21-
3. Verify filtering works correctly after restoration.
22-
4. Preserve the shared header/body consistency behavior.
23-
5. Keep the change narrow, testable, and behavior-restoring rather than redesigning.
19+
1. Identify the real samples index data source and render path.
20+
2. Remove any simplified phase-to-xx01 fallback rendering that is causing the wrong output.
21+
3. Restore phase descriptions.
22+
4. Restore all sample entries within each phase.
23+
5. Restore per-sample details sourced from the sample list data.
24+
6. Restore sample pinning behavior.
25+
7. Preserve filter behavior.
26+
8. Preserve the shared header/body consistency work.
27+
9. Keep the change narrow, testable, and behavior-restoring rather than redesigning.

‎docs/operations/dev/commit_comment.txt‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
Restore the missing filter UI and full phase listing on /samples/index.html.
1+
Restore the real data-driven samples index rendering.
22

3-
Keep the shared style/header consistency work intact while restoring expected samples page behavior.
3+
Bring back phase descriptions, full per-phase sample lists, per-sample details, and sample pinning behavior on /samples/index.html while preserving the shared style/header consistency work.
44

5-
PR: BUILD_PR_STYLE_SAMPLES_INDEX_FILTER_AND_PHASE_LIST_RESTORE
5+
PR: BUILD_PR_STYLE_SAMPLES_INDEX_DATA_DRIVEN_LIST_RESTORE

‎docs/pr/BUILD_PR_STYLE_SAMPLES_INDEX_DATA_DRIVEN_LIST_RESTORE.md‎

Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,61 @@
1+
# BUILD_PR_STYLE_SAMPLES_INDEX_DATA_DRIVEN_LIST_RESTORE
2+
3+
## Purpose
4+
Restore the real data-driven samples index behavior on `/samples/index.html` so it shows phase descriptions, all samples within each phase, and sample pinning behavior.
5+
6+
## Single PR Purpose
7+
Fix `/samples/index.html` so it renders the full sample list model correctly instead of collapsing each phase to a single `xx01` launch entry.
8+
9+
## Confirmed Regression
10+
Current behavior is still wrong:
11+
- phases display
12+
- each phase launches only `xx01`
13+
- phase descriptions are missing
14+
- per-sample details are missing
15+
- pinning behavior is missing
16+
- the real sample list is not being rendered
17+
18+
## Required Correct Behavior
19+
`/samples/index.html` must restore the original intended samples index behavior:
20+
1. show each phase
21+
2. show the phase description
22+
3. show all samples within each phase
23+
4. show per-sample details sourced from the sample list data
24+
5. preserve/restore sample pinning behavior
25+
6. keep filter behavior working
26+
7. keep the shared header/body style consistency work intact
27+
28+
## Required Fix Direction
29+
1. Identify the actual samples index data source / rendering path.
30+
2. Restore rendering from that source instead of using a simplified phase-to-`xx01` shortcut.
31+
3. Restore phase description rendering.
32+
4. Restore all sample entries per phase.
33+
5. Restore sample pinning behavior.
34+
6. Preserve the shared style migration work already completed.
35+
36+
## Likely Root Causes To Check
37+
- simplified phase-only rendering path introduced during refactor
38+
- wrong data source selected for samples page
39+
- phase metadata loaded but sample metadata ignored
40+
- grouping loop reduced to one sample per phase
41+
- template/render function no longer iterates the full sample list
42+
- pinned sample state/UI removed or disconnected
43+
- old samples index script path not being used
44+
- partial restore focused only on phases, not the underlying list model
45+
46+
## Required Rules
47+
- no embedded `<style>` blocks
48+
- no inline `style=""`
49+
- no JS-generated styling
50+
- keep scope limited to `/samples/index.html` and directly related sample-index data/rendering dependencies
51+
- preserve the shared header/body consistency fixes
52+
- restore behavior, do not redesign
53+
54+
## Acceptance
55+
- `/samples/index.html` shows phase descriptions
56+
- `/samples/index.html` shows all samples within each phase
57+
- `/samples/index.html` shows per-sample details from the sample list data
58+
- sample pinning behavior is restored
59+
- filter behavior continues to work
60+
- header/body consistency remains correct
61+
- page is visually and functionally testable

‎samples/index.html‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,16 +32,18 @@ <h1>Samples Hub</h1>
3232

3333
<main class="page-shell">
3434
<section class="content-section">
35-
<h2>Filter Phases</h2>
36-
<p>Filter by phase number, phase title, or description.</p>
35+
<h2>Filter Samples</h2>
36+
<p>Filter by phase, sample id, title, description, or tags.</p>
3737
<label for="samples-phase-filter-input">Search</label>
3838
<input id="samples-phase-filter-input" type="text" placeholder="Phase 17, rendering, runtime..." autocomplete="off" />
39+
<label for="samples-phase-filter-pinned-only">Pinned only</label>
40+
<input id="samples-phase-filter-pinned-only" type="checkbox" />
3941
<p id="samples-phase-filter-status" aria-live="polite"></p>
4042
</section>
4143

4244
<section class="content-section">
43-
<h2>All Phases</h2>
44-
<div id="samples-phase-list" class="card-grid"></div>
45+
<h2>All Phases and Samples</h2>
46+
<div id="samples-phase-list"></div>
4547
</section>
4648

4749
<div class="footer-note">

0 commit comments

Comments
 (0)